remember key lock and quantiziation settings across restarts

Reasonable to expect skins save the values, and we already save some of them (e.g. spinny).
Just needs <ConfigKey persist="true"> an every instance of the control on skin.xml

Related: lp:1277201

The new skin settings for toggling 2/4 decks, samplers, effects, and mixer GUIs should also be remembered across restarts.

It would also be cool to restore keylock settings from before scratch mode enabling when disabling scratch mode again.

IMHO keylock is disabled during scratching but re-enabled afterwards.
If you have an issue with it, please file a new bug and add a step by step instruction what happens and what should happen.
Thank you.

we disable keylock during scratching because it sounds really bizarre and often crashes in that situation. I would allow people to have bizarre sounds if they really want, but unfortunately the crashy nature of the libraries we use makes it a non-starter. For the most part they just weren't meant for the extreme rate changes that occur during scratching.

I tried adding persist="true" to the quantize and keylock ConfigKey elements in skins/LateNight/deck_row_5.xml and adding attributes with persist="true" to LateNight/skin.xml but that did not change anything.

jus: any idea why that isn't working?

The persist flag can only be set for COs that are generated by the Skin itself.
For all COs initiated by the Mixxx engine, the flag must be set in the Mixxx engine (C++ code)

Setting persist flags into the xml.
Not daily routine for the general users.

Can't this be done in a visual way?
For example by including an option in the preferences to indicate that one wants to have all his settings preserved?

Or even better, one such option per logical group of settings?
Something like
- remember your vinyl settings
- remember your volume settings
- remember your playback settings
- ...

Please note that I see other bugs that in my opinion can be solved together with this.
See question https://answers.launchpad.net/mixxx/+question/269258 for links.
Perhaps not all of them are relevant to this bug report, but some are certainly.

I don't see a need for this to be an option. They should be remembered always.

https://github.com/mixxxdj/mixxx/pull/653

We missed an opportunity here to add memorizing of settings in a more general approach as I described:
"../.. including an option in the preferences to indicate that one wants to have all his settings preserved?
Or even better, one such option per logical group of settings?
Something like
- remember your vinyl settings
- remember your volume settings
- remember your playback settings
- ..."

For the number of similar bug reports that I see, such an approach would comply to the need of several users.

Anyway ... regarding this fix, it does comply totally to what I initially wanted to ask for.

Tested with build 1.12 r5513 on Windows 7 64-bit.
Approved.

Thank you.

Remembering vinyl settings would be a bit more complicated and so would remembering volume settings. I don't know if everyone would want volume settings to be remembered, so there would have to be options added to the preferences.

Remembering volume adjustments would conflict with a lot of controllers. I'd prefer to just not do that. And I believe we store vinyl settings already. Please start a new feature request for remembering other settings.

I totally agree with you, Be.
But multiple users ARE asking for it.
And indeed, many others will be bothered if such settings are remembered by default,
so there must be options to enable or disable.

I'm convinced this will add a lot to Mixxx's user friendliness.
I'm not really asking for it, but I too would use it if it were there, specifically for the volume settings.

I will set up a Bug Report as Wishlist for it one of these days.

At least, the most annoying issue for me has been solved with this report.

@Owen: Crossed replies ... "I will set up a Bug Report as Wishlist for it one of these days."

What do you mean by volume settings? Volume is set by the sound card mixer. If you mean the gain controls in Mixxx, I think remembering those settings would be a bad idea because it would further the confusion between gain and volume. See https://bugs.launchpad.net/mixxx/+bug/1458677

I suggest that we take this up further in the new Bug Report as soon as I have set that one up,
because I think we are now polluting this one.
I'll publish the link here afterwards.

I would like to answer this, though:
Being Dutch speaking, I am a bit disabled on the "gain" versus "volume" front.
We do not have a translation for "gain", so we speak of volume for both.
That's why, when I have "gain" in mind, I would generally think and type "volume".

When I set up the new Bug Report, I will take special care to be more clear.

"Gain" is a rather technical term. Most English speakers do not know the difference between gain and volume.

I just submitted a Pull Request to clarify the difference in the manual:
https://github.com/mixxxdj/manual/pull/37
For more info, see the links on:
http://mixxx.org/wiki/doku.php/beginner_dj_links

Gathered all my remarks on remembering other settings in a little wishlist:
https://bugs.launchpad.net/mixxx/+bug/1502147

For "Remember key lock and quantization" ... Works great.
Thank you!

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7850