launchpad-buildd

[buildrecipe] should unconditionally include upstream source tarball

Bug #891892 reported by Jelmer Vernooij
28
This bug affects 4 people
Affects Status Importance Assigned to Milestone
launchpad-buildd
Fix Released
High
Jelmer Vernooij

Bug Description

I've created recipe to build newest xine-lib from Debian, but when I request a build I get an error:
 "Could not be uploaded correctly"

This is happening because the users' changelog entry has more entries for the upstream version - he is backporting a package from Debian. Since buildrecipe doesn't pass -v when generating changes, and since it can't really harm, it should always specify -sa to dpkg-buildpackage so the source tarball always gets included.

Tags: recipe

Related branches

lp:~jelmer/launchpad-buildd/dpkg-buildpackage-sa
William Grant: Approve (code)
Diff: 25 lines (+4/-1)
2 files modified
buildrecipe (+2/-1)
debian/changelog (+2/-0)
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It is slightly annoying that buildrecipe runs dpkg-buildpackage by itself, rather than relying on bzr-builder, which has its own code for creating debian diff files and upstream tarballs.

affects: launchpad → launchpad-buildd
Changed in launchpad-buildd:
status: New → Triaged
importance: Undecided → Medium
tags: added: recipe
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 891892] [NEW] [buildrecipe] should unconditionally include upstream source tarball

This is ready to be deployed in version 105 of launchpad-buildd, now
in ppa:canonical-bazaar/cat-proposed. It seems to be working ok on
staging.

On mature consideration we are going to wait until Monday for the lpnet rollout.

Robert Collins (lifeless)
Changed in launchpad-buildd:
importance: Medium → High
Revision history for this message
Mantas Kriaučiūnas (mantas) wrote :

Hi Martin Pool and Robert Collins,

I still can't build recipe with newest xine-lib code from Debian, see:

https://code.launchpad.net/~baltix-members/+recipe/xine-lib-debian

Please tell me when I can repeat the build successfully.

Martin Pool (mbp) wrote on 2011-11-18:
> Re: [Bug 891892] [NEW] [buildrecipe] should unconditionally include upstream source tarball
>
> This is ready to be deployed in version 105 of launchpad-buildd, now in ppa:canonical-bazaar/cat-proposed. It seems to be working ok on staging.
> On mature consideration we are going to wait until Monday for the lpnet rollout.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi Mantas,

We'll mark the bug as Fix released when it is deployed.

Jelmer Vernooij (jelmer)
Changed in launchpad-buildd:
status: Triaged → Fix Committed
assignee: nobody → Jelmer Vernooij (jelmer)
Revision history for this message
Martin Pool (mbp) wrote :

This is still queued up waiting for deployment. We should have it out this week.

Revision history for this message
Mantas Kriaučiūnas (mantas) wrote :

Hi Martin Pool and Jelmer Vernooij,

Two weeks have passed, but I still can't build recipe with newest adblock-plus code from Debian, see:

https://code.launchpad.net/~baltix-members/+recipe/adblock-plus-debian

Please tell me when I can repeat the build successfully.

Martin Pool (mbp) wrote on 2011-11-28:
> This is still queued up waiting for deployment. We should have it out this week.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Hi Mantas,

I would recommend building the package as a native package instead.

We are working on adding support for non-native packages, but this is a new feature (previously Launchpad would automatically convert your package to a native package) and there are still issues with proper support for non-native packages. Once the fix for this bug lands, we'll mark this bug as fix released.

Revision history for this message
Robert Collins (lifeless) wrote :

@poolie is there an RT or something for the deploy?

Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 891892] Re: [buildrecipe] should unconditionally include upstream source tarball

On Sun, Jan 29, 2012 at 11:01:42PM -0000, Robert Collins wrote:
> @poolie is there an RT or something for the deploy?
 I'm not 100% sure, but I think that this has already landed.

Cheers,

Jelmer

Jelmer Vernooij (jelmer)
Changed in launchpad-buildd:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.