[FFe] Stop trying apt_pkg.pkgsystem_(un)lock()
Bug #1795387 reported by
Balint Reczey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| update-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Lock() can succeed when update-manager is ran as root (not recommended and not done by default) potentially taking the lock blocking other dpkg frontends.
Update-manager is typically ran as a normal user thus lock operations fail and are ignored already.
Dropping the locking operations makes the code less confusing and more predictable.
Related branches
lp:~rbalint/update-manager/no-apt-lock
- Julian Andres Klode: Approve
-
Diff: 68 lines (+0/-22)3 files modifiedUpdateManager/UpdateManager.py (+0/-10)
UpdateManager/backend/InstallBackendAptdaemon.py (+0/-8)
UpdateManager/backend/InstallBackendSynaptic.py (+0/-4)
| summary: |
- Stop trying apt_pkg.pkgsystem_(un)lock() + [FFe] Stop trying apt_pkg.pkgsystem_(un)lock() |
| description: | updated |
Revision history for this message
| Balint Reczey (rbalint) wrote | #1 |
| tags: | added: patch |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in update-manager (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
This bug was fixed in the package update-manager - 1:18.10.9
---------------
update-manager (1:18.10.9) cosmic; urgency=medium
* Allow unselecting updates and performing only removals (LP: #1792320)
* Stop trying apt_pkg.
(LP: #1795387)
* Keep or delete packages after looping over all of them.
This prevents the resolver from changing the packages in the loop resulting
in not keeping some phased packages back from being upgraded. (LP: #1072136)
* Fix PEP 8 warnings (LP: #1795384)
Also ignore "W503 line break before binary operator" because it will
become the best practice
-- Balint Reczey <email address hidden> Mon, 01 Oct 2018 18:00:40 +0200