Ubuntu
update-manager package

[FFe] Autopkgtest fails with cosmic's pep8

Bug #1795384 reported by Balint Reczey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

There are many PEP 8 warnings when running:
autopkgtest update-manager -U -- lxd autopkgtest/ubuntu/cosmic/amd64

...
autopkgtest [14:27:57]: test nose-tests: [-----------------------

(nosetests3:3729): dbind-WARNING **: 12:27:58.256: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files
............................................................../tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../UpdateManager/ChangelogViewer.py:165:46: W504 line break after binary operator
/tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../janitor/plugincore/plugins/langpack_manual_plugin.py:71:21: W504 line break after binary operator
/tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../janitor/plugincore/plugins/langpack_manual_plugin.py:72:21: W504 line break after binary operator
/tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../janitor/plugincore/plugins/langpack_manual_plugin.py:73:21: W504 line break after binary operator
/tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../janitor/plugincore/tests/test_documentation.py:37:5: W504 line break after binary operator
/tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../janitor/plugincore/tests/test_documentation.py:38:5: W504 line break after binary operator
/tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../janitor/plugincore/tests/test_documentation.py:39:5: W504 line break after binary operator
/tmp/autopkgtest.LsVtxy/build.aYW/src/tests/../UpdateManager/Dialogs.py:371:53: W504 line break after binary operator
...

Tags: patch

Related branches

lp:~rbalint/update-manager/fix-pep8-cosmic
Brian Murray: Approve
Diff: 555 lines (+112/-98)
21 files modified
UpdateManager/ChangelogViewer.py (+2/-2)
UpdateManager/Core/MetaRelease.py (+4/-4)
UpdateManager/Core/MyCache.py (+15/-15)
UpdateManager/Core/UpdateList.py (+15/-14)
UpdateManager/Core/utils.py (+1/-1)
UpdateManager/Dialogs.py (+2/-2)
UpdateManager/UpdateManager.py (+3/-3)
UpdateManager/UpdatesAvailable.py (+11/-11)
UpdateManager/backend/InstallBackendAptdaemon.py (+2/-2)
UpdateManager/backend/__init__.py (+10/-10)
debian/changelog (+13/-0)
debian/source_update-manager.py (+3/-3)
janitor/plugincore/manager.py (+6/-6)
janitor/plugincore/plugins/dpkg_status_plugin.py (+3/-3)
janitor/plugincore/plugins/kdelibs4to5_plugin.py (+2/-2)
janitor/plugincore/plugins/langpack_manual_plugin.py (+4/-4)
janitor/plugincore/tests/test_documentation.py (+4/-4)
tests/test_hwe_support_status.py (+5/-5)
tests/test_pep8.py (+1/-1)
tests/test_update_origin.py (+4/-4)
tests/test_utils.py (+2/-2)
Revision history for this message
Balint Reczey (rbalint) wrote :
summary: - Autopkgtest fails with cosmic's pep8
+ [FFe] Autopkgtest fails with cosmic's pep8
Ubuntu Foundations Team Bug Bot (crichton)
tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:18.10.9

---------------
update-manager (1:18.10.9) cosmic; urgency=medium

  * Allow unselecting updates and performing only removals (LP: #1792320)
  * Stop trying apt_pkg.pkgsystem_(un)lock(), as a normal user it always fails
    (LP: #1795387)
  * Keep or delete packages after looping over all of them.
    This prevents the resolver from changing the packages in the loop resulting
    in not keeping some phased packages back from being upgraded. (LP: #1072136)
  * Fix PEP 8 warnings (LP: #1795384)
    Also ignore "W503 line break before binary operator" because it will
    become the best practice

 -- Balint Reczey <email address hidden> Mon, 01 Oct 2018 18:00:40 +0200

Changed in update-manager (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.