Don't restrict jump list actions to Unity

Bug #1615549 reported by 8p-k26-gj
32
This bug affects 5 people
Affects Status Importance Assigned to Milestone
firefox (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Firefox in its application .desktop file provides a couple of Desktop Actions ("jump list actions"), for opening a new tab or a new incognito tab. Since Plasma 5.6 those actions are also supported by KDE Plasma and there's no reason these actions should be restricted to Unity (OnlyShowIn=Unity).

They are currently shown in Plasma and work just fine as I did not implement support for OnlyShowIn/NotShowIn in Desktop Actions (which I didn't see explicitly mentioned in the spec though). For Plasma 5.8 which will have MPRIS controls in the context menu I want to add support for this to avoid double entries in media players (many abuse static Desktop Actions for player controls).

However, I don't want to break users relying on the ability to open new (incognito) tabs through the task bar in Plasma, hence I request the OnlyShowIn for Firefox desktop actions to be dropped. (Alternatively "KDE" could be added, but I don't see any reason for not enabling them globally).

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in firefox (Ubuntu):
status: New → Confirmed
Revision history for this message
Serhiy (xintx-ua) wrote :

According to
$ desktop-file-validate /usr/share/applications/firefox.desktop
OnlyShowIn was deprecated completely. Also it shows a lot of other errors in the file.

Revision history for this message
Serhiy (xintx-ua) wrote :

sudo sed -i 's/^OnlyShowIn=.*$//' /usr/share/applications/firefox.desktop

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 56.0+build6-0ubuntu0.17.04.1

---------------
firefox (56.0+build6-0ubuntu0.17.04.1) zesty-security; urgency=medium

  * New upstream stable release (56.0build6)

  [ Rico Tzschichholz ]
  * Bump build-dep on rustc >= 1.17.0 and cargo >= 0.18
  * Build-dep on clang-3.9, llvm-3.9-dev on 64bit archs for stylo
    - update debian/control{,.in}
  * Refresh patches
    - update debian/patches/revert-upstream-search-engine-changes.patch
  * Drop upstreamed patches
    - debian/patches/build-ppc64.patch
    - debian/patches/fix-no-jit-backend.patch
  * Don't try to check checksums of windows-only binary files which are
    not included in the tarball
    - debian/patches/rust-drop-dll-checksums.patch
  * Add ppc64/s390x build fixes
    - debian/patches/build-ppc64-s390x-nss.patch
  * Don't restrict Destop Actions to Unity (LP: #1615549)
    and make them compliant with GNOME-Shell
    - debian/firefox.desktop.in

  [ Chris Coulson ]
  * Update unity-menubar.patch for Stylo, nsAdoptedCString removal, and
    imgRequestProxy, nsITimer and mozilla::Runnable changes
  * Drop patches that are fixed upstream
    - remove debian/patches/cubeb-pulse-rs-fix.patch
    - update debian/patches/series
  * Don't pass -mfloat-abi=softfp when building webrtc on armhf
    - add debian/patches/webrtc-fix-compiler-flags-for-armhf.patch
    - update debian/patches/series
  * Fix skia build failure on aarch64 against kernel headers that don't
    define HWCAP_CRC32
    - add debian/patches/skia-fix-aarch64-build-on-older-linux.patch
    - update debian/patches/series

 -- Chris Coulson <email address hidden> Thu, 21 Sep 2017 23:15:16 +0100

Changed in firefox (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 56.0+build6-0ubuntu0.14.04.1

---------------
firefox (56.0+build6-0ubuntu0.14.04.1) trusty-security; urgency=medium

  * New upstream stable release (56.0build6)

  [ Rico Tzschichholz ]
  * Bump build-dep on rustc >= 1.17.0 and cargo >= 0.18
  * Build-dep on clang-3.9, llvm-3.9-dev on 64bit archs for stylo
    - update debian/control{,.in}
  * Refresh patches
    - update debian/patches/revert-upstream-search-engine-changes.patch
  * Drop upstreamed patches
    - debian/patches/build-ppc64.patch
    - debian/patches/fix-no-jit-backend.patch
  * Don't try to check checksums of windows-only binary files which are
    not included in the tarball
    - debian/patches/rust-drop-dll-checksums.patch
  * Add ppc64/s390x build fixes
    - debian/patches/build-ppc64-s390x-nss.patch
  * Don't restrict Destop Actions to Unity (LP: #1615549)
    and make them compliant with GNOME-Shell
    - debian/firefox.desktop.in

  [ Chris Coulson ]
  * Update unity-menubar.patch for Stylo, nsAdoptedCString removal, and
    imgRequestProxy, nsITimer and mozilla::Runnable changes
  * Drop patches that are fixed upstream
    - remove debian/patches/cubeb-pulse-rs-fix.patch
    - update debian/patches/series
  * Don't pass -mfloat-abi=softfp when building webrtc on armhf
    - add debian/patches/webrtc-fix-compiler-flags-for-armhf.patch
    - update debian/patches/series
  * Fix skia build failure on aarch64 against kernel headers that don't
    define HWCAP_CRC32
    - add debian/patches/skia-fix-aarch64-build-on-older-linux.patch
    - update debian/patches/series

 -- Chris Coulson <email address hidden> Thu, 21 Sep 2017 23:23:37 +0100

Changed in firefox (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firefox - 56.0+build6-0ubuntu0.16.04.1

---------------
firefox (56.0+build6-0ubuntu0.16.04.1) xenial-security; urgency=medium

  * New upstream stable release (56.0build6)

  [ Rico Tzschichholz ]
  * Bump build-dep on rustc >= 1.17.0 and cargo >= 0.18
  * Build-dep on clang-3.9, llvm-3.9-dev on 64bit archs for stylo
    - update debian/control{,.in}
  * Refresh patches
    - update debian/patches/revert-upstream-search-engine-changes.patch
  * Drop upstreamed patches
    - debian/patches/build-ppc64.patch
    - debian/patches/fix-no-jit-backend.patch
  * Don't try to check checksums of windows-only binary files which are
    not included in the tarball
    - debian/patches/rust-drop-dll-checksums.patch
  * Add ppc64/s390x build fixes
    - debian/patches/build-ppc64-s390x-nss.patch
  * Don't restrict Destop Actions to Unity (LP: #1615549)
    and make them compliant with GNOME-Shell
    - debian/firefox.desktop.in

  [ Chris Coulson ]
  * Update unity-menubar.patch for Stylo, nsAdoptedCString removal, and
    imgRequestProxy, nsITimer and mozilla::Runnable changes
  * Drop patches that are fixed upstream
    - remove debian/patches/cubeb-pulse-rs-fix.patch
    - update debian/patches/series
  * Don't pass -mfloat-abi=softfp when building webrtc on armhf
    - add debian/patches/webrtc-fix-compiler-flags-for-armhf.patch
    - update debian/patches/series
  * Fix skia build failure on aarch64 against kernel headers that don't
    define HWCAP_CRC32
    - add debian/patches/skia-fix-aarch64-build-on-older-linux.patch
    - update debian/patches/series

 -- Chris Coulson <email address hidden> Thu, 21 Sep 2017 23:20:05 +0100

Changed in firefox (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.