Ubuntu
firefox package

Where should I create pull requests/send a patch against firefox.desktop?

Asked by Serhiy Zahoriya on 2017-08-10

There is a bug that's trivial to fix and I've sent pull request couple of months ago directly into lp:firefox but it has been ignored. Is it because of limited maintainer resource or did I choose a wrong branch for the pull request?

Question information

Language:
English Edit question
Status:
Solved
For:
Ubuntu firefox Edit question
Assignee:
No assignee Edit question
Solved by:
Serhiy Zahoriya
Solved:
2020-02-29
Last query:
2020-02-29
Last reply:
2020-02-29
Launchpad Janitor (janitor) said : #1

This question was expired because it remained in the 'Open' state without activity for the last 15 days.

Serhiy Zahoriya (xintx-ua) said : #2

I already wonder how many times I'll have to reopen it. Sorry.

Manfred Hampl (m-hampl) said : #3

Maybe you should try contacting someone from the Mozilla team https://launchpad.net/~mozillateam

Serhiy Zahoriya (xintx-ua) said : #4

I thought this is the place to contact them. Are there no notifications for these questions?

Serhiy Zahoriya (xintx-ua) said : #5

Sent the message, thank you.

Bernard Stafford (bernard010) said : #6

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
Patch -> Review -> Testing -> Submit Patch -> Get Reviews -> Push the Patch (landing patch}
Contact Developers on IRC Chat.

Serhiy Zahoriya (xintx-ua) said : #7

Bernard, I don't see the debian/firefox.desktop.in file in the upstream code https://hg.mozilla.org/mozilla-central/file

Manfred Hampl (m-hampl) said : #8

My comments:

1. The file "debian/firefox.desktop.in" is not part of the official Mozilla source, but is added by Ubuntu (or by Debian; Ubuntu is taking over software from Debian to avoid double packaging work). The correct addressee for a bug report with this file is Debian or Ubuntu, and not Mozilla. This is valid for all files in the "debian" directory

2. As far as I can see in Bug #1615549 these modifications have already been incorporated in firefox version 56.* in October 2017
  * Don't restrict Destop Actions to Unity (LP: #1615549)
    and make them compliant with GNOME-Shell
    - debian/firefox.desktop.in

I do not understand why this question is now popping up again.

Serhiy Zahoriya (xintx-ua) said : #9

Because Bernard wanted to help with it / close it but wasn't paying enough attention unfortunately. Anyway, closing.