[keymap] Samsung Series 9 laptop 900X3C: missing some keys

Status changed to 'Confirmed' because the bug affects multiple users.

See RedHat 838036 too (sans "/usr" prefix).

Can you please provide a mapping of scan codes to intended key codes, as documented by /usr/share/doc/udev/README.keymap.txt.gz ? Thanks!

Added keymap and force-release file as attachments, originally from http://blog.nonobis.nl/?p=11

I added this upstream to the standard samsung-series-9 map, which also covers a lot of similar models: http://cgit.freedesktop.org/systemd/systemd/commit/?id=90fc91d0065e20

Note that this keeps the "silent mode" key as "prog3", as nothing in the desktop actually would do anything with KEY_SILENTMODE.

Thanks!

"Note that this keeps the "silent mode" key as "prog3", as nothing in the desktop actually would do anything with KEY_SILENTMODE."

Actually when the samsung laptop module is loaded it is possible to switch the "performance mode" of the laptop, which for example I have bounded to the "silent mode"-button since that is exactly what is accomplishes. (Slows down the performance which lowers fan-noise)

Of course by default it wouldn't do anything for a user, but by exposing the correct name it could be easier in the future when/if more laptops ship with similar functionality.

Martin, I don't understand your patch.

I don't think there is such a model as "900XC3".

All Samsung series 9 laptops use the same key scancodes.

Martin please revert this patch.

It is absolutely incorrect.

Samsung never ever made a laptop with a model "900XC3"

Samsung made a model called "900X3C" but that model is already caught by "*900X3*" expression.

Please revert your patch and close this bug as "Invalid".

Thanks.

This model seems to have been added in upstream commit 68c77c2f6168dca0ce7b5edb81612cd6be39e63d

http://cgit.freedesktop.org/systemd/systemd/diff/keymaps/samsung-series-9?id=68c77c2f6168dca0ce7b5edb81612cd6be39e63d

Before that it was definitely not working, and on my 13.04 install I still had to manually fix it, so I can't see why this bug would be invalid?

Ie, it was a problem 12 months ago, it is still a problem now, and the exact solution was posted in the initial bugreport.

The device name is "900X3C" and the following commit upstream fixes the issue:

http://cgit.freedesktop.org/systemd/systemd/diff/?id=68c77c2f6168dca0ce7b5edb81612cd6be39e63d

But this fix is still not part of Ubuntu, so why should this bug be invalid?

Martin's comment #7 and the corresponding patch

http://cgit.freedesktop.org/systemd/systemd/commit/?id=90fc91d0065e20

should be reverted.

I don't have problem's with

http://cgit.freedesktop.org/systemd/systemd/diff/?id=68c77c2f6168dca0ce7b5edb81612cd6be39e63d

patch.

This bug was fixed in the package systemd - 204-0ubuntu5

---------------
systemd (204-0ubuntu5) saucy; urgency=low

  * Add 0000-upstream-keymaps.patch: Backport latest keymap fixes from
    upstream, as we won't be able to update to newer upstream releases anytime
    soon. (LP: #1193147, #1157334, #1152377, #1012365, #727139)
  * Refresh our patches to apply cleanly.
 -- Martin Pitt <email address hidden> Fri, 05 Jul 2013 08:54:06 +0200

sven, do you agree that this commit is incorrect and should be reverted?

http://cgit.freedesktop.org/systemd/systemd/commit/?id=90fc91d0065e20

Yes, it should be reverted: there is no "900XC3" produced by Samsung. The actual "900X3C" (I'm writing on just now) is matched by *900X3*.

Reverted in http://cgit.freedesktop.org/systemd/systemd/commit/?id=f3c19b70fa97. Sorry for mixing up the letters! As this is essentially a no-op, I just leave this bug closed.

Is there a fix for this for 13.04?

You can download the two rules files from http://cgit.freedesktop.org/systemd/systemd/tree/src/udev/keymap?id=f3c19b70fa97 and put them into /etc/udev/rules.d/ for the time being. (For Ubuntu 13.04)