Merge lp:~torkvemada/quickly/packageextras into lp:quickly

Proposed by Vsevolod Velichko
Status: Merged
Merged at revision: 682
Proposed branch: lp:~torkvemada/quickly/packageextras
Merge into: lp:quickly
Diff against target: 49 lines (+9/-3)
1 file modified
data/templates/ubuntu-application/share.py (+9/-3)
To merge this branch: bzr merge lp:~torkvemada/quickly/packageextras
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+115279@code.launchpad.net

Description of the change

'quickly release' option that will package for ppa as for 'extras'

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

As discussde on IRC, I think this should be in quickly share --extra to test the extra repository integration there, not in release.

review: Needs Fixing
lp:~torkvemada/quickly/packageextras updated
677. By Vsevolod Velichko

Move --extras packaging to share rather than to release command

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks for your work here! Merging :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/templates/ubuntu-application/share.py'
--- data/templates/ubuntu-application/share.py 2011-07-22 10:47:34 +0000
+++ data/templates/ubuntu-application/share.py 2012-07-24 10:26:53 +0000
@@ -33,14 +33,15 @@
3333
34launchpad = None34launchpad = None
35ppa_name = None35ppa_name = None
36for_extras = False
36i = 037i = 0
37args = []38args = []
38argv = sys.argv39argv = sys.argv
3940
40options = ["--ppa",]41options = ["--ppa", "--extras",]
4142
42def usage():43def usage():
43 templatetools.print_usage(_('quickly share [--ppa <ppa | group/ppa>]'))44 templatetools.print_usage(_('quickly share [--extras] [--ppa <ppa | group/ppa>]'))
44def help():45def help():
45 print _("""Updates your PPA with the the latest saved project changes.46 print _("""Updates your PPA with the the latest saved project changes.
4647
@@ -57,6 +58,9 @@
57the package three times since then, another run of 'quickly share' will58the package three times since then, another run of 'quickly share' will
58use a new version of 10.07.2-public4.59use a new version of 10.07.2-public4.
5960
61Passing --extras will create a package similar to one created by
62the "quickly package --extras" command. It will install files into /opt.
63
60You can optionally run 'quickly package' and test your package to make64You can optionally run 'quickly package' and test your package to make
61sure it installs as expected.""")65sure it installs as expected.""")
62def shell_completion(argv):66def shell_completion(argv):
@@ -84,6 +88,8 @@
84 else:88 else:
85 cmd = commands.get_command('share', 'ubuntu-application')89 cmd = commands.get_command('share', 'ubuntu-application')
86 templatetools.usage_error(_("No PPA provided."), cmd=cmd)90 templatetools.usage_error(_("No PPA provided."), cmd=cmd)
91 elif arg == '--extras':
92 for_extras = True
87 else:93 else:
88 cmd = commands.get_command('share', 'ubuntu-application')94 cmd = commands.get_command('share', 'ubuntu-application')
89 templatetools.usage_error(_("Unknown option: %s." % arg), cmd=cmd)95 templatetools.usage_error(_("Unknown option: %s." % arg), cmd=cmd)
@@ -148,7 +154,7 @@
148 sys.exit(1)154 sys.exit(1)
149155
150# creation/update debian packaging156# creation/update debian packaging
151return_code = packaging.updatepackaging()157return_code = packaging.updatepackaging(installopt=for_extras)
152if return_code != 0:158if return_code != 0:
153 print _("ERROR: can't create or update ubuntu package")159 print _("ERROR: can't create or update ubuntu package")
154 sys.exit(1)160 sys.exit(1)

Subscribers

People subscribed via source and target branches