Merge lp:~mbp/kanban/741509-utf8 into lp:kanban

Proposed by Martin Pool
Status: Merged
Merged at revision: 30
Proposed branch: lp:~mbp/kanban/741509-utf8
Merge into: lp:kanban
Diff against target: 34 lines (+3/-1)
3 files modified
kanban/commands.py (+1/-1)
kanban/templates/kanban.html (+1/-0)
kanban/templates/roadmap.html (+1/-0)
To merge this branch: bzr merge lp:~mbp/kanban/741509-utf8
Reviewer Review Type Date Requested Status
Jamu Kakar Approve
Review via email: mp+80180@code.launchpad.net

Description of the change

Always write html as utf-8 regardless of wacky Python encoding. (It's 2011! Come on!)

Mark the html header as such.

To post a comment you must log in.
Revision history for this message
Jamu Kakar (jkakar) wrote :

Awesome, thanks, +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'kanban/commands.py'
--- kanban/commands.py 2011-03-12 07:54:27 +0000
+++ kanban/commands.py 2011-10-24 06:46:23 +0000
@@ -44,7 +44,7 @@
44 self.outf.write(html)44 self.outf.write(html)
45 else:45 else:
46 with open(output_file, "w") as stream:46 with open(output_file, "w") as stream:
47 stream.write(html)47 stream.write(html.encode('utf-8'))
4848
4949
50class cmd_generate_person_kanban(HTMLOutputMixin, Command):50class cmd_generate_person_kanban(HTMLOutputMixin, Command):
5151
=== modified file 'kanban/templates/kanban.html'
--- kanban/templates/kanban.html 2011-04-02 09:32:52 +0000
+++ kanban/templates/kanban.html 2011-10-24 06:46:23 +0000
@@ -1,5 +1,6 @@
1<html>1<html>
2 <head>2 <head>
3 <META http-equiv="Content-Type" content="text/html; charset=utf-8">
3 <title>{{ kanban_board.project_name }} {{ kanban_board.name }}</title>4 <title>{{ kanban_board.project_name }} {{ kanban_board.name }}</title>
4 {% if kanban_board.include_needs_testing %}5 {% if kanban_board.include_needs_testing %}
5 <link rel="stylesheet" type="text/css" href="media/decogrids-12.css" />6 <link rel="stylesheet" type="text/css" href="media/decogrids-12.css" />
67
=== modified file 'kanban/templates/roadmap.html'
--- kanban/templates/roadmap.html 2011-01-29 17:32:37 +0000
+++ kanban/templates/roadmap.html 2011-10-24 06:46:23 +0000
@@ -1,5 +1,6 @@
1<html>1<html>
2 <head>2 <head>
3 <META http-equiv="Content-Type" content="text/html; charset=utf-8">
3 <title>{{ roadmap.project }} roadmap</title>4 <title>{{ roadmap.project }} roadmap</title>
4 <link rel="stylesheet" type="text/css" href="media/decogrids-12.css" />5 <link rel="stylesheet" type="text/css" href="media/decogrids-12.css" />
5 <link rel="stylesheet" type="text/css" href="media/kanban.css" />6 <link rel="stylesheet" type="text/css" href="media/kanban.css" />

Subscribers

People subscribed via source and target branches

to all changes: