Kanban

Merge lp:~mbp/kanban/741509-utf8 into lp:kanban

  1. 741509-utf8
  2. Merge into trunk
Proposed by Martin Pool
Status: Merged
Merged at revision: 30
Proposed branch: lp:~mbp/kanban/741509-utf8
Merge into: lp:kanban
Diff against target: 34 lines (+3/-1)
3 files modified
kanban/commands.py (+1/-1)
kanban/templates/kanban.html (+1/-0)
kanban/templates/roadmap.html (+1/-0)
To merge this branch: bzr merge lp:~mbp/kanban/741509-utf8
Reviewer Review Type Date Requested Status
Jamu Kakar Approve
Review via email: mp+80180@code.launchpad.net

Description of the change

Always write html as utf-8 regardless of wacky Python encoding. (It's 2011! Come on!)

Mark the html header as such.

To post a comment you must log in.
Revision history for this message
Jamu Kakar (jkakar) wrote :

Awesome, thanks, +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'kanban/commands.py'
2--- kanban/commands.py 2011-03-12 07:54:27 +0000
3+++ kanban/commands.py 2011-10-24 06:46:23 +0000
4@@ -44,7 +44,7 @@
5 self.outf.write(html)
6 else:
7 with open(output_file, "w") as stream:
8- stream.write(html)
9+ stream.write(html.encode('utf-8'))
10
11
12 class cmd_generate_person_kanban(HTMLOutputMixin, Command):
13
14=== modified file 'kanban/templates/kanban.html'
15--- kanban/templates/kanban.html 2011-04-02 09:32:52 +0000
16+++ kanban/templates/kanban.html 2011-10-24 06:46:23 +0000
17@@ -1,5 +1,6 @@
18 <html>
19 <head>
20+ <META http-equiv="Content-Type" content="text/html; charset=utf-8">
21 <title>{{ kanban_board.project_name }} {{ kanban_board.name }}</title>
22 {% if kanban_board.include_needs_testing %}
23 <link rel="stylesheet" type="text/css" href="media/decogrids-12.css" />
24
25=== modified file 'kanban/templates/roadmap.html'
26--- kanban/templates/roadmap.html 2011-01-29 17:32:37 +0000
27+++ kanban/templates/roadmap.html 2011-10-24 06:46:23 +0000
28@@ -1,5 +1,6 @@
29 <html>
30 <head>
31+ <META http-equiv="Content-Type" content="text/html; charset=utf-8">
32 <title>{{ roadmap.project }} roadmap</title>
33 <link rel="stylesheet" type="text/css" href="media/decogrids-12.css" />
34 <link rel="stylesheet" type="text/css" href="media/kanban.css" />

Subscribers

People subscribed via source and target branches

to all changes: