Shutter

Adding icons to shutter menu

Asked by José Borges Ferreira (underspell)

Hi!

I have recentlly commited a patch to allow sending the screenshot via email.
I would like also to add a icon to the menu and a big button on the toolbar. I have the patch for it, but i use the icon that came with Ubuntu, namely /usr/share/icons/gnome/scalable/actions/stock_mail-forward.svg .

My questions are:

Can i send a patch to include this file on that path ?
Is it safe to assume that icon is on all gnome distros ?
Can and/or should be copied under $shutter_root ?

Question information

Language:
English Edit question
Status:
Solved
For:
Shutter Edit question
Assignee:
No assignee Edit question
Solved by:
Vadim Peretokin
Solved:
Last query:
Last reply:
Revision history for this message
Mario Kemper (Romario) (mario-kemper) said : 		#1

I've already applied your patch and it is included in the latest beta:
https://launchpad.net/~shutter-testing-team/+archive/ppa

This is how it looks like now. I've added an icon and did some other minor changes.
http://www.ubuntu-pics.de/bild/30679/shutter_0_85_p6FG1x.png

You should load an icon like this (this is how it is implemented now):
 $self->{_menuitem_email} = Gtk2::ImageMenuItem->new($d->get('Send by Email...'));
 $self->{_menuitem_email}->set_image(
  Gtk2::Image->new_from_icon_name( 'gnome-stock-mail-snd', 'menu' )
 );

http://library.gnome.org/devel/gtk/stable/GtkImage.html#gtk-image-new-from-icon-name (for a detailed explanation)

I don't know if a button in the toolbar will be necessary...There are plans to implemented a customizable toolbar. Maybe we should wait for that feature to avoid cluttering the user interface.

Thanks again for submitting patches. Keep up the good work.

Regards
Mario

Revision history for this message
Best Vadim Peretokin (vperetokin) said : 		#2

Yes, don't add it to the main toolbar by default.

On Nov 12, 2009 8:44 AM, "Mario Kemper (Romario)" <
<email address hidden>> wrote:

Question #89728 on Shutter changed:
https://answers.launchpad.net/shutter/+question/89728
   Status: Open => Answered

Mario Kemper (Romario) proposed the following answer:
I've already applied your patch and it is included in the latest beta:
https://launchpad.net/~shutter-testing-team/+archive/ppa

This is how it looks like now. I've added an icon and did some other minor
changes.
http://www.ubuntu-pics.de/bild/30679/shutter_0_85_p6FG1x.png

You should load an icon like this (this is how it is implemented now):
       $self->{_menuitem_email} = Gtk2::ImageMenuItem->new($d->get('Send by
Email...'));
       $self->{_menuitem_email}->set_image(
               Gtk2::Image->new_from_icon_name( 'gnome-stock-mail-snd',
'menu' )
       );

http://library.gnome.org/devel/gtk/stable/GtkImage.html#gtk-image-new-
from-icon-name (for a detailed explanation)

I don't know if a button in the toolbar will be necessary...There are
plans to implemented a customizable toolbar. Maybe we should wait for
that feature to avoid cluttering the user interface.

Thanks again for submitting patches. Keep up the good work.

Regards
Mario

-- You received this question notification because you are an answer contact
for Shutter.

Revision history for this message
José Borges Ferreira (underspell) (jose-ferreira) said : 		#3

Thanks Vadim Peretokin, that solved my question.