branch feedback

Asked by Alex

Hi,

Just quriuos if anybody tested / or even uses lp:~ddrmoscow/quexs/Features branch?

would appreciate any comments/ bug reports / ideas/ suggestions

Thanks in advance,

Alex

Question information

Language:
English Edit question
Status:
Expired
For:
queXS Edit question
Assignee:
No assignee Edit question
Last query:
Last reply:
Revision history for this message
Adam Zammit (adamzammit) said :
#1

Hi Alex,

Thank you so much for your contribution to the updated admin panel. It really looks great. I have checked out the latest version and given it a test run.

Some pages threw some notices although I'm not sure if these were also in the existing code.

The links to dashboard.php and settings.php were broken - I'm not sure if this was intentional (i.e. not developed yet or not able to share).

Some suggestions - the company name and admin panel name could be set using the browser in a similar way to "Set centre information" - using the get_setting and set_setting functions. This would avoid the need to edit the config.inc.local.php file (which I am trying to move away from where possible).

I had a quick look at the licensing of the included files and it all appears to be MIT licensed which is great (compatible with GPL). Please let me know if you notice the licensing being different than MIT/GPL for other included files.

I think this is an excellent improvement to the system and I am looking forward to porting the changes to the mainline code. Thank you again for all your hard work and for sharing with the queXS community.

Adam

Revision history for this message
Alex (ddrmoscow) said :
#2

Hi Adam,

Thank you,

Yep, dashboard.php and settings.php as well as logout.php are not
there yet... (Shown just to remind me to finish...) But all
suggestions and ideas are always welcome :-))
Thought to link settings to "Operator edit" page, but that's too
primitive , still not shure what to have in settings.php except pass
/ jabber / e-mail profile.
For Logout - waiting your "authentication solution" that you started
with Gerry Gilmore - could be linked there

 There're too many things to display in Dashboard, need to filter most
important, as the page is not that big
So far main widget candidates are : running questionnaires list (with
samples sublist & statistics), online operators voip state
&statistics, short calendar with assigned shifts by
questionnaire/sample, quotas..

Could you specify what notices you received? I've added few popovers
and modals, but most of them are related to "delete" confirmation.
That appeared to be very useful as few " misclicked deletes" occurred
already (lol)

I've planned to add "settings" page (or maybe use centreinfo.php page)
 and move few parameters ( including company name and admin panel
name) from config.inc.local.php to DB.

As you focused few mails before on licensing issue, I filter included
3rd party soft to pass only MIT/GPL .

If agreed with modified/added strings, these changes require
translation string and POT file updates.

Please let me know if everyting works ok on your installation too,

Best regards,
Alex.

Revision history for this message
Launchpad Janitor (janitor) said :
#3

This question was expired because it remained in the 'Open' state without activity for the last 15 days.