recipe with quilt patch doesn't build - Patch debian/link-against-needed-libs.diff does not remove cleanly

Asked by Mantas Kriaučiūnas on 2011-07-18

I have a problem with launchpad recipes - recipe with quilt patch doesn't build , see https://launchpadlibrarian.net/75428258/buildlog.txt.gz
Exact error is:
Patch debian/link-against-needed-libs.diff does not remove cleanly (refresh it or enforce with -f)
make: *** [unpatch] Error 1

Recipe is simple, see https://code.launchpad.net/~baltix/+recipe/irrlicht-svn :
# bzr-builder format 0.3 deb-version {debupstream}{date}-0-{revno:packaging}
lp:~stk/stk/irrlicht
nest-part packaging lp:~baltix/stk/pkg-irrlicht debian debian

This recipe worked fine until I added patch debian/link-against-needed-libs.diff - now this patch is applied without errors during build, but at the end of build I get an error "Patch debian/link-against-needed-libs.diff does not remove cleanly", see https://launchpadlibrarian.net/75428258/buildlog.txt.gz
Committed revision 2204.
Applying quilt patches
Applying patch debian/link-against-needed-libs.diff
patching file source/Irrlicht/Makefile
Now at patch debian/link-against-needed-libs.diff
[...]
 fakeroot debian/rules clean
QUILT_PATCHES=debian/patches quilt --quiltrc /dev/null pop -a -R || test $? = 2
Patch debian/link-against-needed-libs.diff does not remove cleanly (refresh it or enforce with -f)
make: *** [unpatch] Error 1
dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit status 2

I think it's launchpad bug, because this patch works fine on my computer (tested with local bzr-builder)

I've tested on my computer (Ubuntu 10.04) and this patch does apply and unapply without errors:
guest@vitas-linux:~/Desktop/recipe-1.8~svn20110718-0$ QUILT_PATCHES=debian/patches quilt --quiltrc /dev/null push -a
Applying patch debian/link-against-needed-libs.diff
patching file source/Irrlicht/Makefile
Now at patch debian/link-against-needed-libs.diff
guest@vitas-linux:~/Desktop/recipe-1.8~svn20110718-0$ QUILT_PATCHES=debian/patches quilt --quiltrc /dev/null pop -a -R
Removing patch debian/link-against-needed-libs.diff
Restoring source/Irrlicht/Makefile
No patches applied

Question information

Language:
English Edit question
Status:
Answered
For:
Launchpad itself Edit question
Assignee:
No assignee Edit question
Last query:
2011-07-18
Last reply:
2011-07-21

Is your local PC running Lucid when you try it locally?

Ah it is, I just read further down.

re-opening, someone with recipe-fu needs to look.

Mantas Kriaučiūnas (mantas) said : #4

In IRC #launchpad channel jelmer told me:
jelmer: mant: I think Riddell was just looking at answering your question
mant: jelmer: Riddel will write answer at https://answers.launchpad.net/launchpad/+question/165193 ?
jelmer: mant: I think so

But it seems Riddel forgot to write answer here :(

Also wgrant and jelmer told me :
Erm, unpatch?
bzr-builder/3.0 (quilt) do that for you.
 jelmer: mantiena: yeah, unpatch is most likely the culprit

Jonathan Riddell (jr) said : #5

This package is both source format 3.0(quilt) and manually includes quilt in debian/rules. I would remove the quilt in debian/rules and the call to unpatch at the clean: target

Can you help with this problem?

Provide an answer of your own, or ask Mantas Kriaučiūnas for more information if necessary.

To post a message you must log in.