Remove message expiry feature.

Bug #988831 reported by Angelo Locritani
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Undecided
Unassigned

Bug Description

It seems that not all messages are saved in the news "archive".
Indeed, after a while, I can see only last X messages (don't remember exact number).

Not sure if it is by purpose or not...

Related branches

Revision history for this message
wl-zocker (wl-zocker) wrote :

I have also noticed that, but I do not think that that is important. If you check your new messages regularly before deleting them, you will not have problems. Events that are a long time ago are not interesting any more, I think. If your soldiers have occupied a military building, you know that and then, you do not need the message anymore.

So why do you want to read the old news?

Revision history for this message
Angelo Locritani (alocritani) wrote : Re: [Bug 988831] Re: maximum number of messages in news

they give you information about discovered resources (iron, gold, coal,
granite, etc...).
They are useful if you had built no mines at that time and act as a
reminder of the position (although approximated)

Il giorno 26 aprile 2012 14:35, wl-zocker <email address hidden> ha
scritto:

> I have also noticed that, but I do not think that that is important. If
> you check your new messages regularly before deleting them, you will not
> have problems. Events that are a long time ago are not interesting any
> more, I think. If your soldiers have occupied a military building, you
> know that and then, you do not need the message anymore.
>
> So why do you want to read the old news?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/988831
>
> Title:
> maximum number of messages in news
>
> Status in Widelands:
> New
>
> Bug description:
> It seems that not all messages are saved in the news "archive".
> Indeed, after a while, I can see only last X messages (don't remember
> exact number).
>
> Not sure if it is by purpose or not...
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/widelands/+bug/988831/+subscriptions
>

Revision history for this message
wl-zocker (wl-zocker) wrote : Re: maximum number of messages in news

Yes, you are right, I did not think of the ressource signs.

There are lots of discussion about it, see: bug 892312 and http://wl.widelands.org/forum/topic/1014/. We will probably have to wait if the signs will stay forever or whatsoever.

If the messages are not deleted from the archive, there are some questions:
- Will all news or only the ressource news be left? If the latter: Do they need a "Don't delete me"-property?
- How can they be deleted definitely? If your archive grows bigger and bigger, you want to delete old messages (e.g. because the ressource is completely mined). If one currently presses "Del", they will reappear in the post entry.

Do you really take the time to check your old news? Sorry that I ask that stupid but I think sending some geologists there or having a quick look into the editor would be faster. But maybe I will change my behaviour if the messages can be mangaged like suggested ;-)

I set it to confirmed because after having thought about it, it does not sound that bad.

Changed in widelands:
status: New → Confirmed
summary: - maximum number of messages in news
+ maximum number of messages in news archive
Revision history for this message
SirVer (sirver) wrote : Re: maximum number of messages in news archive

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

I have to admit I don't know why older messages disappear from the news archive, so someone else will have to answer that one.

However, if the main problem is looking up where geologists have found resources, I'm slightly tempted to mark this as a duplicate of bug 892312 because solving that would fix this issue. :)

Revision history for this message
SirVer (sirver) wrote :

Messages in the archive should never be lost. We rely on that in several multiplayer scenarios by sending the rules as messages and hope that people can go to the archive to look them up again.

however, I am unable to reproduce this bug.

Changed in widelands:
status: Expired → Incomplete
Revision history for this message
wl-zocker (wl-zocker) wrote :

In r7168, the messages are deleted after one hour from the archive (or your inbox). I have noticed it for "New headquarters", "Donjon occupied" and "Water found". However, the status updates from wood gnome are not deleted. So it seems to depend on the type of the message.

OT: @SirVer: I hope you enjoyed your vacation. Nice to see your back to Widelands.

Changed in widelands:
status: Incomplete → Confirmed
Revision history for this message
SirVer (sirver) wrote :

Ah, now I get it. Messages can have an expiry time. I always thought that would then auto archive them, but apparently they get deleted. I think this feature is not really useful and it is rather opaque too. So I think we should remove it.

OT: Thanks, glad to be back. I did enjoy my vacations, but I am also looking forward to dig through my email pile :).

summary: - maximum number of messages in news archive
+ Remove message expiry feature.
Revision history for this message
GunChleoc (gunchleoc) wrote :

So, this is what the expiry time does! I was wondering at the parameter when I worked on the out of resources messages.

Let's kill them.

Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
milestone: none → build19-rc1
GunChleoc (gunchleoc)
Changed in widelands:
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.