I noticed that the list of "Categories" (tags) shown in the 2nd column doesn't behave as expected after a blog post is edited after it's been published. This question isn't about that behavior, but it is about 2 lines of code that I noticed while trying to figure out that issue. What is supposed to happen in the two lines of code isn't clear to me. The two lines below look like the use the same logic, but I think they're supposed to be different. I might not understand what's happening at this point. Thanks again!
http://bazaar.launchpad.net/~jgoguen/gablog/trunk/view/head:/handlers/functions.py#L485
http://bazaar.launchpad.net/~jgoguen/gablog/trunk/view/head:/handlers/functions.py#L486
484
if not property_hash["draft"]:
485
before_tags = set(article.tag_keys)
486
after_tags = set(article.tag_keys)
487
for removed_tag in before_tags - after_tags:
=====
Hi, I added a related question just a few minutes ago about two other lines of code in functions.py. I think I found the line of code that might be the spot that is causing some unexpected behavior for tags on article/blog post edits.
http://bazaar.launchpad.net/~jgoguen/gablog/trunk/view/head:/handlers/functions.py#L472
If "and article.draft" is removed/commented out, the tag counts are updated as expected. I'm not sure why property_hash would not include draft but the article would be a draft. Thanks for the help!
472
if not property_hash["draft"] and article.draft:
473
for key in property_hash["tag_keys"]:
474
db.get(key).counter.increment()
475
if CONFIG['send_microblog_update'] and article.article_type == "blog post":
476
try:
477
do_status_updates(article)
478
except Exception, de:
479
logging.error("Download error: %s", de.message)
Hi Roberto,
Thank you for reporting this issue. The intention here was to avoid counting tags twice (if you submitted a post as a draft, then edited it and saved it as published) but I believe I see that you are correct. I will investigate this further in trunk.