Launchpad itself

LocationError openid_identity_url on Person +index

Bug #635430 reported by Curtis Hovey
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Stuart Bishop
Launchpad itself 10.11 "Tenacious Turkey"

Bug Description

OOPS-1714M1562 and OOPS-1714G435 happened for two different users. The pages load fine, but the oopses show view/openid_identity_url failed. PersonIndexView does provide the openid_identity_url property as does PersonView (the base class).

/me wonders why we have two very different implementation of the properties? Since TeamIndex view descends from PersonIndexView, The one on PersonView may not every be used.

Related branches

lp:~stub/launchpad/bug-635430-openid_identity_url
Robert Collins (community): Approve
Diff: 63 lines (+23/-18)
2 files modified
lib/lp/registry/templates/person-index.pt (+19/-17)
lib/lp/services/openid/adapters/openid.py (+4/-1)
Revision history for this message
William Grant (wgrant) wrote :

This is occurring when a person's account's last OpenIDIdentifier is reassigned to another account, leaving them with none. This can happen now, so it needs to be handled.

Gary Poster (gary)
Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → Medium
Gary Poster (gary)
Changed in launchpad-foundations:
importance: Medium → High
Revision history for this message
Gary Poster (gary) wrote :

See the related question for a possible clue on how this might happen (resetting a password in SSO)

Revision history for this message
William Grant (wgrant) wrote :

The primary cause is bug #637968.

Revision history for this message
Stuart Bishop (stub) wrote :

We believe Person.openid_identity_url is raising some sort of exception when the Person has no linked identities, rather than returning None as it should.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11916 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11916>.

Changed in launchpad-foundations:
assignee: nobody → Stuart Bishop (stub)
milestone: none → 10.11
tags: added: qa-needstesting
Changed in launchpad-foundations:
status: Triaged → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote :

I do not think the fix is testable? The view that uses it is only available in production.

Revision history for this message
Robert Collins (lifeless) wrote :

Then we have to suck it and see.

tags: added: qa-untestable
removed: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

qastaging has OpenID delegation tags -- isn't that all we need?

Robert Collins (lifeless)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.