eclipse-plugin-cvs should not depend on cvs

Hi

Looking at eclipse/plugins/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/client/Command.java (in the source package) heavily suggests that it indeed uses the command-line CVS. Particularly have a look at the method:

private String constructCommandInvocationString(IPath commandRootPath, GlobalOption[] globalOptions, LocalOption[] localOptions, String[] arguments);

~Niels

I don't think so.
http://www.eclipse.org/eclipse/platform-cvs/ says clearly:
"Because the CVS plug-in includes a pure java client, the support works without requiring a command line client install on the users machine. "
I have read eclipse/plugins/org.eclipse.team.cvs.core/src/org/eclipse/team/internal/ccvs/core/client/Command.java, seems it does not call a the command line cvs client, but implement the client function in pure java in other source files (Session.java ...).

I did a test just now, i move cvs command client out of my $PATH, then I do make a new eclipse CVS project to checkout a cvs repo, the checkout process finished successfully.

Hi

I have fixed this the VCS and it will be fixed on the next upload.

Thanks for pointing out the Session file and testing on top of that.

~Niels

This bug was fixed in the package eclipse - 3.5.2-4

---------------
eclipse (3.5.2-4) unstable; urgency=low

  [ Niels Thykier ]
  * Added menu entry for the Debian menu.
  * Moved a lot of arch-indep plugins into eclipse-platform-data.
  * Backported fix for poor tooltip colors with certain themes.
    (Closes: #582302, LP: #540332)
  * Backported fix for hover text visability problem.
  * Corrected a format issue in debian/copyright.
  * Removed depends on cvs for eclipse-plugin-cvs, it is not needed.
    (LP: #592508)
  * Removed Depends on JRE for libequinox-osgi-java.
  * Added patch to use sat4j 2.2 instead of 2.1 (Closes: #586978)
  * Added recommends on eclipse-pde for eclipse-platform.
    (LP: #593260)
  * Added patch to install the o.e.equinox.concurrent plugin in
    eclipse-platform (Closes: #585178)
  * Bumped (Build-)Depends on libhamcrest-java to 1.1-8 to avoid
    being affected by a regression in libhamcrest-java 1.1-7.

  [ Adnan Hodzic ]
  * Added debian/patches/fix-bashism.patch (Closes: #581099)

  [ Yulia Novozhilova ]
  * Added the Maven POMs for libequinox-osgi.java (LP: #598039)
  * Added a Build-Depends dependency on maven-repo-helper and maven-ant-helper
  * Added missing recommends on libservlet2.5-java for libequinox-osgi-java.

  [ Benjamin Drung ]
  * Bump Standards-Version to 3.9.0 (no changes required).
 -- Benjamin Drung <email address hidden> Mon, 28 Jun 2010 22:25:42 +0200