bcmwl: properly support linux 6.1

Bug #1999009 reported by Andrea Righi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bcmwl (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned
Kinetic
Fix Released
Undecided
Unassigned
Lunar
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

bcmwl-kernel-source fails to build with the latest linux 6.1 in Lunar.

Moreover, with kernels >= 5.17 there's an incorrect access to struct netdev (see LP: #1998039).

[Test case]

$ sudo apt install bcmwl-kernel-source

[Fix]

The following upstream commits have change the cfg80211 ABI in linux >= 6.1:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=efbabc11650040c64884ff3019b88c7bcc0ceb1d
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e7a7b84e33178db4a839c5e1773247be17597c1f

Change bcmwl to properly support the new ABI changes.

Moreover, to fix the incorrect netdev access with kernels >= 5.17 we can apply this patch https://raw.githubusercontent.com/archlinux/svntogit-community/master/broadcom-wl-dkms/trunk/012-linux517.patch (see LP: #1998039 - thanks to Brett Holman for the backport and for reporting the problem).

[Regression potential]

We may experience regressions with kernels >= 6.1 using the bcmwl-kernel-source dkms. The code for the previous kernels remains unchanged.

Andrea Righi (arighi)
no longer affects: bcmwl (Ubuntu Jammy)
Revision history for this message
Andrea Righi (arighi) wrote :

Debdiff in attach fixes the build problems with linux 6.1 and it should also fix LP: #1998039 (once confirmed/tested we can set 1998039 as duplicate of this one).

tags: added: patch
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Uploaded to unapproved queue of jammy and kinetic, proposed of lunar.

Changed in bcmwl (Ubuntu Lunar):
status: New → Fix Committed
Changed in bcmwl (Ubuntu Kinetic):
status: New → In Progress
Changed in bcmwl (Ubuntu Jammy):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.30.223.271+bdcom-0ubuntu10

---------------
bcmwl (6.30.223.271+bdcom-0ubuntu10) lunar; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0041-dev-addr-access.patch (LP: #1998039):
    - Fix netdev->dev_addr access with kernels >= 5.17.
  * debian/dkms.conf.in,
    debian/patches/0042-add-support-for-linux-6.x.patch (LP: #1999009):
    - Support linux >= 6.1

 -- Andrea Righi <email address hidden> Wed, 07 Dec 2022 06:38:54 +0000

Changed in bcmwl (Ubuntu Lunar):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted bcmwl into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/bcmwl/6.30.223.271+bdcom-0ubuntu10~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in bcmwl (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Andrea, or anyone else affected,

Accepted bcmwl into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/bcmwl/6.30.223.271+bdcom-0ubuntu10~22.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in bcmwl (Ubuntu Kinetic):
status: In Progress → Fix Committed
tags: added: verification-needed-kinetic
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Verified on Jammy.

HWE 5.19 kernel:

=============================================
Setting up bcmwl-kernel-source (6.30.223.271+bdcom-0ubuntu10~22.04.1) ...
Loading new bcmwl-6.30.223.271+bdcom DKMS files...
Building for 5.19.0-32-generic
Building for architecture x86_64
Building initial module for 5.19.0-32-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

wl.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.19.0-32-generic/updates/dkms/
=============================================

Generic 5.15 kernel:

=============================================
$ sudo dkms install bcmwl/6.30.223.271+bdcom -k 5.15.0-60-generic
[...]
Building module:
cleaning build area...
make -j4 KERNELRELEASE=5.15.0-60-generic -C /lib/modules/5.15.0-60-generic/build M=/var/lib/dkms/bcmwl/6.30.223.271+bdcom/build...
Signing module:
 - /var/lib/dkms/bcmwl/6.30.223.271+bdcom/5.15.0-60-generic/x86_64/module/wl.ko
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
cleaning build area...

wl.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.15.0-60-generic/updates/dkms/
=============================================

tags: added: verification-done-jammy
removed: verification-needed-jammy
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

Verified on Kinetic:

=============================================
Setting up bcmwl-kernel-source (6.30.223.271+bdcom-0ubuntu10~22.10.1) ...
Loading new bcmwl-6.30.223.271+bdcom DKMS files...
Building for 5.19.0-31-generic
Building for architecture x86_64
Building initial module for 5.19.0-31-generic
Can't load /var/lib/shim-signed/mok/.rnd into RNG
40C76788AA7F0000:error:12000079:random number generator:RAND_load_file:Cannot open file:../crypto/rand
/randfile.c:106:Filename=/var/lib/shim-signed/mok/.rnd
.....+..+.+.....................+...+...+...+..+...+......++++++++++++++++++++++++++++++++++++++++++++
+++++++++++++++++++++*.+...+..................++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+++++++++*....+...+..............+.+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
.......+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*............+.............+..
.......+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++*..........+...+....+........+
......+.+...+...+...+......+......+..............+.........+......+......+.........+.+.....+..........
.....+....+.........+......+.....................+........+.+...+............+.....+.........+......+.
+.....+.........+....+..+...+.......+...+.....+.+...+....................+.......+...+..+.........+...
.+........+...+.......+..+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-----
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

wl.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.19.0-31-generic/updates/dkms/
depmod.....

=============================================

tags: added: verification-done-kinetic
removed: verification-needed-kinetic
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.30.223.271+bdcom-0ubuntu10~22.10.1

---------------
bcmwl (6.30.223.271+bdcom-0ubuntu10~22.10.1) kinetic; urgency=medium

  * Backport dkms support for HWE kernels.

bcmwl (6.30.223.271+bdcom-0ubuntu10) lunar; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0041-dev-addr-access.patch (LP: #1998039):
    - Fix netdev->dev_addr access with kernels >= 5.17.
  * debian/dkms.conf.in,
    debian/patches/0042-add-support-for-linux-6.x.patch (LP: #1999009):
    - Support linux >= 6.1

 -- Dimitri John Ledkov <email address hidden> Mon, 16 Jan 2023 11:12:48 +0000

Changed in bcmwl (Ubuntu Kinetic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for bcmwl has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package bcmwl - 6.30.223.271+bdcom-0ubuntu10~22.04.1

---------------
bcmwl (6.30.223.271+bdcom-0ubuntu10~22.04.1) jammy; urgency=medium

  * Backport dkms support for HWE kernels.

bcmwl (6.30.223.271+bdcom-0ubuntu10) lunar; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0041-dev-addr-access.patch (LP: #1998039):
    - Fix netdev->dev_addr access with kernels >= 5.17.
  * debian/dkms.conf.in,
    debian/patches/0042-add-support-for-linux-6.x.patch (LP: #1999009):
    - Support linux >= 6.1

bcmwl (6.30.223.271+bdcom-0ubuntu9) kinetic; urgency=medium

  * debian/dkms.conf.in,
    debian/patches/0040-add-support-for-linux-5.18.patch (LP: #1981968):
    - Add support for Linux 5.18.

 -- Dimitri John Ledkov <email address hidden> Mon, 16 Jan 2023 11:12:48 +0000

Changed in bcmwl (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.