[Ubuntu 22.04] s390-tools: subpackage chreipl-fcp-mpath installs files into wrong location and subsequently doesn't work

Default Comment by Bridge

Default Comment by Bridge

Hi Benjamin; there is a plan for doing a larger s390-tools update for jammy (incl. more z16 enablements), and this should be incl. as well.
For now I created a PPA test build (that addresses LP#1971993 only) which is available here: https://launchpad.net/~fheimes/+archive/ubuntu/lp1971993/+packages
It has the same version string than the current s390-tools in the archive.
I think this is most convenient, since one also needs to have the s390-tools-signed version installed in the same version - but a bit caution is needed so that really the version from the PPA is installed.
So simplest is to just wget chreipl-fcp-mpath from the PPA and install it with 'apt install ./s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu4_s390x.deb'.

Regarding the changes:
- fixed a c&p error and moved the helper files to from /lib/udev/rules.d to /lib/udev
- removed lvm2 as dependency, since a default install is nowadays with lvm,
  but one can of course overrule it (but wouldn't have hurt)
- chreipl-fcp-mpath-common.sh doesn't get 755 assigned anymore, since only the input script '.in'
  has a she-bang, but not the '.sh'. (If the sh would have it too, lintian would complain).
- I choose to bundle the pre-generated man page
- the chreipl-fcp-mpath-common README got bundled (unfortunately the various READMEs are largely in different places)
- I think there is nothing special needed for the udev rule (I guess dh_installudev does that with a hock). I tried w/o 'udevadm control --reload' and it seemed to work (see attachment).
(Might be worth to add such an example as test to the readme?)
- I had another look at the dependencies, there were okay, but I made them a bit more explicit.

Would be great if you can have a quick look, so that it can be part of the larger update (in case things are fine).

------- Comment From <email address hidden> 2022-05-25 14:45 EDT-------
Hey Frank,

(In reply to comment #12)
> Hi Benjamin; there is a plan for doing a larger s390-tools update for jammy
> (incl. more z16 enablements), and this should be incl. as well.

sounds good.

> For now I created a PPA test build (that addresses LP#1971993 only) which is
> available here:
> https://launchpad.net/~fheimes/+archive/ubuntu/lp1971993/+packages
> It has the same version string than the current s390-tools in the archive.
> I think this is most convenient, since one also needs to have the
> s390-tools-signed version installed in the same version - but a bit caution
> is needed so that really the version from the PPA is installed.
> So simplest is to just wget chreipl-fcp-mpath from the PPA and install it
> with 'apt install ./s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu4_s390x.deb'.

hmm, I didn't find any 'upstream' `s390-tools_2.20.0-0ubuntu4`, maybe I was looking wrong; hence I've been missing `s390-tools-signed_2.20.0-0ubuntu4`, and the tooling kept complaining about that. For now I just forced installation with `dpkg` for testing (this won't be a problem in practice anyway).

> Regarding the changes:
> - fixed a c&p error and moved the helper files to from /lib/udev/rules.d to /lib/udev

Yes, looks good now.

~ # dpkg-deb --contents ./s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu4_s390x.deb
drwxr-xr-x root/root 0 2022-05-20 11:48 ./
drwxr-xr-x root/root 0 2022-05-20 11:48 ./lib/
drwxr-xr-x root/root 0 2022-05-20 11:48 ./lib/udev/
-rwxr-xr-x root/root 1719 2022-05-20 11:48 ./lib/udev/chreipl-fcp-mpath-is-ipl-tgt
-rwxr-xr-x root/root 2572 2022-05-20 11:48 ./lib/udev/chreipl-fcp-mpath-is-ipl-vol
-rwxr-xr-x root/root 735 2022-05-20 11:48 ./lib/udev/chreipl-fcp-mpath-is-reipl-zfcp
-rwxr-xr-x root/root 2052 2022-05-20 11:48 ./lib/udev/chreipl-fcp-mpath-record-volume-identifier
-rwxr-xr-x root/root 5633 2022-05-20 11:48 ./lib/udev/chreipl-fcp-mpath-try-change-ipl-path
drwxr-xr-x root/root 0 2022-05-20 11:48 ./lib/udev/rules.d/
-rw-r--r-- root/root 4237 2022-02-04 11:34 ./lib/udev/rules.d/70-chreipl-fcp-mpath.rules
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/lib/
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/lib/chreipl-fcp-mpath/
-rw-r--r-- root/root 13850 2022-05-20 11:48 ./usr/lib/chreipl-fcp-mpath/chreipl-fcp-mpath-common.sh
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/share/
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/share/doc/
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/share/doc/s390-tools-chreipl-fcp-mpath/
-rw-r--r-- root/root 3744 2022-05-20 11:48 ./usr/share/doc/s390-tools-chreipl-fcp-mpath/README.md.gz
-rw-r--r-- root/root 12526 2022-05-20 11:48 ./usr/share/doc/s390-tools-chreipl-fcp-mpath/changelog.Debian.gz
-rw-r--r-- root/root 1450 2022-01-31 11:54 ./usr/share/doc/s390-tools-chreipl-fcp-mpath/copyright
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/share/man/
drwxr-xr-x root/root 0 2022-05-20 11:48 ./usr/share/man/man7/
-rw-r--r-- root/root 2303 2022-05-...

Hi Benjamin, first of all thx for testing and your thoughts.

First of all sorry, I usually have to increment the package version, but wanted to avoid it this time (due to s390-tools-signed), but the usual habit hit me - anyway you found a way to get it installed ...

I was also wondering about the dependencies, esp. udev, since there are already udev rules that are shipped by s390-tools, but no udev dependencies specified.
So I had some discussions if there are any best practices or so, but there does not seem to be a strict rule for such a case (of a very foundational) package, since it's expected to be always there, and even part of all server seeds (incl. server-minimal) - so it looks like kind of 'optional'.
But after all I decided to add it, just to be more explicit (now also for the other packages).

Hah, since s390-tools v2.2.0 came very late and close to the feature-freeze, the 'version bump' was prepped based on a v2.19+, which obviously haven't had your c2f8988444d0ed8274256c1990bb7f8866c265e2 included - and later on I haven't noticed it.
So that it explains it.

It's a good point to use s390-tools.docs instead of putting it into .install - looks 'tastier' (even if the result is the same, yes).

And finally thanks for double checking the functionality and running the regression test suite!

(Now just waiting for a fix for LP#1974109 and get that plus lp1971993, lp1960119, lp1959548, lp1971959 into one update...)

First of all sorry, I usually have to increment the package version, but wanted to avoid it this time (due to s390-tools-signed), but the usual habit hit me - anyway you found a way to get it installed (by forcing it).

------- Comment From <email address hidden> 2022-06-01 12:01 EDT-------
(In reply to comment #15)
> Hi Benjamin, first of all thx for testing and your thoughts.
>
> First of all sorry, I usually have to increment the package version, but
> wanted to avoid it this time (due to s390-tools-signed), but the usual habit
> hit me - anyway you found a way to get it installed (by forcing it).
>
> I was also wondering about the dependencies, esp. udev, since there are
> already udev rules that are shipped by s390-tools, but no udev dependencies
> specified.
> So I had some discussions if there are any best practices or so, but there
> does not seem to be a strict rule for such a case (of a very foundational)
> package, since it's expected to be always there, and even part of all server
> seeds (incl. server-minimal) - so it looks like kind of 'optional'.
> But after all I decided to add it, just to be more explicit (now also for
> the other packages).
>
> Hah, since s390-tools v2.2.0 came very late and close to the feature-freeze,
> the 'version bump' was prepped based on a v2.19+, which obviously haven't
> had your c2f8988444d0ed8274256c1990bb7f8866c265e2 included - and later on I
> haven't noticed it.
> So that it explains it.
>
> It's a good point to use s390-tools.docs instead of putting it into .install
> - looks 'tastier' (even if the result is the same, yes).
>
> And finally thanks for double checking the functionality and running the
> regression test suite!
>
> (Now just waiting for a fix for LP#1974109 and get that plus lp1971993,
> lp1960119, lp1959548, lp1971959 into one update...)

Maybe you just forgot to write, but did you see the point that both packages `s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu4_s390x.deb` and `s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu4_s390x.deb` seem to contain the manpage `/usr/share/man/man7/chreipl-fcp-mpath.7.gz`?

For me this caused the installation of `s390-tools-chreipl-fcp-mpath` to abort, unless I forced it via `dpkg`:

...
dpkg: error processing archive ./s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu4_s390x.deb (--install):
trying to overwrite '/usr/share/man/man7/chreipl-fcp-mpath.7.gz', which is also in package s390-tools 2.20.0-0ubuntu4
...

That was the only thing that didn't work for me in my tests last week.

Hi Benjamin, that is already fixed (but thanks for mentioning this).

The PPA was updated several days ago - now with proper (and ready to upload) packages (with proper version numbers: 2.20.0-0ubuntu3.1 for jammy and 2.20.0-0ubuntu4 for kinetic) and with s390-tools-signed packages:
https://launchpad.net/~fheimes/+archive/ubuntu/lp1971993
(but don't expect secure boot to work out of the box with these, since they are not signed with the regular production key, rather than with a PPA test/dev key - they are just there to fulfill the dependencies.)

So someone who has jammy with 2.20.0-0ubuntu3 installed can get it updated with the versions from the PPA to 2.20.0-0ubuntu3.1 (since you forced 2.20.0-0ubuntu4 when you did the early test, you would need to 'sudo apt remove --purge' all s390-tools packages first and install them from the PPA.

Installation as well as update of s390-tools and s390-tools-s390-tools-chreipl-fcp-mpath (co-installed) works fine, w/o any clashes.

------- Comment From <email address hidden> 2022-06-01 14:40 EDT-------
Ah, nice, thanks. Just wanted to make sure, it didn't get lost.

The attachment "debdiff_kinetic_2.20.0-0ubuntu3_to_2.20.0-0ubuntu4.patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

The fix for this bug has been uploaded to Kinetic and the SRU queue for Jammy.

This bug was fixed in the package s390-tools - 2.20.0-0ubuntu4

---------------
s390-tools (2.20.0-0ubuntu4) kinetic; urgency=medium

  * Fix chreipl-fcp-mpath (LP: #1971993)
    - Move chreipl-fcp-mpath* from /lib/udev/rules.d to /lib/udev.
    - d/control:
      + Build-Depend on bsdextrautils for hexdump
      + Add multiple explicit Depends on udev
      + s390-tools-chreipl-fcp-mpath: drop unnecessary Depends on lvm2
    - No longer change attributes of chreipl-fcp-mpath-common.sh to 755,
      since only the input script '.in' has a she-bang, but not the '.sh'
      anymore (was done with commit c2f8988).
    - Add d/p/0d15a07-chreipl-fcp-mpath-bundle-a-pre-cooked-man-page.patch
      to bundle a pre-cooked version of the man page for chreipl-fcp-mpath
      Required minor context adjustment for CHANGELOG.md hunk
      and changes in d/rules.
    - Add missing README.md to s390-tools-chreipl-fcp-mpath.doc
      (and with that also the README.md for genprotimg to s390-tools.docs).
  * Add new CPU-MF Counters for new IBM Z hardware (LP: #1960119) by:
    - d/p/2515832-util_arch-Add-IBM-z16-as-known-machine.patch and
    - d/p/cce5f51-cpumf-lscpumf-Add-IBM-z16-extended-counter-set-def.patch
  * Add exploitation support of new IBM Z crypto hardware (LP: #1959548) with:
    - d/p/b16a6d4f-lszcrypt-add-CEX8S-support.patch
    - d/p/bcbb6fca-zcryptstats-add-CEX8-support.patch
    - d/p/4382901d-lszcrypt-show-AP-bus-msg-size-limit-capability.patch
    - d/p/27dce331-lszcrypt-add-support-for-checkstop-state.patch
    - d/p/a29b3c89-lszcrypt-new-options-to-show-only-accel-cca-or-ep11-.patch
    - d/p/a8b0d7ac-lszcrypt-new-options-to-filter-cards-queues-only.patch
    - d/p/46fd42af-lszcrypt-new-option-to-show-the-serial-numbers-of-CC.patch
  * Stabilization of data collection in dbginfo.sh script (LP: #1971959)
    by adding several upstream patches:
    - d/p/*-dbginfo.sh-*.patch
    - whereas one needed minor context adjutment for the CHANGELOG.md hunk:
      d/p/50a4740-dbginfo.sh-replace-which-by-builtin-command-type-for.patch
  * Fix cmsfs-fuse mount failure due to unknown option '-o hard_remove'
    (LP: #1978323) with:
    d/p/0981df6-cmsfs-fuse-fix-enabling-of-hard_remove-option.patch

 -- Frank Heimes <email address hidden> Fri, 20 May 2022 13:48:34 +0200

Hello bugproxy, or anyone else affected,

Accepted s390-tools into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/s390-tools/2.20.0-0ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

------- Comment From <email address hidden> 2022-06-29 12:12 EDT-------
I downloaded the packages from:
https://launchpad.net/ubuntu/+source/s390-tools/2.20.0-0ubuntu3.1/+build/24106366 "s390x build of s390-tools 2.20.0-0ubuntu3.1"
https://launchpad.net/ubuntu/+source/s390-tools-signed/2.20.0-0ubuntu3.1/+build/24106373 "s390x build of s390-tools-signed 2.20.0-0ubuntu3.1"

Version: s390-tools and s390-tools-signed 2.20.0-0ubuntu3.1

My system:

~ # uname -a
Linux t3545003 5.15.0-40-generic #43-Ubuntu SMP Wed Jun 15 12:53:53 UTC 2022 s390x s390x s390x GNU/Linu

~ # cat /etc/os-release
PRETTY_NAME="Ubuntu 22.04 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Check whether installation works as expected and installs the correct files in the correct locations:

~ # apt install ./s390-tools-signed_2.20.0-0ubuntu3.1_s390x.deb ./s390-tools_2.20.0-0ubuntu3.1_s390x.deb ./s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu3.1_s390x.deb
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
Note, selecting 's390-tools-signed' instead of './s390-tools-signed_2.20.0-0ubuntu3.1_s390x.deb'
Note, selecting 's390-tools' instead of './s390-tools_2.20.0-0ubuntu3.1_s390x.deb'
Note, selecting 's390-tools-chreipl-fcp-mpath' instead of './s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu3.1_s390x.deb'
Suggested packages:
s390-tools-cpuplugd s390-tools-osasnmpd s390-tools-statd lsscsi blktrace
The following NEW packages will be installed:
s390-tools-chreipl-fcp-mpath
The following packages will be upgraded:
s390-tools s390-tools-signed
2 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/1,558 kB of archives.
After this operation, 108 kB of additional disk space will be used.
Get:1 /root/tmp/s390-tools_2.20.0-0ubuntu3.1/s390-tools_2.20.0-0ubuntu3.1_s390x.deb s390-tools s390x 2.20.0-0ubuntu3.1 [1,531 kB]
Get:2 /root/tmp/s390-tools_2.20.0-0ubuntu3.1/s390-tools-signed_2.20.0-0ubuntu3.1_s390x.deb s390-tools-signed s390x 2.20.0-0ubuntu3.1 [7,610 B]
Get:3 /root/tmp/s390-tools_2.20.0-0ubuntu3.1/s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu3.1_s390x.deb s390-tools-chreipl-fcp-mpath s390x 2.20.0-0ubuntu3.1 [19.2 kB]
(Reading database ... 96627 files and directories currently installed.)
Preparing to unpack .../s390-tools_2.20.0-0ubuntu3.1_s390x.deb ...
Unpacking s390-tools (2.20.0-0ubuntu3.1) over (2.20.0-0ubuntu3) ...
Preparing to unpack .../s390-tools-signed_2.20.0-0ubuntu3.1_s390x.deb ...
Unpacking s390-tools-signed (2.20.0-0ubuntu3.1) over (2.20.0-0ubuntu3) ...
Selecting previously unselected package s390-tools-chreipl-fcp-mpath.
Preparing to unpack .../s390-tools-chreipl-fcp-mpath_2.20.0-0ubuntu3.1_s390x.deb ...
Unpacking s390-tools-chreipl-fcp-mpath (2.20.0-0ubuntu3.1) ...
Setting up s390-tools-signed (2.20.0-0ubuntu3.1) ...
Setting up s390-tools-chreipl-fcp-mpath (2.20.0-0ubuntu3.1) ...
Setting up s390-tools (2.20.0-0ub...

Many thx Benjamin for the verification.
(I'm adjusting the tags accordingly ...)

This bug was fixed in the package s390-tools - 2.20.0-0ubuntu3.1

---------------
s390-tools (2.20.0-0ubuntu3.1) jammy; urgency=medium

  * Fix chreipl-fcp-mpath (LP: #1971993)
    - Move chreipl-fcp-mpath* from /lib/udev/rules.d to /lib/udev.
    - d/control:
      + Build-Depend on bsdextrautils for hexdump
      + Add multiple explicit Depends on udev
      + s390-tools-chreipl-fcp-mpath: drop unnecessary Depends on lvm2
    - No longer change attributes of chreipl-fcp-mpath-common.sh to 755,
      since only the input script '.in' has a she-bang, but not the '.sh'
      anymore (was done with commit c2f8988).
    - Add d/p/0d15a07-chreipl-fcp-mpath-bundle-a-pre-cooked-man-page.patch
      to bundle a pre-cooked version of the man page for chreipl-fcp-mpath
      Required minor context adjustment for CHANGELOG.md hunk
      and changes in d/rules.
    - Add missing README.md to s390-tools-chreipl-fcp-mpath.doc
      (and with that also the README.md for genprotimg to s390-tools.docs).
  * Add new CPU-MF Counters for new IBM Z hardware (LP: #1960119) by:
    - d/p/2515832-util_arch-Add-IBM-z16-as-known-machine.patch and
    - d/p/cce5f51-cpumf-lscpumf-Add-IBM-z16-extended-counter-set-def.patch
  * Add exploitation support of new IBM Z crypto hardware (LP: #1959548) with:
    - d/p/b16a6d4f-lszcrypt-add-CEX8S-support.patch
    - d/p/bcbb6fca-zcryptstats-add-CEX8-support.patch
    - d/p/4382901d-lszcrypt-show-AP-bus-msg-size-limit-capability.patch
    - d/p/27dce331-lszcrypt-add-support-for-checkstop-state.patch
    - d/p/a29b3c89-lszcrypt-new-options-to-show-only-accel-cca-or-ep11-.patch
    - d/p/a8b0d7ac-lszcrypt-new-options-to-filter-cards-queues-only.patch
    - d/p/46fd42af-lszcrypt-new-option-to-show-the-serial-numbers-of-CC.patch
  * Stabilization of data collection in dbginfo.sh script (LP: #1971959)
    by adding several upstream patches:
    - d/p/*-dbginfo.sh-*.patch
    - whereas one needed minor context adjutment for the CHANGELOG.md hunk:
      d/p/50a4740-dbginfo.sh-replace-which-by-builtin-command-type-for.patch
  * Fix cmsfs-fuse mount failure due to unknown option '-o hard_remove'
    (LP: #1978323) with:
    d/p/0981df6-cmsfs-fuse-fix-enabling-of-hard_remove-option.patch

 -- Frank Heimes <email address hidden> Fri, 20 May 2022 13:48:34 +0200

The verification of the Stable Release Update for s390-tools has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

------- Comment From <email address hidden> 2022-07-06 19:40 EDT-------
Fix verified and released to -updates, therefore we can close this bug.
Thanks everybody for your work.

Changing status to: CLOSED