Ubuntu
gtk4 package

save file dialog doesn't allow saving to a directory without files

Bug #1969622 reported by Jeremy Bícha
44
This bug affects 7 people
Affects Status Importance Assigned to Milestone
GTK+
Fix Released
Unknown
gtk4 (Ubuntu)
Fix Released
High
Jeremy Bícha
Jammy
Fix Released
High
Jeremy Bícha

Bug Description

Impact
------
Ubuntu uses xdg-desktop-portal-gnome for the save dialog for snaps (like Firefox or Chromium). xdg-desktop-portal-gnome in Ubuntu 22.04 uses gtk4
This issue also affects gnome-text-editor which uses gtk4 directly.

Attempting to save a file to an empty folder won't work in many cases because the Save button is insensitive (unable to be clicked).

Test Case
---------
View this page with the Firefox or Chromium snaps.
Press Ctrl+S to try to save this page.
Navigate to a folder without any files in it. (It can have other folders in it.)
The Save button should stay lit up.
Save the file.

Note that I wasn't able to reproduce the bug for bookmarked folders in the left sidebar so just navigate using the main view area.

What Could Go Wrong
--------------------
This is a one-line bug fix from the stable gtk-4-6 branch targeted to directly fix this issue.

Other Notes
-----------
I do not believe we need to respin the Ubuntu 22.04 ISOs for this issue.
I do request a 0-day SRU since this is a small high impact fix that affects the usability of the Firefox snap.

See original description
Jeremy Bícha (jbicha)
summary: - save file dialog doesn't allow saving to empty directory
+ save file dialog doesn't allow saving to a directory without files
description: updated
Changed in gtk4 (Ubuntu):
assignee: nobody → Jeremy Bicha (jbicha)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jeremy, or anyone else affected,

Accepted gtk4 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gtk4/4.6.2+ds-1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gtk4 (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
João Pedro Seara (jpseara) wrote :

Hello folks. Facing this issue as well, thank you very much for jumping on it so quickly.

The workaround I found is to, instead of navigating to the inside of the folder, just navigate to one level above, then click on the directory, click on Save (this will make you enter the directory), and then click on Save again.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I installed gtk4 4.6.2+ds-1ubuntu3 and I completed the Test Case successfully with both the Firefox and Chromium snaps.

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk4 - 4.6.2+ds-1ubuntu3

---------------
gtk4 (4.6.2+ds-1ubuntu3) jammy; urgency=medium

  * Cherry-pick filechooser-Small-fix-for-save-mode.patch:
    Fix saving files to a folder that doesn't have any files in it
    (LP: #1969622)

 -- Jeremy Bicha <email address hidden> Wed, 20 Apr 2022 09:37:57 -0400

Changed in gtk4 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gtk4 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
benste (benste) wrote :

I'm still experiencing issues related to my original bug which was marked as duplicate of this bug.
Even though i can now save files once i open a directory i can not save directly into a directory in case the file does not exist yet. I always need to go one dir up and open the same directory again - tested with all updated with a Firefox download.

Bug Watch Updater (bug-watch-updater)
Changed in gtk:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.