Ubuntu
libvpx package

libvpx FTBFS with LTO enabled

Bug #1939640 reported by Sergio Durigan Junior
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libvpx (Ubuntu)
Fix Released
Undecided
Sergio Durigan Junior
lto-disabled-list (Ubuntu)
Fix Released
Undecided
Sergio Durigan Junior

Bug Description

libvpx FTBFS with LTO enabled on GCC 11, as can be seen here:

https://people.canonical.com/~doko/ftbfs-report/test-rebuild-20210805-impish-impish.html#ubuntu-server

https://launchpadlibrarian.net/552670245/buildlog_ubuntu-impish-amd64.libvpx_1.9.0-1_BUILDING.txt.gz

g++ -Wl,-Bsymbolic-functions -flto=auto -Wl,-z,relro -Wl,-z,now -m64 -o test_libvpx ivfenc.c.o md5_utils.c.o test/active_map_refresh_test.cc.o test/active_map_test.cc.o test/alt_ref_aq_segment_test.cc.o test/altref_test.cc.o test/aq_segment_test.cc.o test/bench.cc.o test/borders_test.cc.o test/byte_alignment_test.cc.o test/config_test.cc.o test/cpu_speed_test.cc.o test/cq_test.cc.o test/decode_api_test.cc.o test/decode_corrupted.cc.o test/decode_svc_test.cc.o test/decode_test_driver.cc.o test/encode_api_test.cc.o test/encode_test_driver.cc.o test/error_resilience_test.cc.o test/external_frame_buffer_test.cc.o test/frame_size_tests.cc.o test/invalid_file_test.cc.o test/keyframe_test.cc.o test/level_test.cc.o test/realtime_test.cc.o test/resize_test.cc.o test/svc_datarate_test.cc.o test/svc_end_to_end_test.cc.o test/svc_test.cc.o test/test_libvpx.cc.o test/test_vector_test.cc.o test/test_vectors.cc.o test/timestamp_test.cc.o test/user_priv_test.cc.o test/vp8_datarate_test.cc.o test/vp9_datarate_test.cc.o test/vp9_end_to_end_test.cc.o test/vp9_ethread_test.cc.o test/vp9_lossless_test.cc.o test/vp9_motion_vector_test.cc.o test/vp9_skip_loopfilter_test.cc.o test/y4m_test.cc.o third_party/libwebm/mkvparser/mkvparser.cc.o third_party/libwebm/mkvparser/mkvreader.cc.o webmdec.cc.o y4menc.c.o y4minput.c.o -L. -lvpx -lgtest -lpthread -lm -lpthread
ln -sf libvpx.so.6.3.0 vpx-vp8-vp9-x86_64-linux-v1.9.0/lib/libvpx.so.6
/usr/bin/ld: /tmp/ccsyaUhJ.ltrans0.ltrans.o:(.debug_info+0x1586f): undefined reference to `gtest_all.cc.5c9bdf8f'
/usr/bin/ld: /tmp/ccsyaUhJ.ltrans0.ltrans.o:(.debug_info+0x158a5): undefined reference to `gtest_all.cc.5c9bdf8f'
/usr/bin/ld: /tmp/ccsyaUhJ.ltrans0.ltrans.o:(.debug_info+0x158b2): undefined reference to `gtest_all.cc.5c9bdf8f'
/usr/bin/ld: /tmp/ccsyaUhJ.ltrans0.ltrans.o:(.debug_info+0x158b7): undefined reference to `gtest_all.cc.5c9bdf8f'
/usr/bin/ld: /tmp/ccsyaUhJ.ltrans0.ltrans.o:(.debug_info+0x158dd): undefined reference to `gtest_all.cc.5c9bdf8f'
/usr/bin/ld: /tmp/ccsyaUhJ.ltrans0.ltrans.o:(.debug_info+0x15903): more undefined references to `gtest_all.cc.5c9bdf8f' follow
collect2: error: ld returned 1 exit status

Tags: ftbfs patch lto

Related branches

~sergiodj/ubuntu/+source/libvpx:fix-ftbfs-gcc-11
Lucas Kanashiro (community): Approve
Canonical Server packageset reviewers: Pending requested
Diff: 43 lines (+12/-1)
3 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/rules (+3/-0)
Sergio Durigan Junior (sergiodj)
Changed in lto-disabled-list (Ubuntu):
assignee: nobody → Sergio Durigan Junior (sergiodj)
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

This patch adds libvpx to the lto-disabled-list package, thus working around the problem and disabling LTO for libvpx.

Revision history for this message
Oibaf (oibaf) wrote :

Did you eventually try if the issue is reproducible also with libvpx 1.10? It has some compiler fixes.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I have filed an upstream bug report:

https://bugs.chromium.org/p/webm/issues/detail?id=1736

Unfortunately it seems like a Google account is needed in order to view/comment on it.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Good point, Oibaf. I've just tested git HEAD and verified that the bug seems to have been fixed there, indeed. I commented on the bug report. Thanks.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Actually, I *can* reproduce the bug using git HEAD. As it turns out I was using an incomplete set of build flags that didn't trigger the problem. So yeah, the problem is still present in git HEAD.

Ubuntu Foundations Team Bug Bot (crichton)
tags: added: patch
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

The debdiff to add libvpx to lto-disabled-list package looks good to me, +1.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the review, Lucas.

Uploaded:

$ dput lto-disabled-list_15_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/lto-disabled-list/lto-disabled-list_15_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/lto-disabled-list/lto-disabled-list_15.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading lto-disabled-list_15.dsc: done.
  Uploading lto-disabled-list_15.tar.xz: done.
  Uploading lto-disabled-list_15_source.buildinfo: done.
  Uploading lto-disabled-list_15_source.changes: done.
Successfully uploaded packages.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lto-disabled-list - 15

---------------
lto-disabled-list (15) impish; urgency=medium

  * Add libvpx. (LP: #1939640)

 -- Sergio Durigan Junior <email address hidden> Thu, 12 Aug 2021 10:39:16 -0400

Changed in lto-disabled-list (Ubuntu):
status: New → Fix Released
Revision history for this message
Graham Inggs (ginggs) wrote :

libvpx was added to the '# packages not in main:' section.

Please only use lto-disabled-list for packages not in main. Packages in main should either be fixed or worked around in the package itself.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote : Re: [Bug 1939640] Re: libvpx FTBFS with LTO enabled

On Friday, August 13 2021, Graham Inggs wrote:

> libvpx was added to the '# packages not in main:' section.
>
> Please only use lto-disabled-list for packages not in main. Packages in
> main should either be fixed or worked around in the package itself.

Sorry about that. doko had pinged me about this mistake as well. I
have removed libvpx from lto-disabled-list and uploaded the package
again. I will fix the issue on libvpx.

Thanks,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libvpx - 1.9.0-1ubuntu1

---------------
libvpx (1.9.0-1ubuntu1) impish; urgency=medium

  * d/rules: Disable LTO and fix FTBFS when building with GCC 11.
    (LP: #1939640)

 -- Sergio Durigan Junior <email address hidden> Wed, 11 Aug 2021 22:25:45 -0400

Changed in libvpx (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.