Add new PCI MMIO based thermal driver [8086:461d] for Intel Alder Lake

Bug #1934741 reported by You-Sheng Yang
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
In Progress
High
You-Sheng Yang
Focal
Won't Fix
Undecided
Unassigned
Impish
Won't Fix
High
You-Sheng Yang
linux-oem-5.13 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Fix Released
High
You-Sheng Yang
Impish
Invalid
Undecided
Unassigned

Bug Description

[SRU Justification]

[Impact] [18/14083]

On Intel Alder Lake platforms, processor thermal device provides an
additional thermal zone TCPU_PCI that is based on a new PCI MMIO only
driver.

[Fix]

Two upstream v5.14-rc1 commits to backport.

[Test Case]

$ lspci -vvnns 00:04.0
00:04.0 Signal processing controller [1180]: Intel Corporation Device
[8086:461d] (rev 01)
        Subsystem: Intel Corporation Device [8086:7270]
        ...

# thermal_zones provided by the original driver
$ cat /sys/devices/virtual/thermal/thermal_zone*/type
acpitz
INT3400 Thermal
TCPU
x86_pkg_temp

# thermal_zones provided by the new driver
$ cat /sys/devices/virtual/thermal/thermal_zone*/type
acpitz
INT3400 Thermal
TCPU
TCPU_PCI
x86_pkg_temp

[Where problems could occur]

These changes do not change existing interface to userspace, but add an
additional thermal zone that doesn't involve ACPI method calls for use.

[Other Info]

ADL targets 5.13 kernel, so only Impish and oem-5.13 are nominated.

========== original bug description ==========

$ lspci -vvnns 00:04.0
00:04.0 Signal processing controller [1180]: Intel Corporation Device [8086:461d] (rev 01)
        Subsystem: Intel Corporation Device [8086:7270]
        Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
        Interrupt: pin A routed to IRQ 16
        Region 0: Memory at 6001c00000 (64-bit, non-prefetchable) [size=128K]
        Capabilities: <access denied>
        Kernel driver in use: proc_thermal
        Kernel modules: processor_thermal_device

[original]
$ cat /sys/devices/virtual/thermal/thermal_zone*/type
acpitz
INT3400 Thermal
TCPU
x86_pkg_temp

[patched]
$ cat /sys/devices/virtual/thermal/thermal_zone*/type
acpitz
INT3400 Thermal
TCPU
TCPU_PCI
x86_pkg_temp

---
ProblemType: Bug
ApportVersion: 2.20.11-0ubuntu27.18
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: ubuntu 1367 F.... pulseaudio
CasperMD5CheckResult: skip
DistributionChannelDescriptor:
 # This is the distribution channel descriptor for the OEM CDs
 # For more information see http://wiki.ubuntu.com/DistributionChannelDescriptor
 canonical-oem-somerville-focal-amd64-20200502-85+fossa-edge-staging+X130
DistroRelease: Ubuntu 20.04
InstallationDate: Installed on 2021-06-18 (18 days ago)
InstallationMedia: Ubuntu 20.04 "Focal" - Build amd64 LIVE Binary 20200502-05:58
IwConfig:
 lo no wireless extensions.

 enp0s31f6 no wireless extensions.
MachineType: Intel Corporation Alder Lake Client Platform
Package: linux (not installed)
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.13.0-2006-oem root=UUID=a4f90fb9-1c2c-4d37-be7a-1b67b667c378 ro automatic-oem-config quiet splash vt.handoff=7
ProcVersionSignature: Ubuntu 5.13.0-2006.6+lp1934660.1.adl.pmc.core-oem 5.13.0
PulseList: Error: command ['pacmd', 'list'] failed with exit code 1: No PulseAudio daemon running, or not running as session daemon.
RelatedPackageVersions:
 linux-restricted-modules-5.13.0-2006-oem N/A
 linux-backports-modules-5.13.0-2006-oem N/A
 linux-firmware 1.187.15
RfKill:
 0: hci0: Bluetooth
  Soft blocked: no
  Hard blocked: no
Tags: focal
Uname: Linux 5.13.0-2006-oem x86_64
UnreportableReason: This report is about a package that is not installed.
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: N/A
_MarkForUpload: False
dmi.bios.date: 02/25/2021
dmi.bios.vendor: Intel Corporation
dmi.bios.version: ADLSFWI1.R00.2081.A02.2102250858
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: AlderLake-S ADP-S DDR5 UDIMM CRB
dmi.board.vendor: Intel Corporation
dmi.board.version: 2
dmi.chassis.asset.tag: Chassis Asset Tag
dmi.chassis.type: 3
dmi.chassis.vendor: Intel Corporation
dmi.chassis.version: 0.1
dmi.ec.firmware.release: 1.25
dmi.modalias: dmi:bvnIntelCorporation:bvrADLSFWI1.R00.2081.A02.2102250858:bd02/25/2021:efr1.25:svnIntelCorporation:pnAlderLakeClientPlatform:pvr0.1:sku00001001002B0100:rvnIntelCorporation:rnAlderLake-SADP-SDDR5UDIMMCRB:rvr2:cvnIntelCorporation:ct3:cvr0.1:
dmi.product.family: Alder Lake Client System
dmi.product.name: Alder Lake Client Platform
dmi.product.sku: 00001001002B0100
dmi.product.version: 0.1
dmi.sys.vendor: Intel Corporation

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Proposed fix:
* https://patchwork.kernel.org/project<email address hidden>/
* https://patchwork.kernel.org/project<email address hidden>/

tags: added: apport-collected focal
description: updated
Revision history for this message
You-Sheng Yang (vicamo) wrote : AlsaInfo.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : CRDA.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : CurrentDmesg.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : Lspci.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : Lspci-vt.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : Lsusb.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : Lsusb-t.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : Lsusb-v.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : ProcCpuinfoMinimal.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : ProcEnviron.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : ProcInterrupts.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : ProcModules.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : UdevDb.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : WifiSyslog.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote : acpidump.txt

apport information

Revision history for this message
You-Sheng Yang (vicamo) wrote :
description: updated
Changed in linux-oem-5.13 (Ubuntu Impish):
status: New → Invalid
Changed in linux (Ubuntu Focal):
status: New → Won't Fix
Changed in linux (Ubuntu Impish):
status: New → In Progress
status: In Progress → Incomplete
Changed in linux-oem-5.13 (Ubuntu Focal):
status: New → Incomplete
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Verified built kernel working on ADL platforms. Tested-by mails sent. While there is no external pressure on this, we'd like to proceed SRU when they're merged upstream.

You-Sheng Yang (vicamo)
Changed in linux (Ubuntu Impish):
status: Incomplete → In Progress
importance: Undecided → High
assignee: nobody → You-Sheng Yang (vicamo)
Changed in linux-oem-5.13 (Ubuntu Focal):
status: Incomplete → In Progress
importance: Undecided → High
assignee: nobody → You-Sheng Yang (vicamo)
Revision history for this message
You-Sheng Yang (vicamo) wrote :
description: updated
AceLan Kao (acelankao)
Changed in linux-oem-5.13 (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
You-Sheng Yang (vicamo) wrote :

verified linux-oem-5.13 version 5.13.0-1010.11 from focal-proposed.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.6 KiB)

This bug was fixed in the package linux-oem-5.13 - 5.13.0-1010.11

---------------
linux-oem-5.13 (5.13.0-1010.11) focal; urgency=medium

  * focal/linux-oem-5.13: 5.13.0-1010.11 -proposed tracker (LP: #1937217)

  * Packaging resync (LP: #1786013)
    - [Packaging] update update.conf, follow impish

  * [SRU][OEM-5.13/U] Fix firmware reload failure of MT7921 (LP: #1936790)
    - mt76: mt7921: continue to probe driver when fw already downloaded

  * Backport support for AMD SMU statistics (LP: #1934809)
    - platform/x86: amd-pmc: Fix command completion code
    - platform/x86: amd-pmc: Fix SMU firmware reporting mechanism
    - platform/x86: amd-pmc: call dump registers only once
    - platform/x86: amd-pmc: Add support for logging SMU metrics
    - platform/x86: amd-pmc: Add support for logging s0ix counters
    - platform/x86: amd-pmc: Add support for ACPI ID AMDI0006
    - platform/x86: amd-pmc: Add new acpi id for future PMC controllers
    - platform/x86: amd-pmc: Use return code on suspend
    - platform/x86: amd-pmc: Fix missing unlock on error in amd_pmc_send_cmd()
    - platform/x86: amd-pmc: Fix undefined reference to __udivdi3

  * Skip rtcpie test in kselftests/timers if the default RTC device does not
    exist (LP: #1937991)
    - selftests: timers: rtcpie: skip test if default RTC device does not exist

  * Support AMD W6600 [1002:73E3] (LP: #1938145)
    - drm/amdgpu: add new dimgrey cavefish DID

  * Add additional Mediatek MT7921 WiFi/BT device IDs (LP: #1937004)
    - Bluetooth: btusb: Fixed too many in-token issue for Mediatek Chip.
    - Bluetooth: btusb: Add support for Lite-On Mediatek Chip
    - Bluetooth: btusb: fix memory leak
    - SAUCE: Bluetooth: btusb: Add Mediatek MT7921 support for Foxconn
    - SAUCE: Bluetooth: btusb: Add Mediatek MT7921 support for IMC Network
    - SAUCE: Bluetooth: btusb: Add support for Foxconn Mediatek Chip

  * Add new PCI MMIO based thermal driver [8086:461d] for Intel Alder Lake
    (LP: #1934741)
    - thermal/drivers/int340x/processor_thermal: Split enumeration and processing
      part
    - thermal/drivers/int340x/processor_thermal: Add PCI MMIO based thermal driver

  * On TGL platforms screen shows garbage when browsing website by scrolling
    mouse (LP: #1926579)
    - drm/i915/display: Disable PSR2 if TGL Display stepping is B1 from A0

  * Fix kernel panic caused by legacy devices on AMD platforms (LP: #1936682)
    - SAUCE: iommu/amd: Keep swiotlb enabled to ensure devices with 32bit DMA
      still work

  * Fix display output on HP hybrid GFX laptops (LP: #1936296)
    - drm/i915: Invoke another _DSM to enable MUX on HP Workstation laptops

  * Add support for AMD BCL DID (LP: #1936785)
    - SAUCE: drm/amdgpu: add another Renior DID

  * e1000e blocks the boot process when it tried to write checksum to its NVM
    (LP: #1936998)
    - SAUCE: e1000e: Do not take care about recovery NVM checksum

  * Mute/mic LEDs no function on some HP platfroms (LP: #1934878)
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 450 G8
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 445 G8
    - ALSA: hda/realtek: fix mute/micmute LEDs for HP ProBook 630 G8

  * ...

Read more...

Changed in linux-oem-5.13 (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote :

Ubuntu 21.10 (Impish Indri) has reached end of life, so this bug will not be fixed for that specific release.

Changed in linux (Ubuntu Impish):
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.