link mac isn't set if already up

Hello Dan, or anyone else affected,

Accepted systemd into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/246.6-1ubuntu1.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Dan, or anyone else affected,

Accepted systemd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/245.4-4ubuntu3.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Dan, or anyone else affected,

Accepted systemd into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/237-3ubuntu10.48 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

$ cat /etc/systemd/network/10-ens3.network
[Match]
Name=ens3

[Link]
MACAddress=00:16:3e:ff:ff:ff

[Network]
DHCP=yes

ubuntu@lp1929560-g:~$ dpkg -l systemd|grep systemd
ii systemd 246.6-1ubuntu1.3 amd64 system and service manager
ubuntu@lp1929560-g:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:be:9d:58 brd ff:ff:ff:ff:ff:ff
    altname enp0s3
ubuntu@lp1929560-g:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-g:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:be:9d:58 brd ff:ff:ff:ff:ff:ff
    altname enp0s3
ubuntu@lp1929560-g:~$ sudo ip l set down dev ens3
ubuntu@lp1929560-g:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000
    link/ether 52:54:00:be:9d:58 brd ff:ff:ff:ff:ff:ff
    altname enp0s3
ubuntu@lp1929560-g:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-g:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 00:16:3e:ff:ff:ff brd ff:ff:ff:ff:ff:ff permaddr 52:54:00:be:9d:58
    altname enp0s3

ubuntu@lp1929560-g:~$ dpkg -l systemd|grep systemd
ii systemd 246.6-1ubuntu1.4 amd64 system and service manager
ubuntu@lp1929560-g:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:be:9d:58 brd ff:ff:ff:ff:ff:ff
    altname enp0s3
ubuntu@lp1929560-g:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-g:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 00:16:3e:ff:ff:ff brd ff:ff:ff:ff:ff:ff permaddr 52:54:00:be:9d:58
    altname enp0s3

ubuntu@lp1929560-f:~$ dpkg -l systemd|grep systemd
ii systemd 245.4-4ubuntu3.6 amd64 system and service manager
ubuntu@lp1929560-f:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:99:fe:7f brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-f:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-f:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:99:fe:7f brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-f:~$ sudo ip l set down dev ens3
ubuntu@lp1929560-f:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000
    link/ether 52:54:00:99:fe:7f brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-f:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-f:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 00:16:3e:ff:ff:ff brd ff:ff:ff:ff:ff:ff

ubuntu@lp1929560-f:~$ dpkg -l systemd|grep systemd
ii systemd 245.4-4ubuntu3.7 amd64 system and service manager
ubuntu@lp1929560-f:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:99:fe:7f brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-f:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-f:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 00:16:3e:ff:ff:ff brd ff:ff:ff:ff:ff:ff

ubuntu@lp1929560-b:~$ dpkg -l systemd|grep systemd
ii systemd 237-3ubuntu10.47 amd64 system and service manager
ubuntu@lp1929560-b:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:a0:0b:8d brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-b:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-b:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:a0:0b:8d brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-b:~$ sudo ip l set down dev ens3
ubuntu@lp1929560-b:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST> mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000
    link/ether 52:54:00:a0:0b:8d brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-b:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-b:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 00:16:3e:ff:ff:ff brd ff:ff:ff:ff:ff:ff

ubuntu@lp1929560-b:~$ dpkg -l systemd|grep systemd
ii systemd 237-3ubuntu10.48 amd64 system and service manager
ubuntu@lp1929560-b:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 52:54:00:a0:0b:8d brd ff:ff:ff:ff:ff:ff
ubuntu@lp1929560-b:~$ sudo systemctl restart systemd-networkd
ubuntu@lp1929560-b:~$ ip l show dev ens3
2: ens3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT group default qlen 1000
    link/ether 00:16:3e:ff:ff:ff brd ff:ff:ff:ff:ff:ff

All autopkgtests for the newly accepted systemd (246.6-1ubuntu1.4) for groovy have finished running.
The following regressions have been reported in tests triggered by the package:

casync/2+20190213-1 (s390x)
udisks2/2.9.1-2ubuntu1 (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/groovy/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

This bug was fixed in the package systemd - 246.6-1ubuntu1.4

---------------
systemd (246.6-1ubuntu1.4) groovy; urgency=medium

  [ Andy Chi ]
  * debian/patches/lp1926547-hwdb-60-keyboard-Update-Dell-Privacy-Local-Mic-Mute-.patch
    - Apply upstream patch to correct key and device mapping.
      (LP: #1926547)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=a4c14d1c8370445e315ffa59b0a7ce593a79fbf4

  [ Dan Streetman ]
  * d/p/lp1921696/0001-rfkill-improve-error-logging.patch,
    d/p/lp1921696/0002-rfkill-use-short-writes-and-accept-long-reads.patch:
    Handle rfkill api change in kernel 5.10 (LP: #1921696)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b683c842c74b5f193555fd79bc76e574a025f5b1
  * d/p/lp1929560-network-move-set-MAC-and-set-nomaster-operations-out.patch:
    Move link mac and master config out of link_up() (LP: #1929560)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=a90963d52a70c0ed1b429b1025b95f8c0fa6e7aa
  * d/p/lp1902891-core-mount-mount-command-may-fail-after-adding-the-c.patch:
    Handle failed mount command (LP: #1902891)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=d83f3bce38e04395c6406c3c45efbc9977ae1138
  * d/p/debian/UBUNTU-resolved-Mitigate-DVE-2018-0001-by-retrying-NXDOMAIN-with.patch,
    d/p/lp1880258-log-nxdomain-as-debug.patch,
    d/p/lp1785383-resolved-address-DVE-2018-0001.patch:
    - Use upstream patch for DVE-2018-0001 handling (LP: #1785383)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=eb311ad89c5fd570bf3af362d8a2af1b357be3dd

  [ Łukasz 'sil2100' Zemczak ]
  * d/p/lp1664844/0001-network-add-ActivationPolicy-configuration-parameter.patch,
    d/p/lp1664844/0002-test-add-ActivationPolicy-unit-tests.patch,
    d/p/lp1664844/0003-save-link-activation-policy-to-state-file-and-displa.patch:
    - add support for configuring the activation policy for an interface
      (LP: #1664844)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=0b0a9202964b24fb8d9fb4b28bdb22c6aadd25b7

 -- Dan Streetman <email address hidden> Thu, 27 May 2021 11:13:07 -0400

The verification of the Stable Release Update for systemd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package systemd - 245.4-4ubuntu3.7

---------------
systemd (245.4-4ubuntu3.7) focal; urgency=medium

  [ Andy Chi ]
  * debian/patches/lp1926547-hwdb-60-keyboard-Update-Dell-Privacy-Local-Mic-Mute-.patch
    - Apply upstream patch to correct key and device mapping.
      (LP: #1926547)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=62c3ce6d6b2cab762b24aa610d6d135a67bdd76a

  [ Dan Streetman ]
  * d/p/lp1921696/0001-rfkill-improve-error-logging.patch,
    d/p/lp1921696/0002-rfkill-use-short-writes-and-accept-long-reads.patch:
    Handle rfkill api change in kernel 5.10 (LP: #1921696)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=ff0c23ba4fbcfa7f68e98adb6d62798ce54ca1da
  * d/p/lp1929122-network-check-that-received-ifindex-is-valid.patch:
    Check if ifindex is valid (LP: #1929122)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=6378191818bc7d169b657e6f7a2b50cfddb4275e
  * d/p/lp1929560-network-move-set-MAC-and-set-nomaster-operations-out.patch:
    Move link mac and master config out of link_up() (LP: #1929560)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=28cff7ee02a9ebd4ab93026af9fceaa2283725b3
  * d/p/lp1902891-core-mount-mount-command-may-fail-after-adding-the-c.patch:
    Handle failed mount command (LP: #1902891)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b425189a483d7455db870b0ec5b2443c0eea7d76
  * d/p/resolved-Mitigate-DVE-2018-0001-by-retrying-NXDOMAIN-with.patch,
    d/p/lp1880258-log-nxdomain-as-debug.patch,
    d/p/lp1785383-resolved-address-DVE-2018-0001.patch:
    - Use upstream patch for DVE-2018-0001 handling (LP: #1785383)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=ec45ebfee362ad3e429642f7519e8b88f16dc221

  [ Łukasz 'sil2100' Zemczak ]
  * d/p/lp1664844/0001-network-add-ActivationPolicy-configuration-parameter.patch,
    d/p/lp1664844/0002-test-add-ActivationPolicy-unit-tests.patch,
    d/p/lp1664844/0003-save-link-activation-policy-to-state-file-and-displa.patch:
    - add support for configuring the activation policy for an interface
      (LP: #1664844)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=94f7b72d8128c743f35b308101a87d2c53a4074c

 -- Dan Streetman <email address hidden> Thu, 27 May 2021 11:16:17 -0400

This bug was fixed in the package systemd - 237-3ubuntu10.48

---------------
systemd (237-3ubuntu10.48) bionic; urgency=medium

  * d/p/lp1925216-seccomp-rework-functions-for-parsing-system-call-fil.patch:
    Downgrade syscall group parsing failure logs to debug (LP: #1925216)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=8c0181e24f7c0128a48c706d1f4b28ec0f225fd7
  * d/p/lp1929560-network-move-set-MAC-and-set-nomaster-operations-out.patch:
    Move link mac and master config out of link_up() (LP: #1929560)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=d808ea22366ca7ba4b5bb32815ab0ca2eea8a49f
  * d/p/resolved-Mitigate-DVE-2018-0001-by-retrying-NXDOMAIN-with.patch,
    d/p/resolved_disable-connection-downgrade-when-DNSSEC-yes.patch,
    d/p/lp1880258-log-nxdomain-as-debug.patch,
    d/p/lp1785383-resolved-address-DVE-2018-0001.patch:
    - Use upstream patch for DVE-2018-0001 handling (LP: #1785383)
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=b6258fda64c84c34b0f8026e6e29bcfffa8dc4f1

 -- Dan Streetman <email address hidden> Thu, 27 May 2021 11:18:38 -0400

This backport to 18.04 LTS broke all our OpenStack compute nodes. We use systemd-network to configure interfaces etc. and neutron-linuxbridge-agent with some flat networks. In this scenario, the neutron agent creates bridges for the flat networks and assigns them to physical interfaces based on a mapping.

The backport now sets nomaster on these interfaces, effectively removing the bridges and cutting of connectivity of all VMs using these flat networks. This happened already when the systemd package was upgraded (and systemd-networkd restarted).

Example:

```
10: flat-net1@data: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master brq88363244-5f state UP group default qlen 1000
    link/ether b0:22:28:1c:f7:12 brd ff:ff:ff:ff:ff:ff
```

The interface (VLAN here) is created and managed by systemd-networkd, the bridge `brq88363244-5f` is managed by neutron. Of course, systemd-networkd doesn't know anything about the bridge, this wasn't a problem until now, but the latest patch update always sets nomaster to `flat-net1`. We were really surprise by this change in 18.04 LTS.

Is there any recommend workaround to have systemd-networkd not set nomaster or do we have to not use systemd-network at all?

>Is there any recommend workaround to have systemd-networkd not set nomaster or do we have to not use systemd-network at all?

open a new bug and provide your specific networkd configuration

> This backport to 18.04 LTS broke all our OpenStack compute nodes

I've opened bug 1937117 to revert this fix, however keep in mind your networkd configuration is incorrect and should be fixed as you will have problems later if you continue to mix systemd-networkd management of interface(s) as well as manual/external configuration of those same systemd-networkd-managed interface(s).

This fix was reverted for Bionic and Focal, so please note that this bug does still exist in those releases and will not be fixed.

Thanks a lot for your work, Dan! Unfortunately, I wasn't able to pick up the new bug from here, sorry for that. (It appears I did not get any notification on your comments, need to check that)

The bridges are managed by OpenStack Neutron from Ubuntu cloud archives and with names derived from the network UUID in the cluster database. It might work for a very limited set of bridges, if they do not set different options. AFAIK, OpenStack Neutron is still working on supporting using external bridges (https://bugs.launchpad.net/neutron/+bug/1105488).

As we have bridges on VLANs on bonded interfaces (currently managed with systemd-networkd), I will see if I have to replace that all or if there is an option to just have systemd-networkd not set nomaster...

Thanks!