Ubuntu
golang-github-fsouza-go-dockerclient package

FTBFS against docker 20.10

Bug #1923108 reported by Lucas Kanashiro on 2021-04-08

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	golang-github-fsouza-go-dockerclient (Ubuntu)	Fix Released	Undecided	Unassigned
	Bionic	Fix Released	Undecided	Unassigned

Bug Description

[Impact]

The version in Bionic FTBFS against docker 20.10 currently in bionic-proposed. This would be considered a regression.

[Test Plan]

Make sure the upstream test suite is passing during build time.

[Where problems could occur]

There could be any breakage related to the move from Go 1.10 to 1.13. Moreover, the network part of the library needs to be patched to support the new Go version, so any issue in this area could be related to this update.

See original description

Tags:

Revision history for this message

Lucas Kanashiro (lucaskanashiro) wrote on 2021-04-08:

debdiff Edit (6.2 KiB, text/plain)

The attached patch fixes the FTBFS in bionic (with bionic-proposed enabled). I uploaded this packages to this PPA to confirm that:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/buildah-and-libpod

Changed in golang-github-fsouza-go-dockerclient (Ubuntu):
status:	New → Fix Released

Lucas Kanashiro (lucaskanashiro) on 2021-04-08

description:

updated

Revision history for this message

Sergio Durigan Junior (sergiodj) wrote on 2021-04-08:

Thanks for taking care of this, Lucas.

I reviewed the patch and have two minor comments:

- Since you're adding a delta to the package, update-maintainer needs to be run.

- Now that you have an Ubuntu bug number, I think you could add the "Bug-Ubuntu" DEP-3 header to the patches.

Everything else LGTM to me otherwise. I have tested the patch locally and verified that it does indeed fix the FTBFS that happens without it.

The only other comment I have is the fact that the package doesn't have a dep8/autodep8 test (I tried running it locally and got the "SKIP no tests in this package" message), so it may be a bit harder to verify that the functionality stays the same and there are no regressions due to the SRU.

Revision history for this message

Lucas Kanashiro (lucaskanashiro) wrote on 2021-04-09:

debdiff Edit (6.7 KiB, text/plain)

Thanks for the review Sergio!

I indeed forgot the add references to the LP bug, it is done now. Regarding the DEP-8 tests you are right, there is no definition for them. I'll update the bug description to add the upstream tests executed during build time instead of DEP-8 tests, I think we do not have many options.

description:

updated

Revision history for this message

Sergio Durigan Junior (sergiodj) wrote on 2021-04-09:

Awesome, thanks Lucas. LGTM now, +1.

Revision history for this message

Lucas Kanashiro (lucaskanashiro) wrote on 2021-04-09:

Package uploaded.

Revision history for this message

Robie Basak (racb) wrote on 2021-04-09:

> +export GOCACHE := $(shell mktemp -d)

This isn't cleaned up in the clean target, so might wind up a developer trying to work on the packaging! Could you have used something inside debian/tmp/ instead?

Anyway, I don't think it's important enough to hold up this SRU, so accepting.

Changed in golang-github-fsouza-go-dockerclient (Ubuntu Bionic):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-bionic

Revision history for this message

Robie Basak (racb) wrote on 2021-04-09: Please test proposed package

Hello Lucas, or anyone else affected,

Accepted golang-github-fsouza-go-dockerclient into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/golang-github-fsouza-go-dockerclient/0.0+git20160622-3ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message

Robie Basak (racb) wrote on 2021-04-09:

I'd appreciate opinions on whether it would be better to hold this in bionic-proposed pending a further update, or seek to land it in bionic-updates soon.

Revision history for this message

Lucas Kanashiro (lucaskanashiro) wrote on 2021-04-13:

The package built fine on LP which means all the upstream tests passed during build time.

tags:

added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-04-19:

#10

This bug was fixed in the package golang-github-fsouza-go-dockerclient - 0.0+git20160622-3ubuntu0.1

---------------
golang-github-fsouza-go-dockerclient (0.0+git20160622-3ubuntu0.1) bionic; urgency=medium

  * Fix FTBFS due to new docker version (LP: #1923108).
    - d/control: b-d on golang-1.13-go instead of golang-any. The docker
      library does not support Go 1.10 which is the default in Bionic.
    - d/rules: build with Go 1.13.
      + Add Go 1.13 to the $PATH.
      + Set $GOCACHE with a temporary directory.
      + Set $GO111MODULE to off.
    - d/patches: backport some upstream patches to support Go 1.13.
      + update-network.go.patch
      + network-test-fix-test.patch

-- Lucas Kanashiro <email address hidden> Thu, 08 Apr 2021 15:34:41 -0300

Changed in golang-github-fsouza-go-dockerclient (Ubuntu Bionic):
status:	Fix Committed → Fix Released

Revision history for this message

Robie Basak (racb) wrote on 2021-04-19: Update Released

#11

The verification of the Stable Release Update for golang-github-fsouza-go-dockerclient has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.