[SRU] cmake: FindPkgConfig: imported target missing libraries

The attachment "0001-FindPkgConfig-correct-library-search-path-for-import.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

@Matwey please provide a simple test case to check if the bug is fixed!

thanks

Gianfranco

Sorry, I don't understand the bug or the test plan. What's the use case that is broken? What's the expected result, and what happens instead?

I also see no regression analysis as required by https://wiki.ubuntu.com/StableReleaseUpdates#Procedure. Please consider what might go wrong with this. Will reverse dependencies in Bionic rebuild differently, for example?

Hello Robie, the cmake if I understand correctly checks the list of libraries returned from pkg-config call, and adds them only if found on the system.
The problem is that if the pkgconfig call has a -L *but* libraries listed somewhere else (e.g. in standard ld.so.conf path), the call strips them from the list.

So, in this case you get a subset of libraries returned to cmake, and with this patch, the list of libraries will increase (not decrease). With a default as-needed flag turned on, the side effect will be to have them ignored in such cases, nothing to worry about.

(I suspect people were manually adding them with some hacks in cmake files, now they can remove such hacks)

Hello Matwey, or anyone else affected,

Accepted cmake into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cmake/3.10.2-1ubuntu2.18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

@Matwey please test the proposed package. thanks

The package looks good to me!

The verification of the Stable Release Update for cmake has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package cmake - 3.10.2-1ubuntu2.18.04.2

---------------
cmake (3.10.2-1ubuntu2.18.04.2) bionic; urgency=medium

  [ Matwey V. Kornilov ]
  * debian/patches/0001-FindPkgConfig-correct-library-search-path-for-
    import.patch: Cherry-pick upstream fix for pkg-config failure to find
    the library if -L was provided (and library not in that path)
    LP: #1922417

 -- Gianfranco Costamagna <email address hidden> Sun, 04 Apr 2021 16:10:12 +0200