Seperate ppaput backend from script

Bug #192184 reported by Andrew Hunter
4
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Fix Released
Wishlist
Andrew Hunter

Bug Description

Binary package hint: ubuntu-dev-tools

The ppaput backend should be seperate from the script so that other applications can take advantage of that funtionality.

Andrew Hunter (rexbron)
Changed in ubuntu-dev-tools:
assignee: nobody → rexbron
status: New → In Progress
Revision history for this message
Siegfried Gevatter (rainct) wrote :

Merged into trunk. Thanks!

Changed in ubuntu-dev-tools:
importance: Undecided → Wishlist
status: In Progress → Fix Committed
Revision history for this message
Daniel Holbach (dholbach) wrote :

There is a bit of confusion regarding the name of the python module:

1)
debian/control:
Package: python-ubuntu-utils
Architecture: all

2) debian/python-ppaput.install

3) py_modules=['modules/ppaput.py']

I'd suggest: rename the directory to 'ubuntutools' and all package related names to python-ubuntutools.

Revision history for this message
Andrew Hunter (rexbron) wrote :

These issues are fixed in the latest rev of my branch, please pull the fixes if they have not been.

Revision history for this message
Siegfried Gevatter (rainct) wrote :

Oops, I spoke with Daniel Holbach but forget to comment back here, sorry. I was aware of this issues (just hadn't time to get everything ready that day); trunk is okay now.

How it ended up: the binary package for the python modules is called 'python-ubuntutools' (as dholbach suggested) and all modules (that is, right now, only yours) is (in the source) in a new directory called 'ubuntutools'. Also, the name 'ubuntutools' has become a namespace (ie, now you've to do 'import ubuntutools.ppaput' instead of just 'import ubuntutools'). The only remaining issue now is to document the module properly with docstrings.

Having explained this, is there still something on your branch that should be merged into trunk?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.27

---------------
ubuntu-dev-tools (0.27) hardy; urgency=low

  [ Andrew Hunter ]
  * ppaput:
    - Separated ppaput script from backend python modules (LP: #192184).
    - Switched from homegrown option parseing to Optparse, much more
      robust and less code duplication.

  [ Daniel Holbach ]
  * README, debian/rules, doc/ppaput.1.docbook, ppaput, setup.py: removed
    ppaput for now. It has shortcomings and is not actively used in the
    sponsoring process (LP: #194634).

  [ Siegfried-Angel Gevatter Pujals (RainCT) ]
  * This upload removes accidentaly uploaded files (LP: #194635, #194618,
    #194621).
  * Remove executable bit from AUTHORS file (LP: #194619).
  * debian/control:
     - Change the Vcs-Bzr address to the correct one.
     - Move the reportbug dependency to Recommends.
     - Drop docbook2x build dependency (see Daniel's changes).
  * Move ppaput.py (the module) into new ubuntutools/ directory and
    remove it's shabang.
  * submittodebian:
     - Check if reportbug is installed and if it isn't throw an error.
  * suspicious-sources:
     - Ignore .in files.
  * pbuilder-dist:
     - Apply patch from James Westby to fix a problem where it always
       wanted to get the architecture to use as an option if a symlink
       was being used .
     - Fix a recently introduced problem where pbuilder-dist would always
       want to know the architecture if a symlink was being used. Thanks to
       Adrien Cunin and James Westby for their help on this (LP: #194633).
     - Escape many variables to avoid possible problems there.
     - Reorganize the code a bit and comment it.
     - Accept "upgrade" as an alias for "update".
     - Hide lsb_release's traceback if pbuilder-dist is manually aborted
       while the distribution was being detected.
  * 404main:
     - Try to filter out entries from Debian and PPAs, thanks to Adrien
       Cunin! (LP: #194704)
     - Add limited support for multiple distributions (and update they
       manpage to reflect this).
     - TODO: Use python-apt instead of lots of pipes.
  * debian/copyright.
     - Add ppaput (the executable has been removed for now -see above-,
       but there is still the module in the source package).
  * debian/pycompat:
     - Remove it, as it is not necessary for python-central.

  [ Terence Simpson ]
  * dgetlp:
     - Fix bug where optaining the .orig.tar.gz would fail if the package
       name contains hypens.
     - Add support for native packages.

 -- Siegfried-Angel Gevatter Pujals (RainCT) <email address hidden> Sun, 24 Feb 2008 19:11:06 +0100

Changed in ubuntu-dev-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.