restore reverted commit "crypto: arm64/sha - avoid non-standard inline asm tricks"

Bug #1907489 reported by dann frazier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Invalid
Undecided
Unassigned
Xenial
Fix Released
Medium
dann frazier

Bug Description

[Impact]
To address bug 1905336, we reverted an upstream commit. Upstream have now pulled in a commit to properly fix the underlying issue. Once we merge that fix, we should be able to reapply the reverted commit.

[Test Case]
If the kernel boots and we can still load the sha{1,2}_ce modules, we should be good.

[Fix]
After this is applied:
  https://www.spinics.net/lists/stable/msg431217.html
We should reapply the commit we reverted here:
  https://kernel.ubuntu.com/git/ubuntu/ubuntu-xenial.git/commit/?id=4baa2fdd354700e2304e10cdbc64402621c3fa29

[Where Problems May Occur]
Although we shipped the reverted patch for many releases - the whole time we did so, the impacted modules were not loadable. Once we reapply it, xenial users will be running that code for the first time. If there are issues with the code, users of the sha{1,2}_ce modules may now hit them. Issues could include kernel oopses, corruption, etc.

CVE References

dann frazier (dannf)
Changed in linux (Ubuntu Xenial):
assignee: nobody → dann frazier (dannf)
status: New → In Progress
Changed in linux (Ubuntu):
status: New → Invalid
Stefan Bader (smb)
Changed in linux (Ubuntu Xenial):
importance: Undecided → Medium
Changed in linux (Ubuntu Xenial):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-xenial' to 'verification-done-xenial'. If the problem still exists, change the tag 'verification-needed-xenial' to 'verification-failed-xenial'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-xenial
Revision history for this message
dann frazier (dannf) wrote :

Verification:

ubuntu@anuchin:~$ cat /proc/version
Linux version 4.4.0-202-generic (buildd@bos02-arm64-077) (gcc version 5.4.0 20160609 (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.12) ) #234-Ubuntu SMP Thu Jan 28 02:06:34 UTC 2021
ubuntu@anuchin:~$ lsmod | grep sha
sha2_ce 16384 0
sha1_ce 16384 0

tags: added: verification-done-xenial
removed: verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (11.8 KiB)

This bug was fixed in the package linux - 4.4.0-203.235

---------------
linux (4.4.0-203.235) xenial; urgency=medium

  * xenial/linux: 4.4.0-203.235 -proposed tracker (LP: #1914140)

  * Ubuntu 16.04 kernel 4.4.0-202 basic commands hanging (LP: #1913853)
    - SAUCE: Revert "mm: check that mm is still valid in madvise()"

linux (4.4.0-202.234) xenial; urgency=medium

  * xenial/linux: 4.4.0-202.234 -proposed tracker (LP: #1913086)

  * DMI entry syntax fix for Pegatron / ByteSpeed C15B (LP: #1910639)
    - Input: i8042 - unbreak Pegatron C15B

  * CVE-2020-29372
    - mm: check that mm is still valid in madvise()

  * errinjct open fails on IBM POWER LPAR (LP: #1908710)
    - powerpc/rtas: Fix typo of ibm, open-errinjct in RTAS filter

  * 4.4 kernel panics in kvm wake_up() handler (LP: #1908428)
    - kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block
    - KVM: VMX: extract __pi_post_block
    - KVM: VMX: avoid double list add with VT-d posted interrupts

  * restore reverted commit "crypto: arm64/sha - avoid non-standard inline asm
    tricks" (LP: #1907489)
    - crypto: arm64/sha - avoid non-standard inline asm tricks

  * CVE-2020-29374
    - gup: document and work around "COW can break either way" issue

  * Xenial update: v4.4.249 upstream stable release (LP: #1910139)
    - spi: bcm2835aux: Fix use-after-free on unbind
    - spi: bcm2835aux: Restore err assignment in bcm2835aux_spi_probe
    - ARC: stack unwinding: don't assume non-current task is sleeping
    - platform/x86: acer-wmi: add automatic keyboard background light toggle key
      as KEY_LIGHTS_TOGGLE
    - Input: cm109 - do not stomp on control URB
    - Input: i8042 - add Acer laptops to the i8042 reset list
    - [Config] updateconfigs for SPI_DYNAMIC
    - spi: Prevent adding devices below an unregistering controller
    - net/mlx4_en: Avoid scheduling restart task if it is already running
    - tcp: fix cwnd-limited bug for TSO deferral where we send nothing
    - net: stmmac: delete the eee_ctrl_timer after napi disabled
    - net: bridge: vlan: fix error return code in __vlan_add()
    - USB: dummy-hcd: Fix uninitialized array use in init()
    - USB: add RESET_RESUME quirk for Snapscan 1212
    - ALSA: usb-audio: Fix potential out-of-bounds shift
    - ALSA: usb-audio: Fix control 'access overflow' errors from chmap
    - xhci: Give USB2 ports time to enter U3 in bus suspend
    - USB: sisusbvga: Make console support depend on BROKEN
    - [Config] updateconfigs for USB_SISUSBVGA_CON
    - ALSA: pcm: oss: Fix potential out-of-bounds shift
    - serial: 8250_omap: Avoid FIFO corruption caused by MDR1 access
    - USB: serial: cp210x: enable usb generic throttle/unthrottle
    - scsi: bnx2i: Requires MMU
    - can: softing: softing_netdev_open(): fix error handling
    - RDMA/cm: Fix an attempt to use non-valid pointer when cleaning timewait
    - dm table: Remove BUG_ON(in_interrupt())
    - soc/tegra: fuse: Fix index bug in get_process_id
    - USB: serial: option: add interface-number sanity check to flag handling
    - USB: gadget: f_rndis: fix bitrate for SuperSpeed and above
    - usb: chipidea: ci_hdrc_imx: Pass DISABLE_DEVICE_STREAMING flag to imx6ul
...

Changed in linux (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.