fwupd ftbfs in focal

Bug #1870051 reported by Matthias Klose
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
fwupd (Ubuntu)
Fix Released
High
Mario Limonciello

Bug Description

https://launchpadlibrarian.net/471776629/buildlog_ubuntu-focal-amd64.fwupd_1.3.9-3_BUILDING.txt.gz

seen on all 64bit archs

(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuPluginUefi-DEBUG: 17:43:16.088: DP type:0x7f subtype:0xff size:0x0004
ok 9 /uefi/update-info
# FuDevice-DEBUG: using 2c1302f31806a0e0d57c377d99e18dae56351413 for UEFI-ddc0ee61-e7f0-4e7d-acc5-c070a398838e-dev0
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuDevice-DEBUG: 17:43:16.088: using 2c1302f31806a0e0d57c377d99e18dae56351413 for UEFI-ddc0ee61-e7f0-4e7d-acc5-c070a398838e-dev0
# FuDevice-DEBUG: using 1f9ed21ce218ebcd0e1c803b7da08dd4e33d01a3 for UEFI-671d19d0-d43c-4852-98d9-1ce16f9967e4-dev0
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuDevice-DEBUG: 17:43:16.088: using 1f9ed21ce218ebcd0e1c803b7da08dd4e33d01a3 for UEFI-671d19d0-d43c-4852-98d9-1ce16f9967e4-dev0
# FuDevice-DEBUG: using 8c7c8f687a2a7a80b4c50e575d0fd84762edf797 for UEFI-00000000-0000-0000-0000-000000000000-dev0
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuDevice-DEBUG: 17:43:16.088: using 8c7c8f687a2a7a80b4c50e575d0fd84762edf797 for UEFI-00000000-0000-0000-0000-000000000000-dev0
# FuPluginUefi-DEBUG: failed to add /<<PKGBUILDDIR>>/plugins/uefi/tests/efi/esrt/entries/entry2: ESRT GUID '00000000-0000-0000-0000-000000000000' was not valid
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuPluginUefi-DEBUG: 17:43:16.088: failed to add /<<PKGBUILDDIR>>/plugins/uefi/tests/efi/esrt/entries/entry2: ESRT GUID '00000000-0000-0000-0000-000000000000' was not valid
ok 10 /uefi/plugin
# End of uefi tests
-------

Ok: 18
Expected Fail: 0
Fail: 1
Unexpected Pass: 0
Skipped: 0
Timeout: 0
dh_auto_test: error: cd obj-x86_64-linux-gnu && LC_ALL=C.UTF-8 MESON_TESTTHREADS=4 ninja test returned exit code 1
make[1]: *** [debian/rules:93: override_dh_auto_test] Error 25

Matthias Klose (doko)
Changed in fwupd (Ubuntu):
status: New → Confirmed
importance: Undecided → High
tags: added: ftbfs rls-ff-incoming
Revision history for this message
Richard Hughes (richard-hughes) wrote :

> Fail: 1

What's the failure?

Revision history for this message
Mario Limonciello (superm1) wrote :

Looking at the linked log it looks like the uefi self tests are failing somehow with an invalid ESRT GUID of all zeros.

# FuDevice-DEBUG: using 2c1302f31806a0e0d57c377d99e18dae56351413 for UEFI-ddc0ee61-e7f0-4e7d-acc5-c070a398838e-dev0
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuDevice-DEBUG: 17:43:16.088: using 2c1302f31806a0e0d57c377d99e18dae56351413 for UEFI-ddc0ee61-e7f0-4e7d-acc5-c070a398838e-dev0
# FuDevice-DEBUG: using 1f9ed21ce218ebcd0e1c803b7da08dd4e33d01a3 for UEFI-671d19d0-d43c-4852-98d9-1ce16f9967e4-dev0
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuDevice-DEBUG: 17:43:16.088: using 1f9ed21ce218ebcd0e1c803b7da08dd4e33d01a3 for UEFI-671d19d0-d43c-4852-98d9-1ce16f9967e4-dev0
# FuDevice-DEBUG: using 8c7c8f687a2a7a80b4c50e575d0fd84762edf797 for UEFI-00000000-0000-0000-0000-000000000000-dev0

(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuDevice-DEBUG: 17:43:16.088: using 8c7c8f687a2a7a80b4c50e575d0fd84762edf797 for UEFI-00000000-0000-0000-0000-000000000000-dev0
# FuPluginUefi-DEBUG: failed to add /<<PKGBUILDDIR>>/plugins/uefi/tests/efi/esrt/entries/entry2: ESRT GUID '00000000-0000-0000-0000-000000000000' was not valid
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/plugins/uefi/uefi-self-test:10011): FuPluginUefi-DEBUG: 17:43:16.088: failed to add /<<PKGBUILDDIR>>/plugins/uefi/tests/efi/esrt/entries/entry2: ESRT GUID '00000000-0000-0000-0000-000000000000' was not valid
ok 10 /uefi/plugin

@doko is it possible a system's ESRT is leaking into the builder process?

Revision history for this message
Mario Limonciello (superm1) wrote :

Oh actually that's a mistake in my interpreting log failure, that is a valid test that we do to make sure that '00000000-0000-0000-0000-000000000000' is invalid.

I don't see why this is looking like a failure, that's the last uefi-self-test that runs.

Revision history for this message
Mario Limonciello (superm1) wrote :

It looks like this is the actual failure:

"# FuCommon-DEBUG: reading /etc/machine-id with 0 bytes
(/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/fu-self-test:9952): FuCommon-DEBUG: 17:43:15.763: reading /etc/machine-id with 0 bytes
Bail out! ERROR:../src/fu-self-test.c:2733:fu_keyring_pkcs7_self_signed_func: assertion failed (error == NULL): pkcs7_sign: There are no embedded data in the structure. [-413] (FwupdError, 11)
--- stderr ---
**
ERROR:../src/fu-self-test.c:2733:fu_keyring_pkcs7_self_signed_func: assertion failed (error == NULL): pkcs7_sign: There are no embedded data in the structure. [-413] (FwupdError, 11)
"

Revision history for this message
Mario Limonciello (superm1) wrote :
Changed in fwupd (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Mario Limonciello (superm1)
Changed in fwupd (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fwupd - 1.3.9-4

---------------
fwupd (1.3.9-4) unstable; urgency=medium

  * Backport a handful of patches from 1_3_X branch:
    - Thunderbolt: create correct GUID for dual controller devices
    - CSR: Fix parsing
    - Motd: Fix refresh target to be network.target
    - Logitech: Fix error in logs on unsigned devices and set protocol for
      signed devices properly.
    - Fix a FTBFS on empty /etc/machine-id in some buildd environments.
      (LP: #1870051)

 -- Mario Limonciello <email address hidden> Wed, 01 Apr 2020 13:43:21 -0500

Changed in fwupd (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.