Ubuntu
munin package

DEP8: master-cron can fail if started close to */5

Bug #1865938 reported by Andreas Hasenack
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
munin (Ubuntu)
Fix Released
Undecided
dann frazier
Focal
Fix Committed
Undecided
dann frazier
Jammy
Fix Committed
Undecided
dann frazier
Kinetic
Won't Fix
Undecided
dann frazier
Lunar
Fix Released
Undecided
dann frazier

Bug Description

[Impact]
Due to a race to the munin autopkgtests, false positives often occur, causing developers to have to re-run the test to allow dependent packages to migrate.

[Test Case]
Trigger the munin autopkgtests. In my experience, they fail about 4% of the time due to this race.

[Fix]
= Background =
The original attempt to fix this issue was added in the Ubuntu delta. There, cleanup code was added into the individual debian/tests/master-* scripts. This is the state of the fix today in focal today.

Debian later merged their own fix, but instead of putting the fix in each of the debian/tests/master-* scripts, they placed it in a central location in debian/tests/munin-master/01.master-components.t. Debian's fix appears to have gone unnoticed for a while in Debian syncs, so Ubuntu carried both implementations. This is the case for jammy and focal.

Both of the above implementations had a remaining race, and that is what this bug aims to address. That race was finally closed in this patch from upstream:
https://salsa.debian.org/debian/munin/-/commit/4ad5847aeec62e91ef810538621afd6511e77f9f

= How to fix it =
The proposed solution is to first move each release to the Debian version of the fix. For focal, this means replacing the Ubuntu version of the fix with the Debian version. For jammy/kinetic, this means just dropping the Ubuntu version (Debian version is already there). Next, we apply the additional fix that closes the race in the Debian version of the test to each release.

[Regression Risk]
The fix only touches code in debian/tests, so the regression impact would be limited to the autopkgtests and therefore not directly impact end users. The likely impact of a regression would be to cause additional false positives.

See original description
Andreas Hasenack (ahasenack)
tags: added: update-excuse
Revision history for this message
dann frazier (dannf) wrote :

I've submitted a patch to Debian:
  https://salsa.debian.org/debian/munin/-/merge_requests/6

Changed in munin (Ubuntu):
assignee: nobody → dann frazier (dannf)
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package munin - 2.0.71-1.1ubuntu1

---------------
munin (2.0.71-1.1ubuntu1) lunar; urgency=medium

  * Merge with Debian unstable. Remaining changes:
    - Add missing test dependency on net-tools for netstat plugin.
    - Disable sysv autopkgtests
    - d/p/munin-node-configure-doc-fix.patch: Remove deprecated argument
      exitnoerror and update some snmp arguments to match their correct naming.
  * autopkgtest: Avoid remaining race with cron shutdown. (LP: #1865938)

munin (2.0.71-1.1) unstable; urgency=medium

  * Non-maintainer upload.
  * No source change upload to rebuild with debhelper 13.10.

munin (2.0.71-1) unstable; urgency=medium

  * New upstream release. Closes: #1019343.
  * d/control:
    - drop several Breaks/Replaces: munin-doc (<< 2.0.37-3) entries as they
      were matched with the Buster release.
    - update standards version to 4.6.1, no changes needed.

 -- dann frazier <email address hidden> Thu, 10 Nov 2022 06:41:20 -0700

Changed in munin (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
dann frazier (dannf) wrote :

Adding block-proposed-* tags to designate this bug as a staged low priority upload, since it only fixes a racy autopkgtest.

description: updated
tags: added: block-proposed-focal block-proposed-jammy block-proposed-kinetic
dann frazier (dannf)
Changed in munin (Ubuntu Focal):
status: New → In Progress
Changed in munin (Ubuntu Jammy):
status: New → In Progress
Changed in munin (Ubuntu Kinetic):
status: New → In Progress
assignee: nobody → dann frazier (dannf)
Changed in munin (Ubuntu Jammy):
assignee: nobody → dann frazier (dannf)
Changed in munin (Ubuntu Focal):
assignee: nobody → dann frazier (dannf)
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Andreas, or anyone else affected,

Accepted munin into kinetic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/munin/2.0.69-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-kinetic to verification-done-kinetic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-kinetic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in munin (Ubuntu Kinetic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-kinetic
Changed in munin (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed-jammy
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Andreas, or anyone else affected,

Accepted munin into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/munin/2.0.57-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in munin (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Andreas, or anyone else affected,

Accepted munin into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/munin/2.0.56-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
dann frazier (dannf) wrote :

All expected autopkgtests passed, so marking verified.

tags: added: verification-done verification-done-focal verification-done-jammy verification-done-kinetic
removed: verification-needed verification-needed-focal verification-needed-jammy verification-needed-kinetic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Proposed package removed from archive

The version of munin in the proposed pocket of Kinetic that was purported to fix this bug report has been removed because the target series has reached its End of Life.

Changed in munin (Ubuntu Kinetic):
status: Fix Committed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.