Theming does not work on LXQt

Bug #1799001 reported by Simon Quigley
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libreoffice (Ubuntu)
Fix Released
Medium
Simon Quigley
Cosmic
Fix Released
Medium
Simon Quigley

Bug Description

[Impact]

Without this change, LibreOffice does not correctly use the Breeze theme, which is needed for consistency with the rest of the Lubuntu, LXQt-based desktop. At times, it is even hard to use because of the inconsistent theming which can hide buttons at times.

[Test Case]

Update to the version of LibreOffice with this patch and open it on a Lubuntu 18.10 installation. It should use the Breeze theming rather than the stock GTK theming on startup.

[Regression Potential]

Little to none. If for some reason the criteria that is used to check for the LXQt desktop no longer works, which is unlikely in a stable release, this will no longer work.

[Other Info]

I submitted these upstream (as my first patches \o/):
https://gerrit.libreoffice.org/61641
https://gerrit.libreoffice.org/61751

Simon Quigley (tsimonq2)
Changed in libreoffice (Ubuntu Cosmic):
assignee: nobody → Simon Quigley (tsimonq2)
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libreoffice - 1:6.1.2-0ubuntu4

---------------
libreoffice (1:6.1.2-0ubuntu4) disco; urgency=medium

  * Make LibreOffice under the LXQt desktop environment use the Breeze theme
    as the default (LP: #1799001).

 -- Simon Quigley <email address hidden> Sat, 03 Nov 2018 16:08:28 -0500

Changed in libreoffice (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Simon, or anyone else affected,

Accepted libreoffice into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libreoffice/1:6.1.2-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in libreoffice (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Revision history for this message
Chris Guiver (guiverc) wrote :

When the files hit my mirror, i installed

guiverc@dx6120lu:~$ dpkg -l |grep libreoffice |grep "1.1"
ii libreoffice-common 1:6.1.2-0ubuntu1.1 all office productivity suite -- arch-independent files
ii libreoffice-java-common 1:6.1.2-0ubuntu1.1 all office productivity suite -- arch-independent Java support files
ii libreoffice-style-breeze 1:6.1.2-0ubuntu1.1 all office productivity suite -- Breeze symbol style
ii libreoffice-style-colibre 1:6.1.2-0ubuntu1.1 all office productivity suite -- colibre symbol style
ii libreoffice-style-tango 1:6.1.2-0ubuntu1.1 all office productivity suite -- Tango symbol style

after which I logged out & back in. I then re-tested libreoffice...

Simon, I'm not sure what the issue was (and I'm no good with aesthetics), but I SEE NO CHANGE.

When this lp.bug hit my inbox I looked for what your issue was, and the only thing I saw was black boxes kept being drawn when you hovered over buttons, eg. if I went into print-preview, if you move the mouse over 'close preview' a dark box starts flashing slightly-low-left over the close-preview button and makes it hard to read. I assumed this was what this bug was about, as it occurs elsewhere too. This 'flaw' (or issue) appears to have not been altered.

I could be complete wrong - feel free [as always] to ping me (irc, etc). I saw no adverse effects, but it didn't fix what I hoped it would (which could be a different thing...) ps: if what I've described is something else & needs a lp.bug raised - just tell me.

Revision history for this message
Chris Guiver (guiverc) wrote :

my appearance settings if needed (uploaded this as only place where I saw breeze)

My LXQt theme is "Lubuntu Arc"

ps: i've taken quite a few screenshots before & after change so I could look for differences, I can upload if desired, but I didn't see anything of value.

Revision history for this message
Hans P. Möller (hmollercl) wrote :

I did see a change. Icons are changed from Tango (previous default) to Breeze (new default).

Revision history for this message
Olivier Tilloy (osomon) wrote :

@Chris: the output of the dpkg command you provided in #3 suggests not all the packages were built at the time you tried it (you only installed the architecture-independent packages from the update), can you try again and confirm that libreoffice uses the breeze theme by default, on Lubuntu/LXQt?

Revision history for this message
Chris Guiver (guiverc) wrote :

Booted same box; dist-upgrade; confirmed LXQt appearance settings were the same, and then re-ran

Icons on main screen have changed. I've attached screenshot.

(I didn't find breeze icon set online to compare with sorry)

Revision history for this message
Chris Guiver (guiverc) wrote :

i'm running a QA-test on daily image; the icons or theme on the daily image appears like that I attached in my last (#7) comment but "base database" greyed out (no document etc)

Revision history for this message
ԜаӀtеr Ⅼарсһуnѕkі (wxl) wrote :

I can confirm this also functions correctly on Cosmic.

tags: added: verification-done-cosmic
removed: verification-needed-cosmic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for libreoffice has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libreoffice - 1:6.1.2-0ubuntu1.1

---------------
libreoffice (1:6.1.2-0ubuntu1.1) cosmic; urgency=medium

  * Make LibreOffice under the LXQt desktop environment use the Breeze theme
    as the default (LP: #1799001).
  * Backport a patch from upstream which fixes testcases with OpenJDK 11
    (LP: #1796361).

 -- Simon Quigley <email address hidden> Sat, 03 Nov 2018 15:14:37 -0500

Changed in libreoffice (Ubuntu Cosmic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.