dpkg-source on xenial doesn't support .asc file in .dsc for v1.0 source format

Bug #1751114 reported by Timo Aaltonen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dpkg (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Adam Conrad

Bug Description

[Impact]
Source packages built on bionic where the upstream tarball comes with an upstream signature (.asc) are rejected by the ftpmaster, because dpkg-source there is too old.

This is also affecting Debian imports in launchpad.

[Test Case]
Build a source pkg with a tarball & .asc on bionic, extract on xenial

[Regression Potential]
None. The patch is very simple and merely recognizes the file as a valid member and then does nothing with it.

Timo Aaltonen (tjaalton)
description: updated
Changed in dpkg (Ubuntu):
status: New → Invalid
Adam Conrad (adconrad)
description: updated
Changed in dpkg (Ubuntu Xenial):
assignee: nobody → Adam Conrad (adconrad)
Changed in dpkg (Ubuntu):
status: Invalid → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Timo, or anyone else affected,

Accepted dpkg into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dpkg/1.18.4ubuntu1.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dpkg (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed verification-needed-xenial
Revision history for this message
Adam Conrad (adconrad) wrote :
Download full text (3.4 KiB)

(xenial-amd64)root@nosferatu:/home/adconrad/xorg# grep '\.asc' xorg-server*dsc
 4d761e7fb1595637beb035c0b300e1b93d30fdb7 705 xorg-server_1.19.6.orig.tar.gz.asc
 d4672cc887a2037708dbc21e261fc1264d2808feb1f9d85b40ae7848fbb19443 705 xorg-server_1.19.6.orig.tar.gz.asc
 4708215dc9dd371ceee52c7760d7fc5c 705 xorg-server_1.19.6.orig.tar.gz.asc
(xenial-amd64)root@nosferatu:/home/adconrad/xorg# dpkg -l libdpkg-perl | grep ^i
ii libdpkg-perl 1.18.4ubuntu1.3 all Dpkg perl modules
(xenial-amd64)root@nosferatu:/home/adconrad/xorg# dpkg-source -x xorg-server_1.19.6*dsc
gpgv: Signature made Thu Feb 22 10:59:56 2018 MST using RSA key ID A88984DC
gpgv: Can't check signature: public key not found
dpkg-source: warning: failed to verify signature on ./xorg-server_1.19.6-1ubuntu2.dsc
dpkg-source: info: extracting xorg-server in xorg-server-1.19.6
dpkg-source: error: unrecognized file for a v1.0 source package: xorg-server_1.19.6.orig.tar.gz.asc
(xenial-amd64)root@nosferatu:/home/adconrad/xorg# apt-get install libdpkg-perl
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following additional packages will be installed:
  dpkg-dev
Suggested packages:
  debian-keyring
Recommended packages:
  libalgorithm-merge-perl libfile-fcntllock-perl
The following packages will be upgraded:
  dpkg-dev libdpkg-perl
2 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
Need to get 779 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n]
Get:1 http://us.archive.ubuntu.com/ubuntu xenial-proposed/main amd64 dpkg-dev all 1.18.4ubuntu1.4 [584 kB]
Get:2 http://us.archive.ubuntu.com/ubuntu xenial-proposed/main amd64 libdpkg-perl all 1.18.4ubuntu1.4 [195 kB]
Fetched 779 kB in 0s (1011 kB/s)
(Reading database ... 15190 files and directories currently installed.)
Preparing to unpack .../dpkg-dev_1.18.4ubuntu1.4_all.deb ...
Unpacking dpkg-dev (1.18.4ubuntu1.4) over (1.18.4ubuntu1.3) ...
Preparing to unpack .../libdpkg-perl_1.18.4ubuntu1.4_all.deb ...
Unpacking libdpkg-perl (1.18.4ubuntu1.4) over (1.18.4ubuntu1.3) ...
Setting up libdpkg-perl (1.18.4ubuntu1.4) ...
Setting up dpkg-dev (1.18.4ubuntu1.4) ...
(xenial-amd64)root@nosferatu:/home/adconrad/xorg# dpkg-source -x xorg-server_1.19.6*dsc
gpgv: Signature made Thu Feb 22 10:59:56 2018 MST using RSA key ID A88984DC
gpgv: Can't check signature: public key not found
dpkg-source: warning: failed to verify signature on ./xorg-server_1.19.6-1ubuntu2.dsc
dpkg-source: info: extracting xorg-server in xorg-server-1.19.6
dpkg-source: info: unpacking xorg-server_1.19.6.orig.tar.gz
dpkg-source: info: applying xorg-server_1.19.6-1ubuntu2.diff.gz
dpkg-source: info: upstream files that have been modified:
 xorg-server-1.19.6/.dir-locals.el
 xorg-server-1.19.6/config/dbus-api
 xorg-server-1.19.6/damageext/damageext.h
 xorg-server-1.19.6/doc/c-extensions
 xorg-server-1.19.6/fix-miregion
 xorg-server-1.19.6/fix-miregion-private
 xorg-server-1.19.6/fix-patch-whitespace
 xorg-server-1.19.6/fix-region
 xorg-server-1.19.6/hw/kdrive/Xkdrive.man
 xorg-server-1.19.6/hw/kdrive/fbdev/Xfbdev.man
 xorg-server-1.19.6/hw/xfree86/os-suppor...

Read more...

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dpkg - 1.18.4ubuntu1.4

---------------
dpkg (1.18.4ubuntu1.4) xenial; urgency=medium

  * Cherry-pick d01212f2d7e59fc713c66b5d60421ac2296c1463 from 1.18.5:
    - Allow detached upstream orig tarball signatures when extracting
      version 1.0 non-native source packages (LP: #1751114)

 -- Adam Conrad <email address hidden> Wed, 14 Mar 2018 13:17:08 -0600

Changed in dpkg (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for dpkg has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.