arm64: failure with small objects passed on stack

Bug #1513958 reported by dann frazier
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libffi (Ubuntu)
Fix Released
Medium
Unassigned
Trusty
Fix Released
Medium
dann frazier

Bug Description

[Impact]
It isn't possible to build newer versions of python-cffi on trusty/arm64 because it's test cases will fail due to this bug. The thing that's biting me is that cloud-archive:liberty is incomplete on arm64, making key packages uninstallable on arm64 (e.g. nova-compute).

Additionally, libffi is used by several languages in Ubuntu (python, ruby, haskell, etc), so this may also be causing issues in the closed set of Ubuntu/trusty packages. I don't have evidence either way.

[TestCase]
Build python-cffi_1.1.2-1ubuntu2 from wily on trusty/arm64. With unfixed libffi, the build will fail during dh_auto_test in the
"TestFFI.test_struct_by_value" test case.

[Regression Risk]
The fix is in the aarch64-specific code, so there's a negligible risk of regression on other platforms. This exact fix was included in vivid and wily and no regressions have been triaged to libffi in those releases.

dann frazier (dannf)
Changed in libffi (Ubuntu):
status: New → Fix Released
Changed in libffi (Ubuntu Trusty):
status: New → In Progress
assignee: nobody → dann frazier (dannf)
importance: Undecided → Medium
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello dann, or anyone else affected,

Accepted libffi into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libffi/3.1~rc1+r3.0.13-12ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libffi (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
dann frazier (dannf)
tags: added: verification-done
removed: verification-needed
Mathew Hodson (mhodson)
Changed in libffi (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libffi - 3.1~rc1+r3.0.13-12ubuntu0.1

---------------
libffi (3.1~rc1+r3.0.13-12ubuntu0.1) trusty; urgency=medium

  * Fix an AArch64 issue, taken from upstream:
    For any 1-16 byte structure not passed in registers, we weren't copying
    from the object to be passed, but from the array of objects.
    (LP: #1513958)

 -- dann frazier <email address hidden> Fri, 06 Nov 2015 13:33:54 -0700

Changed in libffi (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for libffi has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.