autopkgtest: only collect dkms make logs if they exist

Bug #1498896 reported by Andy Whitcroft
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dkms (Ubuntu)
Fix Released
High
Andy Whitcroft
Precise
Fix Released
High
Andy Whitcroft
Trusty
Fix Released
High
Andy Whitcroft
Vivid
Fix Released
High
Andy Whitcroft
Wily
Fix Released
High
Andy Whitcroft

Bug Description

When testing binary packages from a dkms source we install each package and check if it has dkms configuration in it, if not we ignore it. Unfortunatly we attempt to collect make.log for the dkms module regardless of whether it was a dkms package triggering it to fail and stop processing for this source:

    I: Installing binary package tp-smapi-source
    [...]
    /usr/lib/dkms/dkms-autopkgtest: 15: cd: can't cd to /var/lib/dkms

SRU TEST CASE:
 - Run adt-run --apt-pocket=proposed -U tp-smapi --- qemu adt-precise-amd64-cloud.img # (or on any other release)
 - With current version this fails like https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-precise/precise/i386/t/tp-smapi/20150923_105948%40/log.gz
 - With fixed version the "wrong" tp-smapi-source binary should be skipped and it should go on testing the tp-smapi-dkms package. THis should then build a module and succeed.

Revision history for this message
Andy Whitcroft (apw) wrote :

Proposed fix for wily.

Changed in dkms (Ubuntu):
importance: Undecided → High
assignee: nobody → Andy Whitcroft (apw)
status: New → In Progress
tags: added: patch
Martin Pitt (pitti)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Andy, or anyone else affected,

Accepted dkms into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dkms/2.2.0.3-2ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dkms (Ubuntu Vivid):
status: New → Fix Committed
tags: added: verification-needed
Changed in dkms (Ubuntu Wily):
status: In Progress → Fix Committed
Changed in dkms (Ubuntu Trusty):
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Hello Andy, or anyone else affected,

Accepted dkms into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dkms/2.2.0.3-1.1ubuntu5.14.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in dkms (Ubuntu Precise):
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Hello Andy, or anyone else affected,

Accepted dkms into precise-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dkms/2.2.0.3-1ubuntu3.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Andy Whitcroft (apw)
Changed in dkms (Ubuntu Vivid):
importance: Undecided → High
Changed in dkms (Ubuntu Trusty):
importance: Undecided → High
Changed in dkms (Ubuntu Precise):
importance: Undecided → High
assignee: nobody → Andy Whitcroft (apw)
Changed in dkms (Ubuntu Trusty):
assignee: nobody → Andy Whitcroft (apw)
Changed in dkms (Ubuntu Vivid):
assignee: nobody → Andy Whitcroft (apw)
Changed in dkms (Ubuntu Wily):
milestone: none → ubuntu-15.09
Revision history for this message
Martin Pitt (pitti) wrote :

The upload auto-triggered new test runs of all DKMS packages against the new DKMS:

 - http://people.canonical.com/~ubuntu-archive/proposed-migration/vivid/update_excuses.html#dkms
    particularly http://autopkgtest.ubuntu.com/packages/t/tp-smapi/vivid/i386/ (as per SRU test case), first run failed, second run (with -proposed dkms) succeeds

 - http://people.canonical.com/~ubuntu-archive/proposed-migration/trusty/update_excuses.html#dkms
   http://autopkgtest.ubuntu.com/packages/t/tp-smapi/trusty/i386/

 - http://people.canonical.com/~ubuntu-archive/proposed-migration/precise/update_excuses.html#dkms
   http://autopkgtest.ubuntu.com/packages/t/tp-smapi/precise/amd64/

Note that there are some packages that are shown as "regression"; this is because these DKMS packages don't work against these release's default linux-meta, but they do work against some other kernel (e. g. linux-meta-lts-vivid, or linux-ti-omap4). This is not a regression with DKMS though, as these already failed with the previous DKMS.

Thus I consider this verified. Thanks Andy for fixing!

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkms - 2.2.0.3-2ubuntu4

---------------
dkms (2.2.0.3-2ubuntu4) wily; urgency=low

  * d/s/autopkgtest: only collect logs if there are any. (LP: #1498896)

 -- Andy Whitcroft <email address hidden> Wed, 23 Sep 2015 13:15:19 +0100

Changed in dkms (Ubuntu Wily):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkms - 2.2.0.3-2ubuntu3.1

---------------
dkms (2.2.0.3-2ubuntu3.1) vivid; urgency=low

  * d/s/autopkgtest: only collect logs if there are any. (LP: #1498896)

 -- Andy Whitcroft <email address hidden> Wed, 23 Sep 2015 13:15:19 +0100

Changed in dkms (Ubuntu Vivid):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for dkms has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkms - 2.2.0.3-1.1ubuntu5.14.04.3

---------------
dkms (2.2.0.3-1.1ubuntu5.14.04.3) trusty; urgency=low

  * d/s/autopkgtest: only collect logs if there are any. (LP: #1498896)

 -- Andy Whitcroft <email address hidden> Wed, 23 Sep 2015 15:21:08 +0100

Changed in dkms (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkms - 2.2.0.3-1ubuntu3.4

---------------
dkms (2.2.0.3-1ubuntu3.4) precise-proposed; urgency=low

  * d/s/autopkgtest: only collect logs if there are any. (LP: #1498896)

 -- Andy Whitcroft <email address hidden> Wed, 23 Sep 2015 15:39:40 +0100

Changed in dkms (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.