Ubuntu
fldigi package

Ubuntu 15.10: fldigi 3.22.04-1 crashes on start-up

Bug #1448188 reported by sombrero
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
fldigi (Ubuntu)
Fix Released
High
Kamal Mostafa
Vivid
Fix Released
High
Kamal Mostafa
Wily
Fix Released
High
Kamal Mostafa

Bug Description

*** Ubuntu Vivid SRU justification : Please refer to comment #11 ***

-------------------------------------------------------------

I just upgraded from Ubuntu 14.10 to 15.04. fldigi now crashes with:

dave@sparrow:~$ fldigi
I: main: appname: fldigi
I: main: HomeDir: /home/dave/.fldigi/
I: main: RigsDir: /home/dave/.fldigi/rigs/
I: main: ScriptsDir: /home/dave/.fldigi/scripts/
I: main: PalettesDir: /home/dave/.fldigi/palettes/
I: main: LogsDir: /home/dave/.fldigi/logs/
I: main: PicsDir: /home/dave/.fldigi/images/
I: main: HelpDir: /home/dave/.fldigi/help/
I: main: MacrosDir: /home/dave/.fldigi/macros/
I: main: WrapDir: /home/dave/.fldigi/wrap/
I: main: TalkDir: /home/dave/.fldigi/talk/
I: main: TempDir: /home/dave/.fldigi/temp/
I: main: KmlDir: /home/dave/.fldigi/kml/
I: main: PskMailDir: /home/dave/
I: main: DATA_dir: /home/dave/.fldigi/data/
I: main: NBEMS_dir: /home/dave/.nbems/
I: main: ARQ_dir: /home/dave/.nbems/ARQ/
I: main: ARQ_files_dir: /home/dave/.nbems/ARQ/files/
I: main: ARQ_recv_dir: /home/dave/.nbems/ARQ/recv/
I: main: ARQ_send: /home/dave/.nbems/ARQ/send/
I: main: WRAP_dir: /home/dave/.nbems/WRAP/
I: main: WRAP_recv_dir: /home/dave/.nbems/WRAP/recv/
I: main: WRAP_send_dir: /home/dave/.nbems/WRAP/send/
I: main: WRAP_auto_dir: /home/dave/.nbems/WRAP/auto/
I: main: ICS_dir: /home/dave/.nbems/ICS/
I: main: ICS_msg_dir: /home/dave/.nbems/ICS/messages/
I: main: ICS_tmp_dir: /home/dave/.nbems/ICS/templates/
I: main: FLMSG_dir: /home/dave/.nbems/
I: main: FLMSG_dir_default: /home/dave/.nbems/
I: main: FLMSG_WRAP_dir: /home/dave/.nbems/WRAP/
I: main: FLMSG_WRAP_recv_dir: /home/dave/.nbems/WRAP/recv/
I: main: FLMSG_WRAP_send_dir: /home/dave/.nbems/WRAP/send/
I: main: FLMSG_WRAP_auto_dir: /home/dave/.nbems/WRAP/auto/
I: main: FLMSG_ICS_dir: /home/dave/.nbems/ICS/
I: main: FLMSG_ICS_msg_dir: /home/dave/.nbems/ICS/messages/
I: main: FLMSG_ICS_tmp_dir: /home/dave/.nbems/ICS/templates/

Caught signal 11
Aborting fldigi due to a fatal error.
Please report this to: <email address hidden>
or file a bug report at: https://fedorahosted.org/fldigi/newticket

****** Stack trace:
fldigi[0x58a132]
fldigi[0x58a2f3]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x10d10)[0x7fe42b12dd10]
/usr/lib/x86_64-linux-gnu/libfltk.so.1.3(_ZN23Fl_Xlib_Graphics_Driver6heightEv+0x10)[0x7fe42ac74a10]
/usr/lib/x86_64-linux-gnu/libfltk.so.1.3(_Z9fl_heightii+0x38)[0x7fe42ac71598]
fldigi[0x649515]
fldigi[0x64d861]
fldigi[0x646c86]
fldigi[0x64e490]
fldigi[0x64f41c]
fldigi[0x651cce]
fldigi[0x49783a]
fldigi[0x4a02f5]
fldigi[0x41988e]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7fe428c4ea40]
fldigi[0x41f63c]

****** Version information:
fldigi 3.22.04
Copyright (C) 2007-2010 Dave Freese, Stelios Bounanos, and others.
License GPLv3+: GNU GPL version 3 or later <http://www.gnu.org/licenses/gpl-3.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

****** Build information:
Build information:
  built : Fri Jan 9 05:15:27 UTC 2015 by buildd@brownie on x86_64-pc-linux-gnu for x86_64-pc-linux-gnu

  configure flags: '--build=x86_64-linux-gnu' '--prefix=/usr' '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' '--sysconfdir=/etc' '--localstatedir=/var' '--libexecdir=${prefix}/lib/fldigi' '--disable-maintainer-mode' '--disable-dependency-tracking' 'CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security' 'CPPFLAGS=-D_FORTIFY_SOURCE=2' 'CXXFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security' 'FCFLAGS=-g -O2 -fstack-protector-strong' 'FFLAGS=-g -O2 -fstack-protector-strong' 'GCJFLAGS=-g -O2 -fstack-protector-strong' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro' 'OBJCFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security' 'OBJCXXFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security' '--disable-silent-rules' 'build_alias=x86_64-linux-gnu'

  compiler : gcc version 4.9.2 (Ubuntu 4.9.2-10ubuntu1)

  compiler flags : -I$(srcdir) -I$(srcdir)/include -I$(srcdir)/irrxml -I$(srcdir)/libtiniconv -I$(srcdir)/fileselector -I$(srcdir)/xmlrpcpp -pthread -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/freetype2 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_THREAD_SAFE -D_REENTRANT -D_REENTRANT -I/usr/include/libpng12 -pipe -Wall -fexceptions -O2 -ffast-math -finline-functions -DNDEBUG

  linker flags : -lportaudio -lasound -lm -lpthread -Wl,-Bsymbolic-functions -lfltk_images -lfltk -lX11 -lX11 -lsndfile -lsamplerate -lpulse-simple -lpulse -lhamlib -lm -lpng12 -ldl -lpthread

  libraries : FLTK 1.3.1
                   libsamplerate 0.1.8
                   libsndfile 1.0.25
                   PortAudio 19
                   PulseAudio 4.0
                   Hamlib 1.2.15.3

Runtime information:
  system : Linux sparrow 3.19.0-15-generic #15-Ubuntu SMP Thu Apr 16 23:32:37 UTC 2015 x86_64

  libraries : libsamplerate-0.1.8 (c) 2002-2008 Erik de Castro Lopo
                   libsndfile-1.0.25
                   PortAudio V19-devel (built Feb 25 2014 21:09:53) 1899
                   Pulseaudio 6.0.0
                   Hamlib 1.2.15.3

This is from:

dave@sparrow:~$ apt-cache policy fldigi
fldigi:
  Installed: 3.22.04-1
  Candidate: 3.22.04-1
  Version table:
 *** 3.22.04-1 0
        500 http://gb.archive.ubuntu.com/ubuntu/ vivid/universe amd64 Packages
        100 /var/lib/dpkg/status

For info: I have successfully compiled fldigi 3.22.07 from source on 15:04 but the resulting executable also crashes on start-up as above.

See original description
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in fldigi (Ubuntu):
status: New → Confirmed
Revision history for this message
Kari Karvonen (l-ubuntuone-w) wrote :

This is probablys somehow related to config file. I was able to start fldigi with command

 fldigi --config-dir /tmp/

Revision history for this message
Kari Karvonen (l-ubuntuone-w) wrote :

It looks that this can be uprage issue. Incompatible fldigi_def.xml maybe. I don't know which parameter there but I was able to get fldigi work with these steps.

1. Backup your old config

 cp ~/.fldigi/fldigi_def.xml ~/.fldigi/fldigi_def.xml.backup

2. start fldigi with

 fldigi --config-dir /tmp/

3. Quit fldigi and copy new fldigi_def.xml from /tmp to your fldigi directory

 cp /tmp/fldigi_def.xml ~/.fldigi/fldigi_def.xml

4. Start fldigi. You have to enter your data again. You have your old config saved ~/.fldigi/fldigi_def.xml.backup so you can open backup with your favourite text editor and look your settings from there.

Kamal Mostafa (kamalmostafa)
Changed in fldigi (Ubuntu):
assignee: nobody → Kamal Mostafa (kamalmostafa)
status: Confirmed → In Progress
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Attached patch fixes this bug. Fixed binary packages will be available soon.

Kamal Mostafa (kamalmostafa)
Changed in fldigi (Ubuntu Vivid):
status: New → In Progress
assignee: nobody → Kamal Mostafa (kamalmostafa)
importance: Undecided → High
Changed in fldigi (Ubuntu Wily):
importance: Undecided → High
Ubuntu Foundations Team Bug Bot (crichton)
tags: added: patch
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

Fixed as of fldigi 3.22.08-2 (Debian). Patch has been submitted upstream.

Ubuntu packages of fldigi 3.22.08-2 are available from either of these PPA's:
  https://launchpad.net/~kamalmostafa/+archive/ubuntu/fldigi
  https://launchpad.net/~ubuntu-hams-updates/+archive/ubuntu/ppa

Changed in fldigi (Ubuntu Wily):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fldigi - 3.22.08-2

---------------
fldigi (3.22.08-2) unstable; urgency=high

  * debian: fix-fl_height-startup-crash.patch (LP: #1448188)

 -- Kamal Mostafa <email address hidden> Thu, 28 May 2015 13:22:25 -0700

Changed in fldigi (Ubuntu Wily):
status: Fix Committed → Fix Released
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

*** vivid SRU justification : fldigi (3.22.04-1ubuntu1) ***

[Impact]

 * Access of some uninitialized structures at startup manifests either
   as a no-op or a crash, depending on the state of the user's fldigi
   application configuration file(s).

 * This affects a substantial number of fldigi users upon upgrade to vivid,
   as noted by this bug, its duplicate, and many posts on the linuxham mailing
   list (noted in the patch).

 * The vivid SRU upload (3.22.04-1ubuntu1) applies ONLY the one-line patch
   (attached to this bug) which prevents access of the structures until after
   they've been initialized. That patch has been applied to Debian unstable
   and Ubuntu wily (as of 3.22.08-2), and has been submitted upstream.

[Test Case]

 * Testing the fix required an fldigi configuration state which happens
   to trigger the crash. This fix has been successfully tested by two
   users who did experience the crash. This procedure may or may not
   result in a crashing configuration.

   1. Start up an older version of fldigi and configure it via its setup
      wizard.
   2. Upgrade fldigi to version 3.22.04-1 and try starting it.
   3. Observe crash with dump referring to "fl_height" (see bug report).
   4. Upgrade fldigi to version 3.22.04-1ubuntu1 and try starting it.
   5. Observe no crash.

[Regression Potential]

 * Regressions resulting from this fix seem unlikely. The changed
   routine relates to font and window sizes.

Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

This patch has been committed and released in v3.22.09 upstream:

commit dac5bf4dd83494b7c21f7f41ee63ad22f7f09ff8
Author: Kamal Mostafa <email address hidden>
Date: Thu May 28 10:43:51 2015 -0700

    Fl_Text_Display

      * Avoid calling resize() too early

Kamal Mostafa (kamalmostafa)
Changed in fldigi (Ubuntu Wily):
status: Fix Released → In Progress
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

This patch has been determined to be invalid; a new fix is being tested now. Cancel the SRU request (comment #7).

Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

A proper fix has been committed and released in v3.22.10 upstream:

commit dfc430ff37d3488192e01947e68229a527c649d3
Author: David Freese <email address hidden>
Date: Mon Jun 1 08:37:29 2015 -0500

    FTextView styles bug

      * Corrected order of calling reset_styles to prevent
        calling resize with an improperly initialized styles
        table
      * This rescinds commit dac5bf4dd83494b7c21f7f41ee63ad22f7f09ff8

Changed in fldigi (Ubuntu Wily):
status: In Progress → Fix Committed
Revision history for this message
Kamal Mostafa (kamalmostafa) wrote :

*** vivid SRU justification : fldigi (3.22.04-1ubuntu2) ***

[Impact]

 * Access of some uninitialized structures at startup manifests either
   as a no-op or a crash, depending on the state of the user's fldigi
   application configuration file(s).

 * This affects a substantial number of fldigi users upon upgrade to vivid,
   as noted by this bug, its duplicate, and many posts on the linuxham mailing
   list, e.g.:
     https://groups.yahoo.com/neo/groups/linuxham/conversations/topics/26170
     https://groups.yahoo.com/neo/groups/linuxham/conversations/topics/28010

 * The vivid SRU upload (3.22.04-1ubuntu2) applies a straightforward backport
   of the upstream patch from upstream 3.22.10 which corrects the structure
   access order. That version (3.22.10) has been deployed to Debian unstable so
   will appear in Ubuntu wily.

[Test Case]

 * Testing the fix required an fldigi configuration state which happens
   to trigger the crash. This fix has been successfully tested by two
   users who did experience the crash. This procedure may or may not
   result in a crashing configuration.

   1. Start up an older version of fldigi and configure it via its setup
      wizard.
   2. Upgrade fldigi to version 3.22.04-1 and try starting it.
   3. Observe crash with dump referring to "fl_height" (see bug report).
   4. Upgrade fldigi to version 3.22.04-1ubuntu2 and try starting it.
   5. Observe no crash.

[Regression Potential]

 * Regressions resulting from this fix would likely manifest in a similar
   way as the original failure: crashes at startup.

description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fldigi - 3.22.10-1

---------------
fldigi (3.22.10-1) unstable; urgency=high

  * New upstream release
    - Proper fix for the fl_height startup crash (LP: #1448188)
      - upstream: dfc430f FTextView styles bug
  * debian: drop fix-fl_height-startup-crash.patch

 -- Kamal Mostafa <email address hidden> Mon, 01 Jun 2015 13:57:07 -0700

Changed in fldigi (Ubuntu Wily):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello sombrero, or anyone else affected,

Accepted fldigi into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fldigi/3.22.04-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in fldigi (Ubuntu Vivid):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
sombrero (david-prout) wrote :

dave@hawk:~$ dpkg -l fldigi | cat
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name Version Architecture Description
+++-==============-================-============-============================================
ii fldigi 3.22.04-1ubuntu2 amd64 digital modem program for hamradio operators

I have successfully tested the fix on both an Acer 5742 laptop and a generic i7 workstation running 15.04.

On both machines fldigi as downloaded from the vivid-proposed repository fully corrects the bug that caused fldigi to crash on start-up in 15.04.

 After initialisation fldigi appears to be working correctly I was able to decode 40m CW from the RAF Hack Green WebSDR and 20m PSK63 from the University of Twente WebSDR. Transmit functions also appear to be working but due to a reorganisation I cannot test with a real transmitter.

Many thanks to all concerned for quickly providing a work-around and then this full fix.

Regards,
Dave

sombrero (david-prout)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package fldigi - 3.22.04-1ubuntu2

---------------
fldigi (3.22.04-1ubuntu2) vivid; urgency=high

  * debian: [backport] dfc430f FTextView styles bug
    - Properly fix fl_height startup crash. (LP: #1448188)

 -- Kamal Mostafa <email address hidden> Mon, 01 Jun 2015 15:38:51 -0700

Changed in fldigi (Ubuntu Vivid):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for fldigi has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.