adt wait-for-device doesn't timeout in a reboot test

Bug #1414939 reported by Vincent Ladeuil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
autopkgtest (Ubuntu)
Fix Released
High
Martin Pitt

Bug Description

From fginther:

Experimenting with a test known to fail the reboot on the phone, 'apt-get remove -y --force-yes lxc'.

adt-run does not timeout by default in a short enough time period. Experimenting now with setting specific values:

    --timeout-test=300 : adt-run did not abort after running for 18 minutes. Possibly the reboot is not considered during the timeout?

So it appears that adt-run is using 'adb wait-for-device' after a reboot to wait for the device to come up (see ssh-setup/adb wait_booted()).

There is no timeout around this and I don't see one at any of the callers (but I could be missing it).

 Short term solution is to use 'timeout 600 adt-run ...'

Martin Pitt (pitti)
Changed in autopkgtest (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :
Changed in autopkgtest (Ubuntu):
assignee: Martin Pitt (pitti) → nobody
status: In Progress → Fix Committed
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package autopkgtest - 3.9.3git1

---------------
autopkgtest (3.9.3git1) vivid; urgency=medium

  * Recognize modern "Package-Type:" control field in addition to
    XC-Package-Type.
  * ssh-setup/adb: Guard adb wait-for-device with a 5 min timeout.
    (LP: #1414939)
 -- Martin Pitt <email address hidden> Tue, 27 Jan 2015 13:21:44 +0100

Changed in autopkgtest (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.