Copying html_logo file over improperly checks for file basename instead of relative name

Bug #1273075 reported by Christopher Lee
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sphinx (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Copying html_logo file over improperly checks for file basename instead of relative name (taken from[1])

To quote:
  "1.2.1 inserted a check to see if the html_logo file existed before attempting to copy it over to _static; however, the check is on the basename of the file, so this will always file unless the html_logo file is put into the same dir as conf.py. This should probably check for the relative name instead (i.e. the value of self.config.html_logo)."

There is a patch available here: https://bitbucket.org/birkenfeld/sphinx/pull-request/211/fix-for-issue-1352/diff

[1] https://bitbucket.org/birkenfeld/sphinx/issue/1352/copying-html_logo-file-over-improperly

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: python-sphinx 1.2.1+dfsg-2ubuntu1
ProcVersionSignature: Ubuntu 3.13.0-5.20-generic 3.13.0
Uname: Linux 3.13.0-5-generic x86_64
ApportVersion: 2.13.1-0ubuntu2
Architecture: amd64
CurrentDesktop: Unity
Date: Mon Jan 27 19:36:50 2014
InstallationDate: Installed on 2013-12-17 (40 days ago)
InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Alpha amd64 (20131216)
PackageArchitecture: all
SourcePackage: sphinx
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Christopher Lee (veebers) wrote :
Martin Pitt (pitti)
Changed in sphinx (Ubuntu):
status: New → In Progress
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :
Changed in sphinx (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sphinx - 1.2.1+dfsg-2ubuntu2

---------------
sphinx (1.2.1+dfsg-2ubuntu2) trusty; urgency=medium

  * Add 00upstream_html_logo_path.diff: Fix path check for HTML logo,
    backported from upstream hg. (LP: #1273075)
 -- Martin Pitt <email address hidden> Mon, 27 Jan 2014 08:04:40 +0100

Changed in sphinx (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.