soldier stuck in battle animation loop

Yes, the blue soldier in the save game seems stuck for some reason.

We've had various bugs on issues like this for the past month or so (bug 1247696, bug 1245187, bug 1246865). That's a bit too many in a short while for me to feel comfortable about it. Could someone look into whether there might be a common underlying reason triggering these and whether it would be feasible to fix before the release of build18?

What happened to the branch attached (see full activity log)? Was it simply deleted again or something?

It probably got deleted.

I suggest retargeting this for b19 again. My reasoning is the following:

1) it is not a critical bug in the sense that it makes the game desync or crash.
2) the battle code is a rats nest without tests - I do not feel confident that changing something in it that fixes this issue would not create other issues. I'd much rather try to work on this in b19 by building a comprehensive set of tests too.

I retarget for now. If anyone strongly disagrees, please speak up.

That branch was me. I had a solution which fixed the current blocking when loading the savegame.
But as SirVer mentioned: It broke a lot of other things, for example fights at all ;).

So i deleted it again to save me from a embarrasing code review...

Tino: No problem, I was just curious what happened to it. :)
SirVer: sounds like a good approach.

For the record, this bug prevented me from completing the map "The ancient sun of fire" because the bug occured on the very narrow paths that connect each country to the center. The blocked soliders prevent me from conquering the remaining lands, which is somehow frustrating.

Thanks for the game anyway, I love it.

Setting to incomplete for bug sweeping.

Here is also a soldier fighting in a loop. A blue soldier stands near beside the orange fighting one without interacting in any way.

Unfortunaly i couldn't load a autosaved file, to get the circumstances where this fight beguns. Trying to load such a autosave file triggers an Error:

"economies: player 8: economy: unknown version 778" for autosave 03 (date 22.04.2015 22:57), and
"economies: player 8: economy: unknown version 3280" for autosave 04 (date 22.04.2015 22:45)

Autosaved files 00 to 02 could be loaded. The file test3.wgf is timerelated as nearest to the battle which could be loaded. But in this file the loop is allways there and additionally a second blue soldier has a walk animation but he do not walk.

I attach a zip which contains autosave_04, 03 and test3.wgf

Version: trunk7443

Since bug 1457425 was fixed, would it still be possible to trigger this and related issues?

Could someone please check with r7485 or newer? (Though I realize part of the problem is that I don't know whether we have any sure ways of reproducing/triggering it in the first place...)

It seems to be fixed, so closing the bug

Fixed in build19-rc1.