adt-run broken except when used with adt-virt-null

Bug #1235189 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
autopkgtest (Ubuntu)
Fix Released
High
Martin Pitt

Bug Description

2.3.6 does, in adt-run:run:

os.mkfifo(fifo_out) (and fifo_err)
fifo_out uses the testtmp path.

testtmp is created above that, in the guest.

But os.mkfifo runs in the host.

This causes the traceback:

adt-run: unexpected, exceptional, error:
Traceback (most recent call last):
  File "/usr/bin/adt-run", line 2205, in main
    process_actions()
  File "/usr/bin/adt-run", line 2177, in process_actions
    run_tests(stanzas, act.tests_tree)
  File "/usr/bin/adt-run", line 1315, in run_tests
    t.run(tree)
  File "/usr/bin/adt-run", line 1428, in run
    os.mkfifo(fifo_out)
OSError: [Errno 2] No such file or directory

This is with adt-virt-lxc (which has yet to land), but I believe it will do it with anything but adt-virt-null.

Version 2.3.3 is not affected.

Related branches

Martin Pitt (pitti)
Changed in autopkgtest (Ubuntu):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Martin Pitt (pitti)
milestone: none → ubuntu-13.10
status: Triaged → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

Reproduced in a new test case which exercises the chroot runner, and fixed in git.

Changed in autopkgtest (Ubuntu):
assignee: Martin Pitt (pitti) → nobody
status: In Progress → Fix Committed
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package autopkgtest - 2.3.7

---------------
autopkgtest (2.3.7) unstable; urgency=low

  * tests/adt-run: Factorize a base test class with common functionality.
  * lib/VirtSubproc.py, downtmp_mktemp(): Create temporary directory in the
    target (which isn't the host for anything but the null runner), to fix the
    schroot/chroot runners for directories.
  * Only show stdout/stderr in realtime if tests run in the same file system
    as the host, as otherwise we cannot create/use a named pipe. If not, fall
    back to the old way of just showing the complete stdout/stderr after the
    tests finished. (LP: #1235189)
  * Add some test cases for adt-virt-chroot.
  * Add new --timeout-copy option to make copy timeout configurable. Pass that
    down to adt-virt-* via the environment ($ADT_VIRT_COPY_TIMEOUT).
    (LP: #1200693)
  * Fix tests to also work with Python 3.1.
  * tests/testpkg: Go back to compat level 7 so that this also works on older
    Debian/Ubuntu releases.

 -- Martin Pitt <email address hidden> Tue, 08 Oct 2013 18:55:33 +0200

Changed in autopkgtest (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.