-v version output is broken

Bug #1079941 reported by Dan Mick
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ceph (Ubuntu)
Fix Released
Low
James Page
Quantal
Fix Released
Low
Unassigned
Raring
Fix Released
Low
James Page

Bug Description

ceph -v output is broken in ceph package version 0.48.2-0ubuntu2. This is supposed to get built during any make from
git revparse, which is stored in .git_version, which is then processed by make_version into ceph_ver.h, included in the
sources.

Investigating, it seems as though the source package orig.tar.gz does not contain the file, whereas what we thought we
delivered to the location in debian/watch does. That file in the source tree contains

version=3
http://ceph.com/download/ceph-(\d.*)\.tar\.gz

However, I note that when I fetch the quantal source package with 'pull-lp-source ceph quantal', the debian/watch file in that package points somewhere else entirely:

version=3
https://github.com/ceph/ceph/tags .*/tarball/v(\d[\d\.]+).* debian debian/orig-tar.sh

That location appears not to exist anymore (perhaps github reorganized?) but in any event it's not where we expect the authoritative delivery to live.

I don't know how or why debian/watch is changed.

Revision history for this message
James Page (james-page) wrote :

Hi Dan

Thanks for the report; the reason the source package in Debian and Ubuntu pulls from github is that we don't use the embedded libs3 or leveldb as distributed at http://ceph.com/download/.

I would suspect that this file gets stripped out during the automatic archive creation on github.

Other than not outputting the version number is there any other impact of this problem?

Revision history for this message
Sage Weil (sage-newdream) wrote :

It's not that the file gets stripped out, but that it is generated by 'make dist' when the tarballs are built.

There are --with-system-libs3 and --with-system-leveldb configure flags that ignore the bundled library code. Would it help if those were the defaults? Or is there a fundamental issue with bundled code even if it isn't built?

The missing version string is the only impact. Users can't use 'ceph -v' or query running daemons to determine what version is running (e.g., via 'service ceph status') and get confused.

Revision history for this message
James Page (james-page) wrote :

Thanks for the explanation Sage; I'll review the source of the upstream tarball when I do the initial upload for raring this week (0.54 in preparation for a bobtail upload when release).

I don't have any particular issue with using the distributed tarball rather than what we are doing at the moment.

Cheers

James

Changed in ceph (Ubuntu Quantal):
importance: Undecided → Low
Changed in ceph (Ubuntu Raring):
importance: Undecided → Low
Changed in ceph (Ubuntu Quantal):
status: New → Triaged
Changed in ceph (Ubuntu Raring):
status: New → Triaged
James Page (james-page)
Changed in ceph (Ubuntu Raring):
assignee: nobody → James Page (james-page)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ceph - 0.54-0ubuntu1

---------------
ceph (0.54-0ubuntu1) raring; urgency=low

  * New upstream release, preview for next upstream LTS release
    (LP: #1056462):
    - d/librbd-dev.install: Pickup new features.h file.
    - d/control: Suggest parted to support upstart integration.
    - d/{control,obsync.install}: Drop obsync package inline with
      upstream.
    - d/control: Add xfsprogs to Depends for ceph to support XFS
      as default filesystem (LP: #1028981).
    - d/patches/*: Drop all patches; either included upstream or
      no longer required.
    - d/ceph.lintian-overrides: Added additional overrides for
      new rados class libraries.
  * d/watch: Switch back to using distributed tarball's rather than
    pulling from github so that version resolution works correctly
    (LP: #1079941).
  * Tidied up redundant packaging files from debian directory.
 -- James Page <email address hidden> Mon, 19 Nov 2012 10:15:42 +0000

Changed in ceph (Ubuntu Raring):
status: In Progress → Fix Released
Revision history for this message
Dan Mick (dan-mick) wrote :

Thanks for your prompt attention James. Do you plan to change the configuration options for the s3/leveldb issue?

Revision history for this message
James Page (james-page) wrote :

Use of the --with-system flags was already in the packaging so no further action was required...

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Dan, or anyone else affected,

Accepted ceph into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/ceph/0.48.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ceph (Ubuntu Quantal):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
James Page (james-page) wrote :

ubuntu@juju-quantal-instance-85:~$ sudo ceph -v
ceph version 0.48.3argonaut (commit:920f82e805efec2cae05b79c155c07df0f3ed5dd)
ubuntu@juju-quantal-instance-85:~$ apt-cache policy ceph
ceph:
  Installed: 0.48.3-0ubuntu1
  Candidate: 0.48.3-0ubuntu1
  Version table:
 *** 0.48.3-0ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ quantal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     0.48.2-0ubuntu2 0
        500 http://archive.ubuntu.com/ubuntu/ quantal/main amd64 Packages
ubuntu@juju-quantal-instance-85:~$

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ceph - 0.48.3-0ubuntu1

---------------
ceph (0.48.3-0ubuntu1) quantal-proposed; urgency=low

  * New upstream Ceph Argonaut LTS point release (LP: #1154547):
    - Fixes error when parsing mon_hosts configuration as hostnames
      with space delimiter (LP: #1099900).
    - d/p/extra-byte-for-null.patch: Dropped as included in upstream
      release.
  * d/watch: Use official release tarballs rather than pulling from github
    to ensure that ceph -v is correctly populated (LP: #1079941).
 -- James Page <email address hidden> Tue, 16 Apr 2013 13:20:18 -0700

Changed in ceph (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.