on upgrade lucid -> precise /etc/default/isc-dhcp-server is not migrated

Bug #1003971 reported by Andy Whitcroft
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
isc-dhcp (Ubuntu)
Won't Fix
Medium
Unassigned
Precise
Fix Released
High
Stéphane Graber

Bug Description

When upgrading from lucid->precise the /etc/dhcp3/dhcpd.conf file is correctly migrated to /etc/dhcp/dhcpd.conf, but the settings in /etc/default/dhcp3-server are not migrated to /etc/default/isc-dhcp-server. This leads to the service losing its interface specifications potentially allowing it to serve addresses on the wrong interfaces. Bad.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: isc-dhcp-server 4.1.ESV-R4-0ubuntu5
ProcVersionSignature: Ubuntu 3.2.0-24.38-generic 3.2.16
Uname: Linux 3.2.0-24-generic i686
ApportVersion: 2.0.1-0ubuntu7
Architecture: i386
Date: Thu May 24 15:29:35 2012
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release i386 (20100429)
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
SourcePackage: isc-dhcp
UpgradeStatus: Upgraded to precise on 2012-05-24 (0 days ago)
mtime.conffile..etc.dhcp.dhcpd.conf: 2012-05-24T09:04:21.549574

----

[rational]
Config file isn't migrated, leading to duplicate configuration files and lost settings.

[test case]
1) Install dhcp3-server on Ubuntu 10.04
2) Edit /etc/default/dhcp3-server and change INTERFACES to point to eth0 (for example)
3) (ugly trick) manually update /etc/apt/sources.list to point to precise and include precise-proposed
4) sudo apt-get update
5) sudo apt-get install dhcp3-server (a full dist-upgrade won't work, but selective upgrade of just dhcp3-server will work)
6) Ensure that dhcpd is running, that /etc/default/isc-dhcp-server contains the change you did pre-upgrade and that /etc/default/dhcp3-server no longer exists

[regression potential]
If the previous configuration was broken, the new one will be broken too, but that's really what you'd expect from an upgrade...

Revision history for this message
Andy Whitcroft (apw) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in isc-dhcp (Ubuntu):
status: New → Confirmed
Andy Whitcroft (apw)
Changed in isc-dhcp (Ubuntu Precise):
milestone: none → ubuntu-12.04.1
Changed in isc-dhcp (Ubuntu Precise):
importance: Undecided → High
tags: added: rls-mgr-p-tracking
Changed in isc-dhcp (Ubuntu Precise):
status: New → Triaged
assignee: nobody → Canonical Foundations Team (canonical-foundations)
Steve Langasek (vorlon)
Changed in isc-dhcp (Ubuntu Precise):
assignee: Canonical Foundations Team (canonical-foundations) → Stéphane Graber (stgraber)
Revision history for this message
Stéphane Graber (stgraber) wrote :

Ok, I'll have a look at the same time as another isc-dhcp potential SRU (the pid file path being wrong).

description: updated
Changed in isc-dhcp (Ubuntu Precise):
status: Triaged → In Progress
description: updated
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Andy, or anyone else affected,

Accepted isc-dhcp into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in isc-dhcp (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in isc-dhcp (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Stéphane Graber (stgraber) wrote :

tested here

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package isc-dhcp - 4.1.ESV-R4-0ubuntu5.1

---------------
isc-dhcp (4.1.ESV-R4-0ubuntu5.1) precise-proposed; urgency=low

  * Set -pf option for both isc-dhcp-server and isc-dhcp-server6 so they
    create their pid files in a path that's actually writable. (LP: #985417)
  * Also allow read access to the pid file in the apparmor profile,
    otherwise only the initial start succeeds. (LP: #1005062)
  * On upgrade from dhcp3-server, move /etc/default/dhcp3-server to
    /etc/default/isc-dhcp-server. (LP: #1003971)
  * On upgrade from dhcp3-relay, remove /etc/default/dhcp3-relay.
    (LP: #1005547)
  * Try to preseed isc-dhcp-relay with the values from
    /etc/default/dhcp3-relay. (LP: #1005547)
 -- Stephane Graber <email address hidden> Sun, 27 May 2012 20:41:13 -0400

Changed in isc-dhcp (Ubuntu Precise):
status: Fix Committed → Fix Released
Changed in isc-dhcp (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Stéphane Graber (stgraber) wrote :

Marking quantal task as won't fix because we don't need to support a dhcp3 => dhcp4 upgrade path after 12.04.

Changed in isc-dhcp (Ubuntu):
status: Fix Released → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.