Unity Greeter

Merge lp:~smmckay/unity-greeter/1571640 into lp:unity-greeter/16.04

  1. 1571640
  2. Merge into 16.04
Proposed by Steve McKay
Status: Merged
Merged at revision: 1853
Proposed branch: lp:~smmckay/unity-greeter/1571640
Merge into: lp:unity-greeter/16.04
Diff against target: 28 lines (+9/-1)
2 files modified
debian/changelog (+8/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~smmckay/unity-greeter/1571640
Reviewer Review Type Date Requested Status
Robert Ancell Needs Fixing
Review via email: mp+315249@code.launchpad.net

Description of the change

Update dependency in debian/control to the correct version of
unity-settings-daemon.

To post a comment you must log in.
lp:~smmckay/unity-greeter/1571640 updated
1853. By Steve McKay

* debian/control:
  - Require unity-settings-daemon that actually has xsettings signal fixes.
    (LP: #1571640)

Revision history for this message
Steve McKay (smmckay) wrote :

I tried this package in a PPA (https://launchpad.net/~smmckay/+archive/ubuntu/unity-greeter) and it does fix the bug for me.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

This should be proposed to lp:unity/greeter/16.04, not trunk.

review: Needs Fixing
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Unless this change should also be in trunk? If so, it needs to be merged.

Revision history for this message
Steve McKay (smmckay) wrote :

But I did propose it to lp:unity-greeter/16.04! The page tells me:

Status:
Needs review
Proposed branch: lp:~smmckay/unity-greeter/1571640
Merge into: lp:unity-greeter/16.04

If that's not what you're seeing, or the merge wouldn't land in that branch, then I have no idea what to do. Getting this far was already pretty hard for me (first merge proposal ever).

Revision history for this message
Steve McKay (smmckay) wrote :

These changes landed on trunk in revs 1941 & 1983. Yakkety has been fixed for a while. Heck, unity-greeter/16.04 has all the code changes and fixed unity-settings-daemon is already in xenial-updated. But the SRU for unity-greeter was rejected because the Depends: line in debian/control had the wrong version of unity-settings-daemon.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Oh, so sorry! I completely read the MP wrong. You're completely right...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2016-06-23 21:15:08 +0000
3+++ debian/changelog 2017-01-20 18:44:23 +0000
4@@ -1,3 +1,11 @@
5+unity-greeter (16.04.3-0ubuntu3) xenial; urgency=medium
6+
7+ * debian/control:
8+ - Require unity-settings-daemon that actually has xsettings signal fixes.
9+ (LP: #1571640)
10+
11+ -- Steve McKay <steve@b.abbies.us> Fri, 20 Jan 2017 11:35:56 -0600
12+
13 unity-greeter (16.04.3-0ubuntu2) xenial; urgency=medium
14
15 * debian/control:
16
17=== modified file 'debian/control'
18--- debian/control 2016-06-23 04:26:46 +0000
19+++ debian/control 2017-01-20 18:44:23 +0000
20@@ -32,7 +32,7 @@
21 Depends: ${misc:Depends},
22 ${shlibs:Depends},
23 upstart,
24- unity-settings-daemon (>= 15.04.1+16.04.20160209-0ubuntu2)
25+ unity-settings-daemon (>= 15.04.1+16.04.20160701-0ubuntu1)
26 Recommends: indicator-application,
27 indicator-datetime,
28 indicator-keyboard,

Subscribers

People subscribed via source and target branches