Merge lp:~openerp-dev/openobject-addons/trunk-bug-794412-ron into lp:openobject-addons

thanks for the fix, it fixes the problem in the "bug reported".

This creates another problem.
You have to fix the shipped function field. This shipped function field must work on procurement order, not on pickings otherwise it will not work for services.

i don't understand your comment, fabien; the case of services is already handled by the project_mrp module which overwrites the function _picked_rate of the sale_order. Although it's maybe not the best solution from a design point of view, it seems working just fine currently.

So this patch should be tested but at first sight i don't see any reason not to consider it.

if order.shipped:
   this is generic as it check if the products or services (or other future type of product) are delivered.

for picking in order.picking_ids:
   this only works for stockable products which is not good.

Several modules can inherit and enhance the order.shipped.

You must fix in the order.shipped (so the condition of the workflow)

@qdp the patch may fix the picking ratio, but it does not fixes the main issue: order.shipped is wrong. (this can generate others side effects, like invoice after delivery)

I reject this patch, please do another one that fixes the issue correctly.