Ratings and Reviews server

Merge lp:~mvo/rnr-server/rnrclient-fix-lp870847 into lp:~rnr-developers/rnr-server/rnrclient

  1. rnrclient-fix-lp870847
  2. Merge into rnrclient
Proposed by Michael Vogt
Status: Merged
Merged at revision: 38
Proposed branch: lp:~mvo/rnr-server/rnrclient-fix-lp870847
Merge into: lp:~rnr-developers/rnr-server/rnrclient
Diff against target: 12 lines (+1/-1)
1 file modified
rnrclient.py (+1/-1)
To merge this branch: bzr merge lp:~mvo/rnr-server/rnrclient-fix-lp870847
Reviewer Review Type Date Requested Status
Łukasz Czyżykowski (community) Approve
Review via email: mp+120091@code.launchpad.net

Description of the change

Trivial one liner to fix bug #870847 - the review_text can have "\n" in it.

To post a comment you must log in.
Revision history for this message
Łukasz Czyżykowski (lukasz-czyzykowski) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'rnrclient.py'
2--- rnrclient.py 2011-10-13 13:43:52 +0000
3+++ rnrclient.py 2012-08-17 09:31:00 +0000
4@@ -179,7 +179,7 @@
5 @validate('review_id', int)
6 @validate('rating', int)
7 @validate_pattern('summary', r'[^\n]+')
8- @validate_pattern('review_text', r'[^\n]+')
9+ @validate('review_text', str)
10 @returns(ReviewDetails)
11 def modify_review(self, review_id, rating, summary, review_text):
12 """Modify an existing review"""

Subscribers

People subscribed via source and target branches

to all changes: