Xibo

use of blacklist functionality

Asked by Jacopo Moronato

Is this functionality implemented in .NET client (using 1.4.2 version)?
I see BlackList.cs source file but I can't figure out if it is really used like descripted here: http://wiki.xibo.org.uk/wiki/XMDS_Specification

"- client ... populates the local blacklist cache with info from the blacklist element
- client blacklists any media which causes it problems (eg corrupt files, videos with missing codecs) as required with a call to BlackList referencing the media by it's type and ID, along with a reason"

Question information

Language:
English Edit question
Status:
Solved
For:
Xibo Edit question
Assignee:
No assignee Edit question
Solved by:
Dan Garner
Solved:
Last query:
Last reply:
Revision history for this message
Alex Harrington (alexharrington) said : 		#1

As far as I'm aware the blacklist is only ever held locally at the moment.
But it is definitely used locally by the client

Revision history for this message
Jacopo Moronato (jmoronat) said : 		#2

As far I can see, a BlackList object is used only in Region classes. In Region.cs the constructor creates a new BlackList:

_blackList = new BlackList();

and this is the default constructor redefinition:

public BlackList()
        {
            // Check that the black list file is available
            blackListFile = Application.UserAppDataPath + "//" + Properties.Settings.Default.blackListLocation;

            // Get the key for this display
            hardwareKey = new HardwareKey();
        }

Searched and cannot find any use BlackList's public methods, except for BlackListed method (look in Region.SetNextMediaNodeInOptions():

if (_blackList.BlackListed(_options.mediaid))
                {
                    Trace.WriteLine(new LogMessage("Region - SetNextMediaNode", string.Format("MediaID [{0}] has been blacklisted.", _options.mediaid)), LogType.Error.ToString());

                    // Increment the number of attempts and try again
                    numAttempts++;

                    // Carry on
                    continue;
                }

How is the file being populated?

Revision history for this message
Best Dan Garner (dangarner) said : 		#3

It is not used as described in the XMDS specification. It was put in a long time ago and never fully implemented - then we backed away from it due to the flakey support we had.

It may be re started again at some point as the theory is still sound.

Revision history for this message
Jacopo Moronato (jmoronat) said : 		#4

Thanks Dan Garner, that solved my question.