Comment 106 for bug 1439288

Revision history for this message
In , Hjudt-l (hjudt-l) wrote :

Created attachment 6069
Rework-usage-of-binary-file-size-properties-bug-11450.patch

With the patch attached I have tried to rework the preference handling of misc-file-size-binary a little and for all components. The preference is read in the initialization of the component, and changes are propagated by signals where possible. This way, there should not be any performance problems, and as a bonus, a change of this preference should have an immediate effect (properties dialog, status bar, job window), the exception being the column view where I still have to find out what is missing. Many components have already made use of a preference object already, so there was not much to add.

I tested it and it worked without crashes, but on my system I cannot reproduce the bug, so I cannot tell for sure.

Please try and report back if it also fixes the issue or if you have any problems.