Comment 20 for bug 1927078

Revision history for this message
Lukas Märdian (slyon) wrote (last edit ):

Thank you! This one is looking pretty solid overall.
But I think the "hex detection" has some flaws, as it only checks for capital letters and there is a discrepancy between accepting float hex numbers but rejecting float octal numbers.

IMO hex or octal numbers containing a "." (float) should just be considered non-numeric. Should they?

Could you please test for some more edge cases like and make sure they all work (and maybe also octal floats):

"0xDEADBEEF" "0xcafe42" "0xdeadbeef" "0xdead.beef" "0x."