Comment 13 for bug 1940141

Revision history for this message
Dan Streetman (ddstreet) wrote :

> It's not needed for actual functionality of the backport but that assumes that any future backports or fixes don't break this backport

yes i get that, my comment is about whether or not the patch changes any code *outside* of the self-tests, e.g. the TLSProxy perl code changes. If that's *only* used for self-tests then including in the backport shouldn't cause any regression.

Remember that people reviewing/sponsoring patches may not have deep experience with the code so it's good to more clearly explain things that aren't necessarily obvious, such as the 2nd patch only affecting test code (if that is indeed the case), since at first glance that isn't what it looks like.