Comment 64 for bug 1787405

On Thu, Nov 22, 2018 at 6:35 PM bugproxy <email address hidden> wrote:

> ------- Comment From <email address hidden> 2018-11-22 12:21
> EDT-------
> @Christian E.:
> You listed two libvirt commit IDs
>
> https://libvirt.org/git/?p=libvirt.git;a=commit;h=faab373b53e1a4eacf0d6f524eb47df243f21fac
>
> https://libvirt.org/git/?p=libvirt.git;a=commit;h=f865d58028ccd568b6e7909608678584b12d3c90
> that I cannot find in libvirt. Maybe it's just a copy&paste error.
>

Hmm, yeah that was copy-pasta :-/
The files in my branch are actually good already for completeness here on
the bug the patches that work unmodified on 4.6 are:
https://libvirt.org/git/?p=libvirt.git;a=commit;h=11708641983e9107a129c62fd343d0fec228342f
https://libvirt.org/git/?p=libvirt.git;a=commit;h=208d6e6f5aafa102d04ce300c6338b0736bb52df
https://libvirt.org/git/?p=libvirt.git;a=commit;h=25dde373730545894f60ce5b1497f19d61714c69

I just looked at patch 6 again and it is correct that I have included
> code from another commit (most likely
> d54e45b6edd7623e488a19e30bc4148a21fa8b03) to make the refactoring work
> and compile without noting it down as origin in the commit message.
> Sorry about that.
>

No problem at all.
d54e45b6 is qemuDomainMdevDefValidate which is in patch #5 actually already.
But #6 is is qemuDomainMdevDefVFIOAPValidate from 25dde373 and the
extension for AP in 208d6e6f fused into one.
But that is ok, an SRU wants to only pick what is needed and not rework all
the rest - I just wanted to make sure references are ok.
It is mostly for housekeeping and to make it "traceable" for the upcoming
SRU review.