Comment 49 for bug 1787405

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2018-11-16 04:33 EDT-------
(In reply to comment #65)
> FYI: build log of the current incomplete backport:
> https://launchpadlibrarian.net/397706595/buildlog_ubuntu-bionic-s390x.
> libvirt_4.0.0-1ubuntu8.6~ppa1_BUILDING.txt.gz

The build error is due to the changes in the enum virMediatedDeviceModelType
Change the assignment from 2 to 1 for VIR_MDEV_MODEL_TYPE_VFIO_AP.
--- a/src/util/virmdev.h
+++ b/src/util/virmdev.h
@@ -26,6 +26,7 @@
typedef enum {
VIR_MDEV_MODEL_TYPE_VFIO_PCI = 0,
+ VIR_MDEV_MODEL_TYPE_VFIO_AP = 2,
VIR_MDEV_MODEL_TYPE_LAST
} virMediatedDeviceModelType;

There is most likely also trouble ahead regarding the use of the macro virReportEnumRangeError. This needs to be replaced with
virReportError(VIR_ERR_INTERNAL_ERROR,
_("Unexpected enum value %d for "
"virMediatedDeviceModelType"),
mdevsrc->model);

I will try to create a patch series based on v4.0.0