Comment 14 for bug 1759893

Revision history for this message
Seth Forshee (sforshee) wrote :

Have you reported this upstream?

It does look to me that this dependency is working the wrong way, that CONFIG_BLK_DEV_NVME depends on CONFIG_NVME and not the other way around. The driver enabled by CONFIG_BLK_DEV_NVME has no entry points other than the struct pci_driver callbacks, but it does call into the code enabled by CONFIG_NVME.

I'm not convinced that yours is the correct fix though. I suspect that BLK_DEV_NVME should have a "depends on NVM" or "select NVM" instead. What I will do though is revert 32c662c58a9b9d0c99e713a14ca323a9a91c73a0 and change BLK_DEV_NVME back to =m. You should probably follow up upstream to get a fix in place there.